From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbdKJMtR (ORCPT ); Fri, 10 Nov 2017 07:49:17 -0500 Received: from mout.web.de ([212.227.15.3]:58201 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbdKJMtQ (ORCPT ); Fri, 10 Nov 2017 07:49:16 -0500 Subject: [PATCH 3/4] ASN.1: Improve exiting from build_type_list() From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Andrew Morton Cc: LKML References: <960a8501-03b0-95d9-c2bf-4633e48e73a6@users.sourceforge.net> Message-ID: <3a3b73b2-0164-5de8-5540-9d1d25af7018@users.sourceforge.net> Date: Fri, 10 Nov 2017 13:49:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <960a8501-03b0-95d9-c2bf-4633e48e73a6@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:JPczHmauzi5mXGtbOtO2jyLApYYSVNKFjJWNmvZNd5jqtibpsG6 1P+iVe5Vg2AgSHJm7OdDtIM5cWsvhto40PR71AE1MAux19wanwOFsc+mNzv+kYj9Y+IlQab +JLYKx/nSTv+80kWJQWkrbi0hh3ZiyM8Y/o2i0FyRL84ojIyVXJQrMHpgApO09BbY60wW5h 1ka/Q2jtfdz3R9ZLi48lQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:968tuR/NewM=:8vQs0J//7KZDZhRMeDW887 YS41tqmrXCVWVqqbrW58UIi/pDtAYcJFxOT90HDwYxg9BEInRhG659c75JoShUGkWakk/zDU7 Kw2CJ6cc4SQYrC/AZOE8n70Z2i7kixJsMIs4NkNl/4yS2JBJ6LQv31PWeM0RZmcNYxPVv3NNt PcUA2qnZOmord8kty5kj6raqXiDejoLvRNme9jfDPPWG3y4DGoStMDZHmCg+S83AllNesaB+Y UfdT5LPBeL/bx1mMBqBhPQv/mw4EwD1K/cg/C59Z6duaffJbO209wwKEKpbtk29CbpOUypGXR LFT6pL4NOGEOwP0TWf0f1hTu0YDb1s51O6eTrA3QpsYxTX5IGDR9k5oM32vQ2Ax9erMtlEgY+ MvUGpXdMs0DE8uYuffT5Y0o2WWUGlVMZF5krOWeKmcicnPw9FDnncJ19nhKODzLutpUP++Wua hqccjL9iTU8STt2koKxhb0RdKpn3evKVCVNieGalc9jb5/GZymo7jMOcMiF+CMJr2wTXcwmp4 8GGgXGdfcu8HSwSfubs0bITK8RWl5I2KKvy4zkDBnw7LT+A9Ol8dMG7z1CdGRgGly8lTQbraH zMEjoOKveMrC7Zck4O3pxpfV2BXLQdSsBCU5x2xaZEOazlucEjNztn1qHcgNoZSb36rTEz78G B5B3+SUYtxvr9J2FVeMjN12bdm4dNTnjAUhQM+kJWFK/v4MiNkL7R1MgQHCJ6x9wlyomueaWL PWaGuvaO4BSIMvghQvNcEW8nfpJwB7zPVdx7uIrZdRv0ONYqnkUCb3I8QuCHG21hugtoN2Pjq Ve7cy9q19b5j+A2/Vm8dVPW2Zd9BimoPGDnjvqsfYGcXOSW4eU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 10 Nov 2017 12:56:33 +0100 * Add jump targets so that a call of the function "perror" and "exit" is stored only once in an if branch of this function. * Replace two calls by goto statements. Signed-off-by: Markus Elfring --- scripts/asn1_compiler.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c index 0eea270fcaef..06dc5397d8c8 100644 --- a/scripts/asn1_compiler.c +++ b/scripts/asn1_compiler.c @@ -762,18 +762,19 @@ static void build_type_list(void) if (nr == 0) { fprintf(stderr, "%s: No defined types\n", filename); - exit(1); + goto exit; } nr_types = nr; types = type_list = calloc(nr + 1, sizeof(type_list[0])); - if (!type_list) { - perror(NULL); - exit(1); - } + if (!type_list) + goto report_failure; + type_index = calloc(nr, sizeof(type_index[0])); if (!type_index) { +report_failure: perror(NULL); +exit: exit(1); } -- 2.15.0