From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753904AbdBHIQP (ORCPT ); Wed, 8 Feb 2017 03:16:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38074 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbdBHIQO (ORCPT ); Wed, 8 Feb 2017 03:16:14 -0500 Subject: Re: [PATCH] kvm: vmx: Use the hardware provided GPA instead of page walk To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1485542088-18610-1-git-send-email-pbonzini@redhat.com> <20170207205248.GE31091@potion> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org From: Paolo Bonzini Message-ID: <3a4399fa-ad9b-c728-2c64-72213685ca28@redhat.com> Date: Wed, 8 Feb 2017 09:16:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170207205248.GE31091@potion> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 08 Feb 2017 08:16:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2017 21:52, Radim Krčmář wrote: > 2017-01-27 19:34+0100, Paolo Bonzini: >> As in the SVM patch, the guest physical address is passed by >> VMX to x86_emulate_instruction already, so mark the GPA as available >> in vcpu->arch. >> >> Signed-off-by: Paolo Bonzini >> --- > > In line with the SVM patch, > > Reviewed-by: Radim Krčmář > > Still, I don't see why we need a variable that is touched on every VM > exit. Is this a mere shortcut to propagating the gpa_available bit with > the gpa argument to kvm_mmu_page_fault() and x86_emulate_instruction()? Yes, pretty much. Paolo