From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933180AbcGLDXa (ORCPT ); Mon, 11 Jul 2016 23:23:30 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58349 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161AbcGLDX3 (ORCPT ); Mon, 11 Jul 2016 23:23:29 -0400 X-IBM-Helo: d28dlp01.in.ibm.com X-IBM-MailFrom: maddy@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs To: Jiri Olsa , Arnaldo Carvalho de Melo References: <1466660967-2016-1-git-send-email-maddy@linux.vnet.ibm.com> <20160628085434.GA28550@krava> Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Yury Norov , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Wang Nan , Michael Ellerman From: Madhavan Srinivasan Date: Tue, 12 Jul 2016 08:53:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160628085434.GA28550@krava> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16071203-0012-0000-0000-000002B9E593 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16071203-0013-0000-0000-00000DAB0251 Message-Id: <3a43ebc8-687b-0c12-dbfe-25e60392eea7@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-07-12_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607120031 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, Any updates for this fix. Kindly let me know. Maddy On Tuesday 28 June 2016 02:24 PM, Jiri Olsa wrote: > On Thu, Jun 23, 2016 at 11:19:27AM +0530, Madhavan Srinivasan wrote: > > SNIP > >> Changelog v1: >> 1)updated commit message and patch subject >> 2)Add the fix to print_sample_iregs() in builtin-script.c >> >> tools/include/linux/bitmap.h | 2 ++ >> tools/lib/bitmap.c | 18 ++++++++++++++++++ >> tools/perf/builtin-script.c | 4 +++- >> tools/perf/util/session.c | 4 +++- >> 4 files changed, 26 insertions(+), 2 deletions(-) >> >> diff --git a/tools/include/linux/bitmap.h b/tools/include/linux/bitmap.h >> index 28f5493da491..5e98525387dc 100644 >> --- a/tools/include/linux/bitmap.h >> +++ b/tools/include/linux/bitmap.h >> @@ -2,6 +2,7 @@ >> #define _PERF_BITOPS_H >> >> #include >> +#include > this could go in the bitmap.c file, but anyway: > > Acked-by: Jiri Olsa > > thanks, > jirka > >> #include >> >> #define DECLARE_BITMAP(name,bits) \ >> @@ -10,6 +11,7 @@ >> int __bitmap_weight(const unsigned long *bitmap, int bits); >> void __bitmap_or(unsigned long *dst, const unsigned long *bitmap1, >> const unsigned long *bitmap2, int bits); >> +void bitmap_from_u64(unsigned long *dst, u64 mask); >> >> #define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG - 1))) >> > SNIP >