From: Markus Elfring <Markus.Elfring@web.de>
To: Gilad Ben-Yossef <gilad@benyossef.com>, linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 1/3] crypto: ccree: fix resource leak on error path
Date: Sun, 21 Jun 2020 11:28:00 +0200 [thread overview]
Message-ID: <3a4ddd15-e8a9-33fb-007a-d50137c378a6@web.de> (raw)
> Fix a small resource leak on the error path of cipher processing.
Would you like to add the tag “Fixes” to the commit message?
…
> +++ b/drivers/crypto/ccree/cc_cipher.c
…
> @@ -190,21 +198,19 @@ static int cc_cipher_init(struct crypto_tfm *tfm)
…
> - return rc;
> +out_key:
> + kfree(ctx_p->user.key);
> +out_shash:
> + crypto_free_shash(ctx_p->shash_tfm);
…
How do you think about to replace the prefix “out” by “free” in these labels?
Regards,
Markus
next reply other threads:[~2020-06-21 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 9:28 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-21 9:07 [PATCH 0/3] fixes and update to essiv support Gilad Ben-Yossef
2020-06-21 9:07 ` [PATCH 1/3] crypto: ccree: fix resource leak on error path Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a4ddd15-e8a9-33fb-007a-d50137c378a6@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®