From: "Arnd Bergmann" <arnd@kernel.org>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rich Felker" <dalias@libc.org>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>
Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v3 0/5] sh: mach-rsk: rsk7203: switch to using static device property, drop legacy gpio API
Date: Wed, 30 Sep 2026 09:23:21 +0200 [thread overview]
Message-ID: <3a51385d-9649-4bd7-87b3-0caf9e462b2e@app.fastmail.com> (raw)
In-Reply-To: <20260929-rsk7203-properties-v3-0-02f84aeb8e47@gmail.com>
On Wed, Sep 30, 2026, at 06:57, Dmitry Torokhov wrote:
> This series of patches converts rsk7203 to use static device properties
> for its devices, including gpio-keys and gpio-leds, and removing
> dependency on legacy gpio API (in favor of gpiod API).
The patches look good to me. I have build-tested this with the snippet
below and my series from
https://lore.kernel.org/all/20260907090956.2825703-2-arnd@kernel.org/
to check that no use of the legacy interfaces remain.
You can probably fold my one-liner into your last patch.
There is a trivial conflict between your series and my patch 2/2
"gpiolib: remove linux/gpio.h", but if yours gets merged, I can
resend mine without that line.
> To configure pin functions the board is switched to use gpio-hogs, as
> doing full conversion to pinmux is too challenging without access to
> hardware.
I would guess even with access to hardware testing is going to be
challenging, I noticed that the defconfig kernel does not fit on the
4MB flash any more (even without rootfs), and the USB support was
never added for rsk7203, only for 7264/7269.
Arnd
--- a/arch/sh/boards/mach-rsk/Kconfig
+++ b/arch/sh/boards/mach-rsk/Kconfig
@@ -12,7 +12,6 @@ config SH_RSK7201
config SH_RSK7203
bool "RSK7203"
select GPIOLIB
- select GPIOLIB_LEGACY
depends on CPU_SUBTYPE_SH7203
config SH_RSK7264
next prev parent reply other threads:[~2026-09-30 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 4:57 Dmitry Torokhov
2026-09-30 4:58 ` [PATCH v3 1/5] pinctrl: renesas: gpio: isolate function gpiochip from parent fwnode Dmitry Torokhov
2026-09-30 7:05 ` Geert Uytterhoeven
2026-09-30 4:58 ` [PATCH v3 2/5] sh: pfc: attach software node to the GPIO chip Dmitry Torokhov
2026-09-30 4:58 ` [PATCH v3 3/5] sh: mach-rsk: rsk7203: use static device properties for LEDs and GPIO buttons Dmitry Torokhov
2026-09-30 4:58 ` [PATCH v3 4/5] pinctrl: renesas: gpio: support software nodes for function GPIOs Dmitry Torokhov
2026-09-30 7:06 ` Geert Uytterhoeven
2026-09-30 4:58 ` [PATCH v3 5/5] sh: mach-rsk: rsk7203: convert pin configuration to using software nodes Dmitry Torokhov
2026-09-30 7:23 ` Arnd Bergmann [this message]
2026-09-30 8:37 ` [PATCH v3 0/5] sh: mach-rsk: rsk7203: switch to using static device property, drop legacy gpio API Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a51385d-9649-4bd7-87b3-0caf9e462b2e@app.fastmail.com \
--to=arnd@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dalias@libc.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®