From: James Smart <james.smart@broadcom.com>
To: YueHaibing <yuehaibing@huawei.com>,
dick.kennedy@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Remove unnecessary null check before kfree
Date: Mon, 15 Jul 2019 07:51:30 -0700 [thread overview]
Message-ID: <3a56b01a-27e4-6ebc-0e99-8a06a2f2f75f@broadcom.com> (raw)
In-Reply-To: <20190711141037.57880-1-yuehaibing@huawei.com>
On 7/11/2019 7:10 AM, YueHaibing wrote:
> A null check before a kfree is redundant, so remove it.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/scsi/lpfc/lpfc_bsg.c | 4 +---
>
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
next prev parent reply other threads:[~2019-07-15 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:10 YueHaibing
2019-07-15 14:51 ` James Smart [this message]
2019-07-17 2:46 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a56b01a-27e4-6ebc-0e99-8a06a2f2f75f@broadcom.com \
--to=james.smart@broadcom.com \
--cc=dick.kennedy@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®