From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>, Luka Gejak <luka.gejak@linux.dev>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Straube <straube.linux@gmail.com>,
Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH rtw-next v7 4/6] wifi: rtw88: 8723b: add the RTL8723B chip driver
Date: Tue, 6 Oct 2026 14:18:55 +0300 [thread overview]
Message-ID: <3a57c874-ab57-4ca2-98a9-d5cf4fdf285b@gmail.com> (raw)
In-Reply-To: <359ea3a6857d4aba9c83876a10f7f9e8@realtek.com>
On 06/10/2026 03:39, Ping-Ke Shih wrote:
> Luka Gejak <luka.gejak@linux.dev> wrote:
>> On Mon Oct 5, 2026 at 8:08 AM CEST, Ping-Ke Shih wrote:
>>> Luka Gejak <luka.gejak@linux.dev> wrote:
>> [...]
>>>> +/*
>>>> + * Shares the receive PHY status layout, the SDIO aggregation burst fields
>>>> + * and a few baseband registers with the RTL8703B; reuse that header.
>>>> + */
>>>> +#include "rtw8703b.h"
>>>
>>> Which layout you are using?
>>> Should you move the layout to rtw8723x.h ?
>>>
>>
>> The layout I reuse is the RTL8703B receive PHY status structure, struct
>> phy_status_8703b, together with the SDIO aggregation burst fields and four
>> baseband registers.
>
> Let's use another patch to move the struct out of rtw8703b.h, and rename
> to phy_status_8723x for example.
>
The same struct could be used by other chips in the future, like
RTL8192EE/RTL8192EU and RTL8188FU/RTL8189FS.
next prev parent reply other threads:[~2026-10-06 11:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 7:38 [PATCH rtw-next v7 0/6] wifi: rtw88: add RTL8723B/RTL8723BS support Luka Gejak
2026-10-02 7:38 ` [PATCH rtw-next v7 1/6] wifi: rtw88: move the 88xxa CCK power detect setter to phy.c Luka Gejak
2026-10-05 3:52 ` Ping-Ke Shih
2026-10-02 7:38 ` [PATCH rtw-next v7 2/6] wifi: rtw88: 8723b: add the RTL8723B register definitions Luka Gejak
2026-10-05 3:54 ` Ping-Ke Shih
2026-10-02 7:38 ` [PATCH rtw-next v7 3/6] wifi: rtw88: 8723b: add the RTL8723B BB, RF and AGC tables Luka Gejak
2026-10-05 3:58 ` Ping-Ke Shih
2026-10-02 7:38 ` [PATCH rtw-next v7 4/6] wifi: rtw88: 8723b: add the RTL8723B chip driver Luka Gejak
2026-10-05 6:08 ` Ping-Ke Shih
2026-10-05 13:30 ` Luka Gejak
2026-10-06 0:39 ` Ping-Ke Shih
2026-10-06 4:30 ` Luka Gejak
2026-10-06 5:29 ` Ping-Ke Shih
2026-10-06 7:07 ` Luka Gejak
2026-10-06 9:05 ` Luka Gejak
2026-10-06 10:41 ` Luka Gejak
2026-10-06 12:38 ` Ping-Ke Shih
2026-10-06 11:18 ` Bitterblue Smith [this message]
2026-10-06 12:19 ` Luka Gejak
2026-10-02 7:38 ` [PATCH rtw-next v7 5/6] wifi: rtw88: 8723bs: add the RTL8723BS SDIO bind Luka Gejak
2026-10-05 6:09 ` Ping-Ke Shih
2026-10-02 7:38 ` [PATCH rtw-next v7 6/6] wifi: rtw88: 8723bs: enable building the RTL8723BS driver Luka Gejak
2026-10-05 6:10 ` Ping-Ke Shih
2026-10-03 21:26 ` [PATCH rtw-next v7 0/6] wifi: rtw88: add RTL8723B/RTL8723BS support Bitterblue Smith
2026-10-03 21:46 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a57c874-ab57-4ca2-98a9-d5cf4fdf285b@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=pbrobinson@gmail.com \
--cc=pkshih@realtek.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®