From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6A353C433FE
	for <linux-kernel@archiver.kernel.org>; Mon, 17 Oct 2022 09:01:48 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230480AbiJQJBq (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 17 Oct 2022 05:01:46 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35156 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230457AbiJQJBk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Oct 2022 05:01:40 -0400
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C5C13608A
        for <linux-kernel@vger.kernel.org>; Mon, 17 Oct 2022 02:01:16 -0700 (PDT)
Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.54])
        by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MrW7X3kbyz1P78l;
        Mon, 17 Oct 2022 16:56:24 +0800 (CST)
Received: from dggpemm500007.china.huawei.com (7.185.36.183) by
 dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Mon, 17 Oct 2022 17:01:05 +0800
Received: from [10.174.178.174] (10.174.178.174) by
 dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.31; Mon, 17 Oct 2022 17:01:05 +0800
Subject: Re: [PATCH] kobject: fix possible memory leak in
 kset_create_and_add()
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <linux-kernel@vger.kernel.org>, <rafael@kernel.org>
References: <20221017023327.1793893-1-yangyingliang@huawei.com>
 <Y0zfPKAgQSrYZg5o@kroah.com>
 <9c2e91e1-dd07-8a4b-999c-9a2d26ee5f07@huawei.com>
 <Y00XKw+Vs5Bo8jkZ@kroah.com>
From:   Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <3a661911-fb26-3d36-a78b-0778c0fceec2@huawei.com>
Date:   Mon, 17 Oct 2022 17:01:04 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <Y00XKw+Vs5Bo8jkZ@kroah.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [10.174.178.174]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
 dggpemm500007.china.huawei.com (7.185.36.183)
X-CFilter-Loop: Reflected
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022/10/17 16:49, Greg KH wrote:
> On Mon, Oct 17, 2022 at 04:13:03PM +0800, Yang Yingliang wrote:
>> Hi,
>>
>> On 2022/10/17 12:51, Greg KH wrote:
>>> On Mon, Oct 17, 2022 at 10:33:27AM +0800, Yang Yingliang wrote:
>>>> If kset_register() fails in kset_create_and_add(), the name allocated
>>>> in kset_create() will be leaked.
>>> How is kset_create_and_add() failing?  Is this in a real kernel, or
>>> created with a fake fault injection?
>> Inject fault while probing module qemu_fw_cfg, kset_create_and_add() may
>> fail.
> Ah good, it's never being hit in a real situation.  The next time you
> submit patches that are found like this, please include this type of
> information.
OK. Do I need to send a v2 with commit message update.

Thanks,
Yang
>
> thanks,
>
> greg k-h
> .