From: whitequark <whitequark@whitequark.org>
To: Mario.Limonciello@dell.com
Cc: heikki.krogerus@linux.intel.com, mika.westerberg@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: USB type-C altmode support for UCSI
Date: Fri, 07 Sep 2018 11:04:27 +0000 [thread overview]
Message-ID: <3a666f66d6e342e2971b800caae7c889@whitequark.org> (raw)
In-Reply-To: <a2f79cc4d9a0aab4a832de31b7ddc52d@whitequark.org>
On 2018-09-05 14:13, whitequark wrote:
> On 2018-09-05 13:50, Mario.Limonciello@dell.com wrote:
>> Some Dell XPS systems do not support that TBT2<->TBT3 adapter. I think
>> I
>> tried this on XPS 15 9550 and XPS 13 9365 and in both cases it is
>> rejected. I think it has something to do with the PD controller
>> firmware. Same goes if you Plug TB16 dock and to that dock then
>> connect
>> the adapter + device.
>
> This is my understanding as well, however I'd like to fix this issue.
> From looking at the BIOS image I can see that the 9360 uses a TPS65982
> USB PD controller. The adapter uses a TPS65983A (confusingly remarked
> by Apple as CD3215B). I've seen reports on the web that there is some
> inherent incompatibility between TPS65982 and TPS65983, however TI is
> for some reason extremely secretive about TPS65983 and I wasn't able
> to get anything definitive about it.
>
> Anyway, I've reverse engineered a nontrivial part of the TI TPS6598x
> firmware and register layout, however my understanding of Thunderbolt
> and USB PD is not sufficient to proceed.
>
> Mario, do you think you could get in touch with the people at Dell who
> work with USB PD and ask if:
>
> (a) the adapter advertising an altmode with SVID:0x8087
> VDO:0x00010001
> is the problem here, and
> (b) whether configuring the register 0x52 Intel VID Configuration in
> the adapter's USB PD controller to set TBTModeDataTXSOP=0x0000
> would help.
I have been able to verify two things by reflashing the adapter with
upstream
(non-Apple) firmware and experimenting with the configuration:
(a) the altmode with SVID:0x8087 VDO:0x00010001 (16th bit set) means
that
this is an altmode advertised by a legacy Thunderbolt (3 to 2)
adapter.
So the adapter is fine here.
(b) the Dell USB PD controller doesn't try to negotiate the altmode even
with
advertised VDO:0x00000001. Something else is missing in the
configuration.
--
whitequark
next prev parent reply other threads:[~2018-09-07 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1e8398f2c1790890f40b69f12e2934e3@whitequark.org>
[not found] ` <20180903140623.GD15112@kuha.fi.intel.com>
[not found] ` <28522bb57c5d8f49416b9174b19b1625@whitequark.org>
2018-09-05 13:24 ` Heikki Krogerus
2018-09-05 13:34 ` Mika Westerberg
2018-09-05 13:50 ` Mario.Limonciello
2018-09-05 14:13 ` whitequark
2018-09-07 11:04 ` whitequark [this message]
2018-09-10 21:25 ` Mario.Limonciello
2018-09-11 9:32 ` Mika Westerberg
2018-09-11 13:02 ` Mario.Limonciello
2018-10-06 6:01 ` A different PD controller firmware problem? Theodore Y. Ts'o
2018-11-08 18:00 ` Mario.Limonciello
2018-11-08 21:15 ` Theodore Y. Ts'o
2018-11-10 20:13 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a666f66d6e342e2971b800caae7c889@whitequark.org \
--to=whitequark@whitequark.org \
--cc=Mario.Limonciello@dell.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome