From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37482C43144 for ; Mon, 25 Jun 2018 23:18:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E102A262A3 for ; Mon, 25 Jun 2018 23:18:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="OynV09xl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E102A262A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lechnology.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755775AbeFYXR7 (ORCPT ); Mon, 25 Jun 2018 19:17:59 -0400 Received: from vern.gendns.com ([206.190.152.46]:35505 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753199AbeFYXR5 (ORCPT ); Mon, 25 Jun 2018 19:17:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NbUQGj/v4gF3aVFxeH0EYRWM6njap0uIxL44ZHopPi8=; b=OynV09xl8I3+EbANNkhHztY5W0 6EpGARhnKmMx9iylvu6UpG/D3qIPtqGxA2nUPmFg/7pioxDDijdgyXwbeeTsCN9mUf3u24agKvQRV BNGSBT+RqYlgPnLbmrd8kmKlqFSfa49/qcpFggmQbysPqZzJICrrXtrWU2yWvXpNCykvi1/g9BGGv zAo9auptVuArw3qmrlxmxCGGI8VPQdm8GDUyBCOgMUu+pfco+Tl4W7F76ie9yw7bjAGebql1Obdyl NRVdUJHHgCmw8rtaH+bv0Ncgj5rxnj8fYaicURnNWx/9j2VCpJL+9cQStX956zKdY8p9K2GTF6sri 3y8EpwWQ==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:60718 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1fXak8-002Ntr-T1; Mon, 25 Jun 2018 19:17:57 -0400 Subject: Re: [PATCH] clk: davinci: cfgchip: testing the wrong variable To: Dan Carpenter Cc: Sekhar Nori , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20180602075256.hrvidsfsmr33mv2f@kili.mountain> From: David Lechner Message-ID: <3a6d0388-7915-8ea3-6ad6-38dc7ee06377@lechnology.com> Date: Mon, 25 Jun 2018 18:17:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180602075256.hrvidsfsmr33mv2f@kili.mountain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2018 02:52 AM, Dan Carpenter wrote: > There is a copy and paste bug here. We should be testing "usb1" instead > of "usb0". > > Fixes: 58e1e2d2cd89 ("clk: davinci: cfgchip: Add TI DA8XX USB PHY clocks") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c > index c971111d2601..20a120aa147e 100644 > --- a/drivers/clk/davinci/da8xx-cfgchip.c > +++ b/drivers/clk/davinci/da8xx-cfgchip.c > @@ -672,7 +672,7 @@ static int of_da8xx_usb_phy_clk_init(struct device *dev, struct regmap *regmap) > > usb1 = da8xx_cfgchip_register_usb1_clk48(dev, regmap); > if (IS_ERR(usb1)) { > - if (PTR_ERR(usb0) == -EPROBE_DEFER) > + if (PTR_ERR(usb1) == -EPROBE_DEFER) > return -EPROBE_DEFER; > > dev_warn(dev, "Failed to register usb1_clk48 (%ld)\n", > Applied to https://github.com/dlech/linux/tree/clk-davinci-fixes Thanks.