From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD23D46AF11 for ; Fri, 15 May 2026 10:53:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778842436; cv=none; b=PUtHfVDqpwRD12xgQHisv2A7SYI8zPFg+HHFN4dsCCUEi59S/Ps3ARccNiMVx5X862BGtz3Yca3tVd8LH0/FrA1xdcGJwiFPjfo0xeZgQbi3oOSpNTT3L70yygCNX0b/R8TQtLO5mmy1w6W8kSrOAwh2g48Rpf/oc9kGylLYZf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778842436; c=relaxed/simple; bh=P7+2xwoQIbHA946IMLaU3RvFr4k+V5jtaFqys75Nr9E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o+Kmn9RWbW0+ZYws9QEVdmJhARYvMJEXH6Q3DKXvw1LKdQSClLgZsMYz2r2lW7aT5XuhqIk1TUf01owi5y8398TzlgF5GzROnfTylQVEteBKI/7xdAhb7m4Kq3mKOmnTF08v2psgO5H64eMm4fDcpuphgdndRPbcw2dJNGkh+k4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OcNUlfFs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dmHU3NrW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OcNUlfFs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dmHU3NrW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64FAoFQb2676199 for ; Fri, 15 May 2026 10:53:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qV9wsZl8WKrBHBkTAdbssnMUVospcGITV573zzUgjjc=; b=OcNUlfFsgC+0coGK IKaI+HdvKzg197ZJNGAMN5TLxwl83HjLJEq6XyutSYPHTtuy0oeXZKQpBpPfVWVe h0RIuyWKWfwU/4OoZ0wpOCjjpIGcRAgYfjhFuMPjUMq7RQZYOLzmKEbC0pVdVpx+ IAf5fIkC3Czr7CEdc0FdYn+zFlmR0JmcdsO/x3LJYuq4C2oWeSBfFfXUx6zKa3PP 8O2HbZp5vxPQtaO63dSx3ZLgg+E3M9+Y80f9adMWrLTjrSD0X5rllBJD/FlzW3BH Iwf9TbjVDUXSJkH8xGb2WYfyPFraxH1VmWjbmDyasT2t93sPFnTsnyIl0i8x0ebx smOmFw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1vtxdv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 10:53:54 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c70ea91bfe1so5588760a12.1 for ; Fri, 15 May 2026 03:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778842434; x=1779447234; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qV9wsZl8WKrBHBkTAdbssnMUVospcGITV573zzUgjjc=; b=dmHU3NrW/VLoSrixteiqmPuC4myDYxEm3shl1WilxyWbKCvyz6tuSaeJG5Z2mIz83C NGNAP7keHf3jyCcMm3l5TOzX6NtIgT62unKUqCcH5nUOhyNwGHmE06Ym3qnTIFwsKjaz xzLJGiedYLruV/MbRMZJE/6gkVtPJPWccg/MeEbaZGz0fiKTNeduSG7l7SeLdRIBX0rt baez1yn5Q0G3xV6j7mBHOX4F2bc2c8dwThFxNteHpR3o5ACXHOIX/azqoj4VZvB+Hjb/ bI9qGS+kigHWK925JLEsY/zpWrSbw+EG4UOl2OH+IurxNu9lOrEcgk8AoE+6Sup66VZD eU6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778842434; x=1779447234; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qV9wsZl8WKrBHBkTAdbssnMUVospcGITV573zzUgjjc=; b=A2qzXvMMEPE6oCh3jvfq7VS7Dy7xS8MClpVr/UDE3Fg4jX4FAopdCtn17K0QQ3U7pC pMf0eVODLpBR1l7CAF5NZmmG+CpRDcApO8KpACGNCcF530GeTCtO5wPU/DTEe9IF1Tgc XSSyppXkGTPVDnkMqasLW6BQ8gOctbC3Y2QukeLupL7+9OlxiLqZEX/YnJ5P3chsy2co ohGX0CyWSNnWkS9dNkly3d/VUsYdm8xNBpukyilxkrgOYOq5Ca1dpoxLPLbwmbd3iB9j 15jejy2rASRcUHtipyEeT+HVKrlpI72vMJreC6oMiGG5oL87oebgGLroua0iWoFL0PNS OJBg== X-Forwarded-Encrypted: i=1; AFNElJ/DP42z+jG5ggMB4chArFjE1GuT0h0kxdcXgPt7bakZukgblqyorMS25hD3RszA7o5QE0NdpXQ9SidBC24=@vger.kernel.org X-Gm-Message-State: AOJu0YylgSrCPiOyHtqWVCH2rmW4JDDQc8FSjYcZmoQ26PQ6UAiyTirk gcFggEkEvnAiPRF3vROPNmAGgSMYXfkZNoV1bamaO/AlXpdpIhA72oRgUnvMt0UJBBL38WbZXiA CRJZ6fqgl7unQxpm0wDh+T4gFeh0EUIq38o9Tosz76H5XPFgiBI5NWB2QRuYAYLNGQWY= X-Gm-Gg: Acq92OFcPL9QDbsZRWuBBJ/JK675oNTuTmpYwSz8sH7k2h8CvU9PDY9Us3oztcB2SxG /6kvY5b4SbtNYp6mE11GGWynBF0sHNeji3RmIhQKo0bTsUjOQh+5LDbXJ7b+PTlB0DS6LFLblQ7 eaHrSBduHywuHvaefkI2ldR74pLysU5uu1oIXDRWOZFdbC4Hd/cfJuKJY6YOgbw8jNmwpo4/4LL SLxkAq3Wkuks48kkG8EpByzDQhb+CNX2MVLJbUPwpSq8ktV4LgVpPckyr1uyYcogbSPT1DDZMhl IRevbl4soPywgOxH/Uwgybyy72cyT3taUFlLVkc4ymdi540jl4M15CCSRue4JZKAfk1pUaAaEJC hQd2xSOtxY/N0XGwxAcLO28iFsctmJ4RvyNRWNazsmHCQVVe1BRBwpDmIAo31ZvSQkJw= X-Received: by 2002:a05:6a00:e11:b0:82c:f035:6748 with SMTP id d2e1a72fcca58-83f33d8092cmr3886834b3a.42.1778842434239; Fri, 15 May 2026 03:53:54 -0700 (PDT) X-Received: by 2002:a05:6a00:e11:b0:82c:f035:6748 with SMTP id d2e1a72fcca58-83f33d8092cmr3886800b3a.42.1778842433785; Fri, 15 May 2026 03:53:53 -0700 (PDT) Received: from [10.152.203.161] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f24cd0422sm6601508b3a.18.2026.05.15.03.53.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 03:53:53 -0700 (PDT) Message-ID: <3a6f613b-07ff-4efb-8bf5-71e397b15876@oss.qualcomm.com> Date: Fri, 15 May 2026 16:23:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: ipq5210: add watchdog node To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-ipq5210_wdt-v1-1-870c4b7f77b6@oss.qualcomm.com> <1b741127-18ef-41f8-b645-707083d7a921@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: <1b741127-18ef-41f8-b645-707083d7a921@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PKE/P/qC c=1 sm=1 tr=0 ts=6a06fb42 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=cp6o2u_hlgqnvGeBYv8A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDExMCBTYWx0ZWRfX/jBv71skxRXs +osxVcP5BBdyzpN4cMhLomfh4+kex+lO1ZtFS+qH3gbuksrXARLM91H7mkKqsNGz1rdmtxDXEB0 fVvyLk5L/n1X+hel/+igfNskvDlxlug6IBLJu8duLSK9uCQdWRdLSCqJLWJJci0jiJYOE1fzc11 l67GHstaXry9tRnaEltmj8yJPKZI6Vl4tCUPv8QhWrzvyiZL80pFo/Q0W5Ni//R5MFftbdzvLCk 16BhF+QDUpSTHt9b2rFn+1eZJotuw1IGtaY7Xi0/bmMHSd1SNBymGomMsbBbdF770Yw86wejh/G DpU7l4EmxLPrgnfpeRZQk3ZZ4mB0IgUSV618Db2hWx155tY5/VtoJaV7YSkigo8YDOhbn/uoz+Z wnNXnwlLJfpbYu+P9tQZUsIza4+66lm7aABEpDi2zcH+TF10HC0A+653zwkmeXsq+/bO3bGzhQN V0JjQSIuRt61HLXv1PQ== X-Proofpoint-ORIG-GUID: pw58_jOxPnqhNnJEsq_jo8IdBBUDbSXR X-Proofpoint-GUID: pw58_jOxPnqhNnJEsq_jo8IdBBUDbSXR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150110 On 5/15/2026 4:20 PM, Konrad Dybcio wrote: > On 5/11/26 12:56 PM, Kathiravan Thirumoorthy wrote: >> Add the watchdog device node for IPQ5210 SoC. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- >> arch/arm64/boot/dts/qcom/ipq5210.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi >> index 3761eb03ab24..2cdc10529c48 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi >> @@ -236,6 +236,13 @@ v2m2: v2m@2000 { >> }; >> }; >> >> + watchdog@b017000 { >> + compatible = "qcom,apss-wdt-ipq5210", "qcom,kpss-wdt"; >> + reg = <0x0 0x0b017000 0x0 0x1000>; >> + interrupts = ; > Are you sure about the interrupt no? Yes. If you are referring to HW doc, it is incorrect. We are working with the HW folks to update it. > > Konrad