From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A330737D130 for ; Fri, 13 Mar 2026 11:52:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773402722; cv=none; b=d4HrfJwOH3HB5iClRcEhlryEZdEKK4ZvxDTttXlnJazo0knrphJd6vdJhdpnjvuGu+WAeuYikqCC5M3IDD7bIouaBDZPPkQt50tPJF1ILORb5IagXNs51fu3i2zpPE4RnmfNvVr7tlzMUOHFVd4AbRmPOr1s6R16UpUuneRWghA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773402722; c=relaxed/simple; bh=sxOI1OM0tiE7WtkyILuUlo5L6N3v2T029ANh2c2iziY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iDOWdv/Yy9igZWWY/9KIzg3NevG9/Xxq+OklhwYlVNCPIkh8RS9xKinK+HvbMgBpCTIi2DQsmfSvLFjK+Zgq3UfBEQ9gAQWGpRH7fyWq+M/psN1vl/gQVQi/+6d5BvfFFVwh+JPjomgjg8PKVJz8YWHvWz1Hhj+o6lfjQQkURK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iWlE0sQj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AsS7tSvx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iWlE0sQj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AsS7tSvx" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D9TiBY1498953 for ; Fri, 13 Mar 2026 11:51:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b4iHfh++NbbmWm/CPLemamwH/eRHGn5P/brlTPJIGlY=; b=iWlE0sQjPlpi7tFp wCmsmcnWREXWzmqlRNuwLleMKmkfL6nohvFk/ucro2udIL0WmJlZdjBMaR70o5XR 0LcsmnWCvahhjwF1ktYqkeCsiI5VR0kaTqTdSyeZ2bRhjCna5oPpKXHOeDLUQ8Yj H2Yus1i99E6gkF8szoo0tEIRGxmbHMlf6OL8Pj/3/nPt5ROAenJcTTCMRxmB4JHY XxMIPaJsHnG623nh2Us7MKbysfwYRNcC01Rp4vbD1IDp8Bxt+mBUPpb+5fbKt+Ef abH033xr9YdeY53xeybT8cwtxg2EmtD5l0awDXMbT944C7mjHsmwmE0fQKCsSB27 Z+AL4Q== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvg0hgdqw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 11:51:59 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89a09f050feso14625446d6.1 for ; Fri, 13 Mar 2026 04:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773402719; x=1774007519; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b4iHfh++NbbmWm/CPLemamwH/eRHGn5P/brlTPJIGlY=; b=AsS7tSvxF2AkDMGW1US5b+HT2nv7vsbqBrl6UIFG198/e01ST2geUrmolURUlLrM27 q/y1uGpRi+DH0WMY7nF18tlp3YeuvYWXfUOSQNvRnL0OjaWHourftdbAkzpLkUHdx5xk dsl4l62eQklDWOdTd19ukJheNKgDvuPz+H/yp3I+LE3b/hWmTJGPXijpDYJ1ifSbeWef 5J3qSExzvp4AzProS0WXYtP238WKhR0aEmAgnd8HksYz19OEm/jK6q/eXxKk7YrToglU 21B8LasvHTXPFXhX7uIdDmT0UimPWyxxH4tUOYalvdfdvASVv/QWtAK8ueL97OsnOTdZ WjDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773402719; x=1774007519; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b4iHfh++NbbmWm/CPLemamwH/eRHGn5P/brlTPJIGlY=; b=RJgcC2FgD3cZq1OUMDdwqTXtP+/D0WlNoVog15Bf/FzK+oSsEB/yGfh9MsyRGwj1W8 MOfVns0UekaHlkhzh80k78HCskm10A1sxurJbUpGqRLtmAVlJRRdfdQ/5zJ/SZPZC0em LohfASY4hf3o0GXHPPp2bZ3dXemXuWyDSEeckUCIIBhbADLQ456PGHc+w/kQrl1P0IKj yHwSYl657CJp+EZ3hmPfk/cR1bsxA0j+t1fr17s0EPJan06QGRmM/l+i3WVUxbjdN4/c YIbImHQp4BaiMzgwHa2cmoLCVuXd5jNrrG3T7MnaS+ELMZzTn7G0o9pK7sEiPkq0zUcM 5TCg== X-Forwarded-Encrypted: i=1; AJvYcCXxy2ZCQNj6rfUwgHiuIXwt7nVghuRdYn7A7BXNtWbl3ecquBhFIV54lpd0kma8Q/k13+betVV7EN7Vog0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtiq03CMW870AewTz012W8UyETiGOPm2rwC+LpLX5OaryZrEoq wCczrLAAPDOOcQeiWSBG7Mxxqc6Xuwm7fXIS5j5gw1zgW21+KVTbqfZA1GwZ+PSEEWkA99GbCK6 /gtTeyl6v4WiJtZqbgUgSyMqxz/dCFlbTHjrrfvcFJA2p8U6MqjJOXwkGPt0s4FHzZx8= X-Gm-Gg: ATEYQzyd1JN+FJpFjQ2ywDNlsfNCHTpmf8emeZr0smcOFFswxLNong5hN93qB0PrMyb d7TH6pAE80lAeUioxbgg9vPT9uWMkaiiN1d+nrWyf8H8nMaassfr6UOiYmD6wita6wNBXHjOc4K uBs/n3es0GQ88YKElPaJ7E1R2WDUv2nya0HRfDOdVONS04VKHX9xy09WTbdinKjxdKjs8Kn6SUN 1SgAZ4aaurXQDBoNDkvHpGrzLx04OhL6BkEzvbvbkdRvTOxDKVi8msKnX1+U3fyMbrV1m5gtHut mHdh31KYFXexik3WTGwC7ThheFTPqOM7l8FLhZTOiwc/oZM2d8OTu/xs/npLP6c6ggHsar5yvgi WsmzrRlAH6+ezifEHi65YKNsiM02jzWlojlnUdV2GcX3/KCwkqYeJO3rA4Hf1d313zIH5el9ohj qv5p0= X-Received: by 2002:a05:6214:809c:b0:89a:4c1b:4f6d with SMTP id 6a1803df08f44-89a81fb81e7mr32514146d6.6.1773402718946; Fri, 13 Mar 2026 04:51:58 -0700 (PDT) X-Received: by 2002:a05:6214:809c:b0:89a:4c1b:4f6d with SMTP id 6a1803df08f44-89a81fb81e7mr32513816d6.6.1773402718430; Fri, 13 Mar 2026 04:51:58 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cba6e57sm40730566b.8.2026.03.13.04.51.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 04:51:57 -0700 (PDT) Message-ID: <3a80a27a-0586-41ea-957d-77fa3d023675@oss.qualcomm.com> Date: Fri, 13 Mar 2026 12:51:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-11-b9c2a5471d9e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-11-b9c2a5471d9e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=T6eBjvKQ c=1 sm=1 tr=0 ts=69b3fa5f cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=KYTvFk41Yb9jba8_3vwA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: 8idM_5_tvOXI-8UKeRGL37pKklfxUq-p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA5MyBTYWx0ZWRfX7126dl96fdc5 Th4xGeC6i96qmLcBR0Bvo0MdR/6C8q2oEiwm4w5K77/7NdI62pAWY8Pt+Xmz8QUDZrPW/oRngF2 Zp/UPHD2sJXghvOxpIQ/fPrRgcM0EtfJwlJLTa5UFamhVZfJk7kxMJ1v7D6y8nE6SXSyf0ecXU9 xwMQXpnNAqdvqkrla6dUcCZXwB6vUk6jOMVmgzh7NzR7476MlO70mPJC3Hp28v7FrzxaywEyndh K4vbU5B4hBfy7SFwSArJJL/sXr5zxLhPL7Eg1ECuonYYbQGzOxUiR/AXDnXDQULrFrw70XdEPlr 9CYyvoFQpImxO5f7hCriOd4Q93qoNp18NUKPIihF97EUqi339n8/yT82D63IsjlSQgDMGUhv5Ks 7QGBypu4uikuUJ70+DOiTYbKLe1bl1jWJKknV8vXk6E40z1mr3MKqsUOffCfw56UK6iAsS3pNSY fW2xxz+yGLPGsFIl1Fw== X-Proofpoint-GUID: 8idM_5_tvOXI-8UKeRGL37pKklfxUq-p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130093 On 3/10/26 9:06 AM, Harshal Dev wrote: > Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver > de-coupled from the QCOM UFS driver, it explicitly votes for its required > clocks during probe. For scenarios where the 'clk_ignore_unused' flag is > not passed on the kernel command line, to avoid potential unclocked ICE > hardware register access during probe the ICE driver should additionally > vote on the 'iface' clock. > Also update the suspend and resume callbacks to handle un-voting and voting > on the 'iface' clock. > > Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") > Signed-off-by: Harshal Dev > --- > drivers/soc/qcom/ice.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index b203bc685cad..e05dc7b274e0 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -108,6 +108,7 @@ struct qcom_ice { > void __iomem *base; > > struct clk *core_clk; > + struct clk *iface_clk; > bool use_hwkm; > bool hwkm_init_complete; > u8 hwkm_version; > @@ -316,6 +317,13 @@ int qcom_ice_resume(struct qcom_ice *ice) > err); > return err; > } > + > + err = clk_prepare_enable(ice->iface_clk); > + if (err) { > + dev_err(dev, "failed to enable iface clock (%d)\n", > + err); dev_err(dev, "Failed to enable 'iface' clock: %d\n", err); (this line is very short, no need to wrap, also some nitty touch-ups) [...] > + engine->iface_clk = devm_clk_get_optional_enabled(dev, "iface_clk"); Check for IS_ERR, _optional won't throw an error if it's absent, but will if there's anything more serious that's wrong Konrad