From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752934AbcLGEQZ (ORCPT ); Tue, 6 Dec 2016 23:16:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcLGEQW (ORCPT ); Tue, 6 Dec 2016 23:16:22 -0500 Subject: Re: [PATCH 05/10] vhost: make interval tree static inline To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-6-git-send-email-mst@redhat.com> Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org From: Jason Wang Message-ID: <3a862cdc-cd02-98f2-fc9a-7bc0f99a0ba3@redhat.com> Date: Wed, 7 Dec 2016 12:16:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481038106-24899-6-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 07 Dec 2016 04:16:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年12月06日 23:40, Michael S. Tsirkin wrote: > vhost_umem_interval_tree is only used locally within vhost.c, mark it > static. As some functions generated go unused, this triggers warnings > unless we also mark it inline. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index c6f2d89..7331ef3 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -49,7 +49,7 @@ enum { > > INTERVAL_TREE_DEFINE(struct vhost_umem_node, > rb, __u64, __subtree_last, > - START, LAST, , vhost_umem_interval_tree); > + START, LAST, static inline, vhost_umem_interval_tree); > > #ifdef CONFIG_VHOST_CROSS_ENDIAN_LEGACY > static void vhost_disable_cross_endian(struct vhost_virtqueue *vq) Reviewed-by: Jason Wang