From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BED5C433F5 for ; Tue, 14 Sep 2021 09:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6662610CE for ; Tue, 14 Sep 2021 09:28:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230457AbhINJ3X (ORCPT ); Tue, 14 Sep 2021 05:29:23 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9039 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbhINJ26 (ORCPT ); Tue, 14 Sep 2021 05:28:58 -0400 Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H7yf15pmBzW1Hg; Tue, 14 Sep 2021 17:26:33 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Tue, 14 Sep 2021 17:27:32 +0800 Subject: Re: [PATCH v2] mm/page_isolation: fix potential missing call to unset_migratetype_isolate() To: Michal Hocko CC: Andrew Morton , David Hildenbrand , , , References: <20210913115125.33617-1-linmiaohe@huawei.com> <6cb372ff-0b68-2143-913e-04ab3e6b4160@huawei.com> <1d0e15ab-4a1f-0820-26c2-4b9949164dfa@huawei.com> From: Miaohe Lin Message-ID: <3a8857fd-d4f2-7743-d2e8-8580145d32e7@huawei.com> Date: Tue, 14 Sep 2021 17:27:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/9/14 15:06, Michal Hocko wrote: > On Tue 14-09-21 11:09:47, Miaohe Lin wrote: > [...] >> So even the Fixes tag should be removed ? > > I would keep that one there. Fixes tag is useful to frame the scope of > the fix. For example when somebody is backporting the commit mentioned > in the Fixes tag then a) a lot of follow up patches with Fixes can tell > you this won't be an easy ride and you might want to reconsider risks > vs. benefit b) it helps to collect follow up fixes more easily. > > That is a different story from cc: stable which just collects patches > and push them to all consumers of the stable branch if they apply. > > To conclude, the Fixes tag is a generaly useful tag to bind patches > together and let people evaluate how important that is while Cc stable > is an indication that a fix is serious enough to push to all stable > users. > I see. Many thanks for your detailed explanation! :)