From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09CD6EB64DC for ; Thu, 20 Jul 2023 06:41:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231322AbjGTGl3 (ORCPT ); Thu, 20 Jul 2023 02:41:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230464AbjGTGlI (ORCPT ); Thu, 20 Jul 2023 02:41:08 -0400 Received: from out199-7.us.a.mail.aliyun.com (out199-7.us.a.mail.aliyun.com [47.90.199.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D562C3A87; Wed, 19 Jul 2023 23:40:29 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0VnottGz_1689835157; Received: from 30.97.48.52(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VnottGz_1689835157) by smtp.aliyun-inc.com; Thu, 20 Jul 2023 14:39:18 +0800 Message-ID: <3a8b32da-0376-3633-b7da-0273da945af1@linux.alibaba.com> Date: Thu, 20 Jul 2023 14:39:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call To: Andrei Coardos , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Cc: zhang.lyra@gmail.com, orsonzhai@gmail.com, andy@kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean References: <20230717121004.5205-1-aboutphysycs@gmail.com> From: Baolin Wang In-Reply-To: <20230717121004.5205-1-aboutphysycs@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/17/2023 8:10 PM, Andrei Coardos wrote: > The platform_set_drvdata() call was never used, ever since the driver was > originally added. > It looks like this copy+paste left-over. Possibly the author copied from a > driver that had this line, but also had a remove hook. > > Reviewed-by: Alexandru Ardelean > Signed-off-by: Andrei Coardos LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/gpio/gpio-eic-sprd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c > index 84352a6f4973..53db88ae2a20 100644 > --- a/drivers/gpio/gpio-eic-sprd.c > +++ b/drivers/gpio/gpio-eic-sprd.c > @@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev) > return ret; > } > > - platform_set_drvdata(pdev, sprd_eic); > return 0; > } >