From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D308C433E0 for ; Tue, 21 Jul 2020 02:46:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76C0C206E9 for ; Tue, 21 Jul 2020 02:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ijxXAdSe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbgGUCqu (ORCPT ); Mon, 20 Jul 2020 22:46:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726264AbgGUCqt (ORCPT ); Mon, 20 Jul 2020 22:46:49 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82D92C061794 for ; Mon, 20 Jul 2020 19:46:49 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id q5so19648371wru.6 for ; Mon, 20 Jul 2020 19:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=GJ2loNa/b2LseAPT1F7ZEHhALzMLY3E2X638XNCfUuw=; b=ijxXAdSeHVBZU9hawq1Hem8w8thcNIt+hCxP2OEhbYPQUxo0MR4NdRJY+oy+f2vvc6 DAGH32YzUaPoXgQEBR+nR1oaIDeY6+oWDEldl4Sz9EBTWY4Fad4ZO8ywJJI7c5HWZJDK hoWLj4D0irM/RtkJSlZ98T8v8imrn2Dz3BSw5gIWQBE/ImhD5mF11lsHDRrmSs4XRayS G+4hX5e5/WKSvynWOUI71wo0SKrOX6t1erVEpMaqaPZiwzagPTpRyXE2KrQ+s9VmnNSV i0HcsXcAILOtqHxOPkIFQYMls0WRVlAd1RAibLwWsXParar/UU26Olals568gMUpR4F8 iEfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=GJ2loNa/b2LseAPT1F7ZEHhALzMLY3E2X638XNCfUuw=; b=qpLmXLjfLq37ttY4UybdL6iTFKR2xJfVtdu3QbwikjaXJ0IazPEFGBU05u18pwjnZs YXBNMaRJlLt9BQyxudkWonO7AoTqIQQHvQtYUBQAjY8RLMvvcG64kIIWKltaqkkhSylV Yt9fkXO7tpQQKIhdbw7vC6CSRaaJX887l0D5FKDan/4qQ1PEPHKXcLjcMJbfOUQX3Ntm a0Hl5Q8xUXK+C0ViNJ5Yhgv2Eto+hKe/kwaqpN1yFIONfxSkQjun9GeIwT/K4cEhT8s/ A33OmxGbEuLsn68ltr+Sx93ifsFaizcPNqjg7Wq8M+Xcr5oMnGNPUT2YQQtbLFqs/I4N Gk3g== X-Gm-Message-State: AOAM531pws/2rfvM2EwK7d6gt42QMx0wdGRX1W/6IMnBwmUfLdK6OLaV 2njHUg69GXXJdcv3++OZKQ== X-Google-Smtp-Source: ABdhPJzxM6HnO5U7IAUr//uuD9OAnbgY6BtrL4lxgY55zxyPqr9uLztqQLlL4Zw1ft47OyC7v7FE5A== X-Received: by 2002:a5d:438c:: with SMTP id i12mr8893146wrq.210.1595299608116; Mon, 20 Jul 2020 19:46:48 -0700 (PDT) Received: from [192.168.200.34] (ip5b436a54.dynamic.kabel-deutschland.de. [91.67.106.84]) by smtp.gmail.com with ESMTPSA id v12sm24225356wrs.2.2020.07.20.19.46.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 19:46:47 -0700 (PDT) Subject: =?UTF-8?Q?Re=3a_=5bPATCH_2/5=5d_drm=3a_rockchip=3a_add_missing_regi?= =?UTF-8?B?c3RlcnMgZm9yIFJLMzE4OOOAkOivt+azqOaEj++8jOmCruS7tueUsWxpbnV4LXJv?= =?UTF-8?Q?ckchip-bounces+andy=2eyan=3drock-chips=2ecom=40lists=2einfradead?= =?UTF-8?B?Lm9yZ+S7o+WPkeOAkQ==?= To: Andy Yan , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org References: <20200718200323.3559-1-knaerzche@gmail.com> <20200718200323.3559-3-knaerzche@gmail.com> <871ce1ac-2d5b-c0a2-60a6-6aba0f296c18@rock-chips.com> <12296860-d6ed-5135-7c4e-545362829051@gmail.com> From: Alex Bee Message-ID: <3a8f02db-93f3-1414-fea9-007dee55ec54@gmail.com> Date: Tue, 21 Jul 2020 04:46:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, Am 21.07.20 um 03:17 schrieb Andy Yan: > Hi Alex: > > On 7/20/20 10:46 PM, Alex Bee wrote: >> Hi Andy, >> >> Am 20.07.20 um 10:22 schrieb Andy Yan: >>> Hi Alex: >>> >>> On 7/19/20 4:03 AM, Alex Bee wrote: >>>> This patch adds dither_up, dsp_lut_en, data_blank and dsp_data_swap >>>> registers to enable their respective functionality for RK3188's VOP. >>>> >>>> Signed-off-by: Alex Bee >>>> --- >>>>   drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 4 ++++ >>>>   1 file changed, 4 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>>> b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>>> index b046910129fb..971a6bda7458 100644 >>>> --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>>> +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c >>>> @@ -512,6 +512,10 @@ static const struct vop_common rk3188_common = { >>>>       .dither_down_en = VOP_REG(RK3188_DSP_CTRL0, 0x1, 11), >>>>       .dither_down_mode = VOP_REG(RK3188_DSP_CTRL0, 0x1, 10), >>>>       .dsp_blank = VOP_REG(RK3188_DSP_CTRL1, 0x3, 24), >>>> +    .dither_up = VOP_REG(RK3188_DSP_CTRL0, 0x1, 9), >>>> +    .dsp_lut_en = VOP_REG(RK3188_SYS_CTRL, 0x1, 28), >>>> +    .data_blank = VOP_REG(RK3188_DSP_CTRL1, 0x1, 25), >>>> +    .dsp_data_swap = VOP_REG(RK3188_DSP_CTRL1, 0x1f, 26), >>> >>> >>> >>> I can't find the definition of dsp_data_swap, or I missed something? >>> >> Note that .dsp_data_swap is not defined with that name in TRM (as it >> is not in RK3288/RK3328), since potentially more the one bit would >> have to be set for this (currently only RB_SWAP (0x2) is implemented >> in the VOP driver). >> > > I mean I didn't find the definition of dsp_data_swap  in struct > vop_comm, I even search drm-misc-next tree. > Sorry, misunderstanding. You're right: I had something which isn't upstreamed/merged yet in my tree. I'll remove this reg in V2. > >> To be some kind of future proof (if BG_SWAP, RG_SWAP, DELTA_SWAP or >> DUMMY_SWAP ever get implemented) it should be aligned with what is >> defined for RK3288/RK3328 now to automatically benefit from that >> additions. And it would, since RK3288_DSP_CTRL0 BIT12, BIT13, BIT14, >> BIT15, BIT16 exactly matches with RK3188_DSP_CTRL1 BIT26, BIT27, >> BIT28, BIT29, BIT30. >> >> Current implementation sets BIT13 for RK3288 and with this patch >> BIT27 for RK3188 to enable RB_SWAP. >> >>> >>> >>>>   }; >>>>     static const struct vop_win_data rk3188_vop_win_data[] = { >>> >>> >> Regards, >> >> Alex >> >> >> > >