mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ellie Hermaszewska <kernel@monoid.al>
Cc: eugene.shalygin@gmail.com, Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon: (asus-ec-sensors) add ROG Crosshair X670E Gene.
Date: Wed, 25 Oct 2023 22:01:28 -0700	[thread overview]
Message-ID: <3a8fd5d6-9b79-76de-80fe-b39e24510dec@roeck-us.net> (raw)
In-Reply-To: <b81ae275-d3ac-4565-a09a-4a5ce38fadf1@monoid.al>

On 10/25/23 21:46, Ellie Hermaszewska wrote:
> On 10/26/23 03:35, Guenter Roeck wrote:
>  > This is not an acceptable commit description.
> 
> This is not acceptable feedback.
> 
> I am unable to accept it because it is not clear to me what you think
> should be changed.
> 
> Is it because I misplaced the message to Eugene? Is it because of the
> Greek characters? Is is not descriptive enough of the change, or in the
> wrong tense, or has incorrect punctuation? Do I need to include my
> testing methodology?
> 
> If it's only something minor, then please also feel free to correct it
> yourself before applying. If you can't or it's not something minor,
> then please let me know what ought to change and I can try to correct it.
> 
> If you don't let me know, then I will have to guess and possibly waste everyone's time further.
> 

Please consider reading and following the directions in
Documentation/process/submitting-patches.rst.

Thanks,
Guenter


  reply	other threads:[~2023-10-26  5:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19  3:21 [PATCH] " Ellie Hermaszewska
2023-10-19  9:43 ` Eugene Shalygin
2023-10-19 11:32   ` Eugene Shalygin
2023-10-19 13:51   ` [PATCH v2] " Ellie Hermaszewska
2023-10-25 19:35     ` Guenter Roeck
2023-10-26  4:46       ` Ellie Hermaszewska
2023-10-26  5:01         ` Guenter Roeck [this message]
2023-10-26 10:41           ` Ellie Hermaszewska
2023-10-26 10:43             ` [PATCH v3] " Ellie Hermaszewska
2023-10-26 14:46               ` Guenter Roeck
2023-10-26 14:42             ` [PATCH v2] " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a8fd5d6-9b79-76de-80fe-b39e24510dec@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=corbet@lwn.net \
    --cc=eugene.shalygin@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=kernel@monoid.al \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®