From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4448148B37B for ; Tue, 4 Aug 2026 17:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785864011; cv=none; b=p+DX+2m8PFmo6ZW/aENcs3HcSXFus5a4xot5FVw2zViRYst9PHjpX2e1MQcO6C5a0TBUqBM6fUQuwmCkFASaV1qfM9PgO1xTdwpfBuA8FYojVSpYsHYQ0JpEkhIIl2L/F8cbN4cLEzGMigqRgiyh7FNM//yrdBKuFqGRCwb3fRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785864011; c=relaxed/simple; bh=tn37vxDktpDeGNGM/rBHg3ypjb94/j/pKijNf4Af2V4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oYaobjNRsK2mniZJRLWnAsY4Z9n4gmfYVFx/bmE19dgo94YxDXMG+XsOWplJJCjhI0zf09VIZFID56cyWZ4CPAlTXqakZwIF0C+mnY61FRphniYsEQ5CqofC3zSorS1CZl7qIGbY9Ahngn2q+pbN0mAj/Dbr8CjB78IJVG7K3u0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G0bQfcky; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G0bQfcky" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-930fad20240so6776385a.0 for ; Tue, 04 Aug 2026 10:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785864001; x=1786468801; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7OCTjJNAS4rOdu/mpclXfbvVSReH6ouoLdPqO+Ho98Y=; b=G0bQfcky/kqtsFltIMez8SJRfkbHcNAMtu6Xl7ZmXizeEYASwSEnpTFISmu3mo65y1 Y1MIxjSRKkamTrT9V4TNzKz3XoHsQOIcMxxAdSoYUKbCiUIROtCT0QEeDkQ3Xc04CKPG ShZjbmKmFFF3WOfIqt/18PpjsHqHQ/sfvmglC0YJbj6zUNkDlP2/UL8QHhe5CXavsvQC eOOUlH7R91V+av0Yn3KkCEhhDa8fSfs72WNsBsh5KeFURdLuP10dYQKxo7UWFc9+NVY4 GqbQVXx0pjvmDpFa80nxmG9rrIQ0iuRpU+Hg//TWP0rtDWYUnMa42ax12kNoFW+4PkUQ oUMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785864001; x=1786468801; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7OCTjJNAS4rOdu/mpclXfbvVSReH6ouoLdPqO+Ho98Y=; b=DWmzGxOpmfePK7Blk5ZVy4B/6VOG18rafCZbf6L8YHJSi70RInT63D059/sq8KUaOe jxg6lSvAHgLtabGiGNMJCv1nj9IW2hR2bU3hji+A7Ads9T5056MH4CR1ITOCIhflLShf y3ZTLO/tVTq+mIjbqiemBOs5yVE3PDQkrlm26peDung7YFElONRNbVPyxCO+R5ZiwOLI PM65MkZilWZfCwgo/B4sQeQN0WAjEHEmvVdO99tbYKQQKSgBTlRt1o74hff5xv7f63OK +T3nwCiwOmTCs/AuvNLZM6jifGZVIvx6KkDOEC281+NNUB+SbOrMzXkKlcHYWswXlU4E LiBA== X-Forwarded-Encrypted: i=1; AHgh+RqEndgE6FOR/PchmztHoy4lcT1JfsMuRM/Anz5LWyAuM4J2NVwmZOb65sAE8Pq6vwkgRjVaEHG/cm5ex20=@vger.kernel.org X-Gm-Message-State: AOJu0Yxi2Xw2+/ePbvDp+riVU8539hHuZcwpCYJr5BHPVZktiYX2YI0p CP91nRzAM+UMVssT6cJ/K+8nuK3RBVPZXxmu2y592WKHKNSHoFzrla5c X-Gm-Gg: AR+sD12M8kPPOacGFa34ILFskMeZ8tA72zBOVA7X2y1p6skwD0sRSjMP6fYzga/TjlP Uk58cNoFWFipp9R+E7Qj7fc7QsoYgC8fm5X2HAOJHslTJH6OsITEQXwyZTh/jNpGQJXz6dfQmfi fw6zi90iN/8soz3FuwUO1/i1RF5RbMNRFomQjusN9u6aHGD9Vkcnvl4pbVufPXIr6oNveKYT4j+ qJrVG82cOJAzfpuGG/bk+a8C2yb2a3MkFvgUOOF6rJrJtO0Po2syAKtl9mtu3ZJ/3thFcxOM2hL QxS7z3LCaEtQa9MFxPx/cm6yv40c7hthcYcBclymUFmuZX3EGp82A/CCS/ZH67/UacSgqd7VedM p/q/E1qP9f1wJVdYdpoITGCHKDJOuzNDDU5l9PGEzwhr/Wl9SdyLQvwyexnTYn13AhDR4TcB7RD vKCKDnAAkWO5Iii5BpcvaGYjRT8v4Z7PP7hP70KDrMp4qIQIObd5+qHdrPnu7o7HTF0f82BDgUt Qo9dV7NOOfRUtEM4eK+HIuUrJ0ZDr7fZX0zZOIwUCsCjaagf2PdnQ== X-Received: by 2002:a05:620a:8bc7:b0:930:a631:68bf with SMTP id af79cd13be357-934a0955e3amr2166079185a.22.1785864000974; Tue, 04 Aug 2026 10:20:00 -0700 (PDT) Received: from ?IPV6:2600:4040:9399:4000:e553:72e5:7d37:c7ef? ([2600:4040:9399:4000:e553:72e5:7d37:c7ef]) by smtp.gmail.com with ESMTPSA id af79cd13be357-93641702c6asm126843985a.3.2026.08.04.10.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 10:20:00 -0700 (PDT) Message-ID: <3a936f25-95b1-4b85-9d8d-d5ef9949b7d6@gmail.com> Date: Tue, 4 Aug 2026 13:19:59 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next V2 09/13] net/mlx5e: psp: Add an rx_decap steering table To: Tariq Toukan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Sabrina Dubroca Cc: Aleksandr Loktionov , Alexei Lazar , Boris Pismenny , Carolina Jubran , Chris Mi , Cosmin Ratiu , Doruk Tan Ozturk , Dragos Tatulea , Gal Pressman , Jacob Keller , Jianbo Liu , Kees Cook , Lama Kayal , Leon Romanovsky , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org, Mark Bloch , Patrisious Haddad , Raed Salem , Rahul Rameshbabu , Saeed Mahameed , Shuah Khan , Shuah Khan , Simon Horman , Stanislav Fomichev , Stanislav Fomichev References: <20260804083535.2946459-1-tariqt@nvidia.com> <20260804083535.2946459-10-tariqt@nvidia.com> Content-Language: en-US From: Daniel Zahka In-Reply-To: <20260804083535.2946459-10-tariqt@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/4/26 4:35 AM, Tariq Toukan wrote: > From: Cosmin Ratiu > > Introduce an additional steering table for PSP transport mode > decapsulation, containing: > - one rule per supported PSP version which does: > - transport mode decap (removes UDP+PSP headers and PSP trailer) > - recomputes iph->tot_len > - recomputes IP checksum > - reparses packet headers > - copy SPI into reg_b (which ends up as cqe.ft_metadata) > - set a decap marker and the PSP version in the flow_tag, so the RX > handler can make sense of the packet > - default drop rule for unsupported PSP versions (per PSP spec). > > Packets are forwarded to the previously added rx table, where: > - one rule forwards UDP traffic to the UDP default destination. > - default rule forwards traffic to the TTC table. > > The reason is to avoid steering loops. If packets were to be injected > into the TTC directly after rx_decap, it may be possible to create a > steering loop with RX packets of the form IP|UDP|PSP|UDP|PSP... > The rx flow table guarantees that packets go through PSP steering at > most once. > > The steering mode is saved in a new field 'fs.decap_enabled'. > Updating the mode is done through accel_psp_fs_rx_reconfigure(), which > creates the decap steering table if needed and possible. It then uses an > atomic rule update to redirect traffic to the new table. > This is now invoked with decap_wanted == false. > The intention is for failures creating the new table to not block feature > reconfig. A message is logged when table creation failed and PSP for HW > GRO will not work in that case. > Nothing happens on HW without the ability to decapsulate PSP transport. > > An upcoming patch will add dynamic reconfiguration of PSP steering based > on HW GRO. > > Signed-off-by: Cosmin Ratiu > Reviewed-by: Dragos Tatulea > Signed-off-by: Tariq Toukan Cosmin, can you TAL at https://lore.kernel.org/all/0d72c5b2-6d4c-40d4-8cbe-8cd95d61a230@gmail.com/ and let me know if this is an issue or not? I see the patch looks the same, but wasn't sure if you didn't see my message or if it is a false positive.