From: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"Shiming Cheng (成诗明)" <Shiming.Cheng@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"willemdebruijn.kernel@gmail.com"
<willemdebruijn.kernel@gmail.com>,
"edumazet@google.com" <edumazet@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: drop pulled SKB_GSO_FRAGLIST skb
Date: Wed, 15 May 2024 09:05:47 +0000 [thread overview]
Message-ID: <3a9388af81eba384e8fb15b1559b87de3ab04e1e.camel@mediatek.com> (raw)
In-Reply-To: <662f9fc92a908_2e2f1d294c2@willemb.c.googlers.com.notmuch>
On Mon, 2024-04-29 at 09:25 -0400, Willem de Bruijn wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> shiming.cheng@ wrote:
> > From: Shiming Cheng <shiming.cheng@mediatek.com>
> >
> > A SKB_GSO_FRAGLIST skb without GSO_BY_FRAGS is
> > expected to have all segments except the last
> > to be gso_size long. If this does not hold, the
> > skb has been modified and the fraglist gso integrity
> > is lost. Drop the packet, as it cannot be segmented
> > correctly by skb_segment_list.
> >
> > The skb could be salvaged. By linearizing, dropping
> > the SKB_GSO_FRAGLIST bit and entering the normal
> > skb_segment path rather than the skb_segment_list path.
> >
> > That choice is currently made in the protocol caller,
> > __udp_gso_segment. It's not trivial to add such a
> > backup path here. So let's add this backstop against
> > kernel crashes.
> >
> > Fixes: 3a1296a38d0c ("net: Support GRO/GSO fraglist chaining.")
> > Signed-off-by: Shiming Cheng <shiming.cheng@mediatek.com>
> > Signed-off-by: Lena Wang <lena.wang@mediatek.com>
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
Dear experts,
Could you please help to update the upstream progress?
Thanks
Lena
next prev parent reply other threads:[~2024-05-15 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:30 shiming.cheng
2024-04-29 13:25 ` Willem de Bruijn
2024-05-15 9:05 ` Lena Wang (王娜) [this message]
2024-05-20 5:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a9388af81eba384e8fb15b1559b87de3ab04e1e.camel@mediatek.com \
--to=lena.wang@mediatek.com \
--cc=Shiming.Cheng@mediatek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®