From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A433342669E for ; Mon, 29 Jun 2026 15:16:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782746180; cv=none; b=MAQyhaZ7RFewpziFwU/U6p4Cs6Gw0tN1cHNsmimIBtmmKPob8N9ycwg+ZjBsEFEdcaRbRkQSlAVyIsttIPSKoYzvH5Q8pOr9q5a3Z50fTE12L4RE7QAdweGEgqXf7gJtpZpguezDiDUoJdWNA1zisFYn8dc1RxQdjHxpP5WhBsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782746180; c=relaxed/simple; bh=lKy4aCKGQpCX43GhJty4oLzKEwjcCep/eT3eY96uy8M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jo+hkc4GJKKC/9cVwtn5Gqm707Xc9QGjHcrXKQ5DCBsfdWQt1JqjiclchZuHAo3jWk6iHZvTs7VP0OqTAhe9GRcmmxc+euw7EDSa56Dyezz2gB6X/iIQGffna5br/Ml9wKnTkp0AcQ1ypVTmVGlMryr81i1hc4h9Dnaqc8ij9uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=QyNMZEAf; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="QyNMZEAf" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7e9cb0e594bso552385a34.3 for ; Mon, 29 Jun 2026 08:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782746178; x=1783350978; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xm05s8v0mjGkdrpcNxT3cT8GPMUG6WjwWeFiXkf0Aws=; b=QyNMZEAffsobLpv56dFF7GnHk3MVoMLYwbBTSHSUCqyq3+ZsBa4C02Q8fYW0GNVjVi 2TlwaDJtu5Bvppioy3WZ6fH9OyuSWM065RVFwAZu4ZBAIGt3XApdBKa+9oo0ufxrT28a Sdo8vvCiBDi7tx/R3P55rJ70ged4gv/HoMSmcdmXHL2rjwbMyqFoPJP1kPEZxamjc+NR aFX8kE/QqDg0QbijretXZfPMd6RuvPDwWgWJ3k5uOJJlvDzIu1bwWGqXg57y4PwM5JyI Yyujsr1fdWuJSfIe7vWY1jVOrW2NC//X7KMZ/np01gto9/609CsZELBeWbE/LWOG+Hmx aydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782746178; x=1783350978; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xm05s8v0mjGkdrpcNxT3cT8GPMUG6WjwWeFiXkf0Aws=; b=p1z268PBeyaW9IlIg/7gnqrBZe01zmCQ6aCwI+XBIs0kbUXMSiBOZb4Czg4LWy72sW aTn/R7z+lTDzCkpK05sqcFb/VNmY4NcWwzdDMXBlPgbNZffag8FwGJmGeJuWD1SRFmcR j5H5zfAY3tFLLQYLulBY4NALSFrE87Urk47stYREdZ5ztOljUp5pdaD7YYlaidupIOi6 gOR6lGWy5KFxIkZMicIZP9WVJ74bi83L81qQUUco7LP6x6rE4WEEO+8rfhiVVB2g6KTc c+WqXOXL9ZxsRPr5CMAxrsSoy1QeirZj6ncMOOeFTMmghOj+bOvRmOFqNyoRhjpOpjDJ ntUQ== X-Forwarded-Encrypted: i=1; AFNElJ+PE4Qx+vG6RHurmosPGC8soQls0tpMVVOmjxj6FpS3VymLRsYoS6YwVtEHtz99ogdpZQURGkLFzLVOf3s=@vger.kernel.org X-Gm-Message-State: AOJu0Yxs6bao6KLvypzAHlIWC0V2AT8FyumIWDxmzxfv4TN5UR7vTzqG kyCW6A2JA6UhtlgFK/Bd2M6u7/b98ZJyww2519TavKJ6Z8oby0MsE6nkxyhZHzmmBw4= X-Gm-Gg: AfdE7cmXurhxgoL51Cj8pF2ujP4OELEG4AwkOin0E2qJOvOpqCmnoIfzJOYj1HZZZ7E cIi4i48BHjFinzMJYHKlyEmca03FGzeVc4nZoRhc9/QTnY1nr2tM1zWj8MgL+wqPZvpayYDhNr/ +CAtAkSvpumrjQDwMH5VWo89+gSlHKIemd4ve1zete/jv+gmtmRtS25MvDIrfWDavoEHwEyWe2a CgXotG9EoaumlZR+8TjLlvKsnCaTJEV8TcJB7u7ive7DfnMJO2x9w1mfU/vDwX3po9OOHKbd3fF YHB+GCrBHTQExPAACVYoSzvCuQWKlMrqom1nJ0FEZ8PVcG1SZpV+mMaxMDvUY1z0NSj2kBLpHOi HO7BAXoE5q4/EXfzNeGe12QkNuitjIib/fuXJrSrTrhb87DAx8p4+6IGxHovgEVr+TQhxnmf3e5 C7hkL95//sZkM3NzbwDvOv0bl/ZhlT4gNeCgthdyj17qAZN8pLQR3IYbRBzRVvKos= X-Received: by 2002:a05:6830:4998:b0:7e6:f083:130e with SMTP id 46e09a7af769-7e99bfef82bmr15251661a34.4.1782746177656; Mon, 29 Jun 2026 08:16:17 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:3533:aa22:9a69:df1c? ([2600:8803:e7e4:500:3533:aa22:9a69:df1c]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e9ec3085dfsm18790a34.22.2026.06.29.08.16.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 08:16:16 -0700 (PDT) Message-ID: <3a96a20c-f435-4b98-9e95-26a28bd06e7b@baylibre.com> Date: Mon, 29 Jun 2026 10:16:16 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] iio: adc: ltc2378: Add support for LTC2378-20 and similar ADCs To: Marcelo Schmitt Cc: Marcelo Schmitt , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jic23@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, julianbraha@gmail.com References: <0abf862eeb277ae82262d09b11b1446f04c47be7.1782397418.git.marcelo.schmitt@analog.com> <9c6e0a74-c9c5-43ee-8eca-ae1667c51c32@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit It helps if you don't trim the "On ... wrote:" part of the reply so that we know who wrote what. :-) On 6/29/26 9:57 AM, Marcelo Schmitt wrote: >>> +{ \ >>> + .type = IIO_VOLTAGE, \ >>> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ >>> + BIT(IIO_CHAN_INFO_SCALE) | \ >>> + (_offl ? BIT(IIO_CHAN_INFO_SAMP_FREQ) : 0), \ >>> + .info_mask_separate_available = _offl ? BIT(IIO_CHAN_INFO_SAMP_FREQ) : 0,\ >>> + .scan_index = 0, \ >>> + .scan_type = { \ >>> + .format = _sign ? IIO_SCAN_FORMAT_SIGNED_INT : \ >>> + IIO_SCAN_FORMAT_UNSIGNED_INT, \ >>> + .realbits = _real_bits, \ >>> + .storagebits = _storage_bits, \ >>> + .shift = (_offl ? 0 : _storage_bits - _real_bits), \ >>> + .endianness = _offl ? IIO_CPU : IIO_BE \ >>> + }, \ >>> +} >>> + >>> +#define LTC2378_BIPOLAR_DIFF_CHANNEL(_real_bits) \ >>> + __LTC2378_DIFF_CHANNEL(1, _real_bits, (((_real_bits) > 16) ? 32 : 16), 0) >>> + >>> +#define LTC2378_UNIPOLAR_DIFF_CHANNEL(_real_bits) \ >>> + __LTC2378_DIFF_CHANNEL(0, _real_bits, (((_real_bits) > 16) ? 32 : 16), 0) >> >> Why not move the (((_real_bits) > 16) ? 32 : 16) into the __LTC2378_DIFF_CHANNEL() >> macro to avoid repeating it? >> > Because that would go wrong for LTC2378_OFFLOAD_BIPOLAR_DIFF_CHANNEL() in patch 3. > It could use `_offl ? ...` in the macro for that. Not a big deal to me though. >>> + >>> +struct ltc2378_chip_info { >>> + const char *name; >>> + unsigned int internal_ref_uv; > ... >> >>> +static int ltc2378_regulator_setup(struct device *dev, struct ltc2378_state *st) >>> +{ >>> + int ret; >>> + >>> + ret = devm_regulator_get_enable_read_voltage(dev, "refin"); >>> + if (ret < 0 && ret != -ENODEV) { >>> + return dev_err_probe(dev, ret, "failed to read refin regulator\n"); >>> + } else if (ret > 0) { >> >> Else is not needed here. > Why not? The if returns unconditionally, so else is not needed. This is just a general principal.