From: Paolo Abeni <pabeni@redhat.com>
To: Meghana Malladi <m-malladi@ti.com>,
javier.carrasco.cruz@gmail.com, diogo.ivo@siemens.com,
horms@kernel.org, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com,
Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>,
danishanwar@ti.com
Subject: Re: [PATCH net 1/2] net: ti: icss-iep: Fix pwidth configuration for perout signal
Date: Thu, 13 Feb 2025 12:23:48 +0100 [thread overview]
Message-ID: <3a979b56-e9d6-41c9-910b-63b5371b9631@redhat.com> (raw)
In-Reply-To: <20250211103527.923849-2-m-malladi@ti.com>
On 2/11/25 11:35 AM, Meghana Malladi wrote:
> @@ -419,8 +426,9 @@ static int icss_iep_perout_enable_hw(struct icss_iep *iep,
> regmap_write(iep->map, ICSS_IEP_CMP1_REG0, lower_32_bits(cmp));
> if (iep->plat_data->flags & ICSS_IEP_64BIT_COUNTER_SUPPORT)
> regmap_write(iep->map, ICSS_IEP_CMP1_REG1, upper_32_bits(cmp));
> - /* Configure SYNC, 1ms pulse width */
> - regmap_write(iep->map, ICSS_IEP_SYNC_PWIDTH_REG, 1000000);
> + /* Configure SYNC, based on req on width */
> + regmap_write(iep->map, ICSS_IEP_SYNC_PWIDTH_REG,
> + (u32)(ns_width / iep->def_inc));
This causes build errors on 32bits:
ERROR: modpost: "__udivdi3" [drivers/net/ethernet/ti/icssg/icss_iep.ko]
undefined!
make[3]: *** [../scripts/Makefile.modpost:147: Module.symvers] Error 1
make[2]: *** [/home/nipa/net/wt-0/Makefile:1944: modpost] Error 2
make[1]: *** [/home/nipa/net/wt-0/Makefile:251: __sub-make] Error 2
make: *** [Makefile:251: __sub-make] Error 2
ERROR: modpost: "__udivdi3" [drivers/net/ethernet/ti/icssg/icss_iep.ko]
You should use div_u64()
/P
next prev parent reply other threads:[~2025-02-13 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 10:35 [PATCH net 0/2] Fixes for perout configuration in IEP driver Meghana Malladi
2025-02-11 10:35 ` [PATCH net 1/2] net: ti: icss-iep: Fix pwidth configuration for perout signal Meghana Malladi
2025-02-13 11:23 ` Paolo Abeni [this message]
2025-02-14 6:05 ` [EXTERNAL] " Malladi, Meghana
2025-02-16 16:11 ` Simon Horman
2025-02-19 6:28 ` Malladi, Meghana
2025-02-11 10:35 ` [PATCH net 2/2] net: ti: icss-iep: Fix phase offset " Meghana Malladi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a979b56-e9d6-41c9-910b-63b5371b9631@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®