From: "Enrico Weigelt, metux IT consult" <metux@gmx.de>
To: "Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] p9caps: add Plan9 capability devices
Date: Tue, 13 Feb 2018 12:40:14 +0000 [thread overview]
Message-ID: <3a99edaf-0365-ec7e-4d2f-1e21dea007ac@gmx.de> (raw)
In-Reply-To: <20180213071655.GA11240@mail.hallyn.com>
On 13.02.2018 07:16, Serge E. Hallyn wrote:
>> + /* make sure only one instance per namespace can be opened */ > > ... at a time
yeah, right.
> might be better to keep this state in the user_ns itself, would
> avoid kzalloc below.
thought about, but hesitated to touch user_ns. might not be the best
idea when having p9caps as module (OTOH, doesn't need to be a module)
the whole thing might become a bit more complex when introducing
plan9-like unprivileged mount operations. haven't sorted out how to
do that yet.
> Would it be worth doing any privilege checking here?
Which ones should I check ?
--mtx
next prev parent reply other threads:[~2018-02-13 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 16:58 Enrico Weigelt, metux IT consult
2018-02-10 17:54 ` Randy Dunlap
2018-02-11 21:50 ` Enrico Weigelt, metux IT consult
2018-02-11 21:50 ` [PATCH] " Enrico Weigelt, metux IT consult
2018-02-13 7:16 ` Serge E. Hallyn
2018-02-13 12:40 ` Enrico Weigelt, metux IT consult [this message]
2018-02-14 14:56 ` Serge E. Hallyn
2018-02-14 17:58 ` Enrico Weigelt
2018-02-17 22:11 ` Richard Weinberger
2018-04-25 10:38 ` Enrico Weigelt
2018-04-25 12:23 ` Richard Weinberger
2018-02-10 18:03 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a99edaf-0365-ec7e-4d2f-1e21dea007ac@gmx.de \
--to=metux@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®