Re: [PATCH net v2] net: pse-pd: don't enable a PI again while disabling it

[Kory Maincent <kory.maincent@bootlin.com>]

On 10/22/26 12:08, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 · Medium: 0 (4) · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The fix is incomplete: the PI being disabled is still enabled
>    again, and the power budget still leaks, on the priority-eviction path.
> 
> Pre-existing issues:
> - [Medium] The priority cut-off in pse_pw_d_retry_power_delivery()
>    (drivers/net/pse-pd/pse_core.c) never takes effect.

Can you take a look at the above issues?
The other ones are currently in discussion with Kyle due to similar 
report he faced on his series.

> - [Medium] pse_set_config_isr() (drivers/net/pse-pd/pse_core.c line 1211)
>    tests `notifs & PSE_BUDGET_EVAL_STRAT_DYNAMIC`.
> - [Medium] pse_pi_disable() (drivers/net/pse-pd/pse_core.c lines 701-719)
>    always returns 0, even when _pse_pi_disable() fails (for example an…
> - [Medium] In the disconnection branch of pse_set_config_isr()
>    (drivers/net/pse-pd/pse_core.c lines 1233-1243), isr_pd_detected is…
> -- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com