From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Alex Robinson" <alex@ironrobin.net>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Steev Klimaszewski <threeway@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: sc8280xp-x13s: Add embedded controller
Date: Tue, 29 Sep 2026 15:54:21 +0200 [thread overview]
Message-ID: <3aa4a96f-76b4-4961-8c9f-4eb099016a01@oss.qualcomm.com> (raw)
In-Reply-To: <20260928222056.10044-4-alex@ironrobin.net>
On 9/29/26 12:21 AM, Alex Robinson wrote:
> Enable the embedded controller at address 0x28 on i2c8, with GPIO103 as
> its falling-edge, wake-capable event interrupt.
>
> Configure the QUP8 bus on GPIO43 and GPIO44 with 2 mA drive strength and
> pull-ups, matching the working firmware-established pin configuration.
>
> Configure GPIO103 as an input without overriding its existing pull
> configuration. Describe GPIO176 as the separate active-high power-state
> output and configure it initially high with bias disabled.
Most of this commit message is unnecessary and repeats the contents
of the diff, please direct the clanker to:
Documentation/process/submitting-patches.rst
[...]
> + ec_int_n: ec-int-n-state {
> + pins = "gpio103";
> + function = "gpio";
> + input-enable;
> + /* Preserve firmware pull configuration; no bias override. */
Please find that value (read it back at boot) and place it here
> + };
> +
> + ec_power_state: ec-power-state {
> + pins = "gpio176";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-high;
Drop this line and assert the state in the driver as necessary
Konrad
prev parent reply other threads:[~2026-09-29 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 22:21 [PATCH v3 0/3] Lenovo ThinkPad X13s embedded controller support Alex Robinson
2026-09-28 22:21 ` [PATCH v3 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad X13s EC Alex Robinson
2026-09-29 9:10 ` Krzysztof Kozlowski
2026-09-28 22:21 ` [PATCH v3 2/3] platform: arm64: Add Lenovo ThinkPad X13s EC driver Alex Robinson
2026-09-29 7:59 ` Ilpo Järvinen
2026-09-28 22:21 ` [PATCH v3 3/3] arm64: dts: qcom: sc8280xp-x13s: Add embedded controller Alex Robinson
2026-09-29 13:54 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aa4a96f-76b4-4961-8c9f-4eb099016a01@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=alex@ironrobin.net \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=threeway@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®