From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14FEC1799F for ; Wed, 10 Jun 2026 18:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781115083; cv=none; b=S2cIE6zMLuqrQadP91155NUiPl3hYab++yQz9uuPPMWjdczbV+RP0GXnSkYAd/tujDtWnG0MZdtXfvf6+I26d11MdmvzObxFlZP7/N53jojNTnEs6Lb6g1aiLkfsMkiUXK37Ao2W716VFsPC8KYcfXvVTlMO2ZGZeLWcadB6aQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781115083; c=relaxed/simple; bh=rARHZonBLtdal4S9wNNeqesAoKQdJzVMfUxStkKkW58=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pULF2Kw42KvqHI/vezY6xxCyBRP3RamGDebDf78Qif66LYKnISXgBvHYjKBGO2RVDeVZg+aCPZEFEwF7DOOucnhtVy5zgWKBXcHpht2yHnCXf9tds4+0IfXlXK5RJZIt9RfeV1wllMCB1FuDitCaa82j1Jek3Ks2vUQCVVEp7/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TgN5ToA9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HvAFx/Rw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TgN5ToA9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HvAFx/Rw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65AFxKDr1670933 for ; Wed, 10 Jun 2026 18:11:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8XBtQGM/dbzn9KbgmF/PPmQm4UuVJGjL0pdntzgTrVw=; b=TgN5ToA96vt0SBTD dPtV6Mqty5gmVWOxy2S8Gpu4TWbl+Bp2b4+Xr3iOfBVGoyUr8/md+VngDFr5896/ gzZ8k/BAgnC8xg2umQoxooQh6pT2MKjuiLaPTh83AnbVFUVjMmCH33giqjiWrdWU wH4QLG/rVgKYZdl5JMuwXii5MDjBGroZXmwK5wzyuXrSIhRNiE+Dm6Y/2ONXMcsT dvNB6xD6NR59OqlIQOVKToOBNh/HaVqaWALIWdhKeHDTdohKxmDhF0MIiptKO1f6 QZT0lxA/9OBQRzyGdka9Dt1ZZQ2Yg+wh7RDIiIYzs4ZzQfz7qDk1I5RlzT3cfIKC c3dkTg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq0m1uach-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 18:11:21 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8424aac207eso6977893b3a.0 for ; Wed, 10 Jun 2026 11:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781115081; x=1781719881; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8XBtQGM/dbzn9KbgmF/PPmQm4UuVJGjL0pdntzgTrVw=; b=HvAFx/RwAvJxxp/AyIJQidpad4UCsWe/u98XtA2kVq2/JcSRBh1e+aijAQ2dMOtQy2 nzgsRlbJMdHyfoUokDdn4FQbRlie4pmr2wwZP5A/XgnT0OVTvK95nMti9a4Zzt9Mj2Ud 2l5ib54XxvjAOKkniLrS4fX4RpeIX/rCmLXRRh4iXj93ZyMs707glZEhCrPYxYdH+fJS vn9z55nDuVP46dhSAe0/Q7DKdaYMWetOCo6lDG8N6ucXH/txZf07CUBBArjZPWgwW4kC ulFdQ1R0R59aq1XsNppd86nihkWCrAHcCjES5t2Tqy5WADMAiy9GzQy0lVKcOyxKtSOd vjMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781115081; x=1781719881; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8XBtQGM/dbzn9KbgmF/PPmQm4UuVJGjL0pdntzgTrVw=; b=p1zO5nvR13HdF7h32qf2aXvLJ1+9Axwy5Zsn0oxXZEm94wVOd5rbgrjEWiD+KlKHjX 5Ag7o4mgP/5+BIM01C9pOxJZNO4JEM/6A/wV0v6/LYf+knYSU3FkYOZ2zl6sRgUMxRd8 GmprPG42AqZ+C+eQZ42F0BI+3AOOvyiWsA0cgjQWqpNBRvaMtwt/4LNh1Wsi5X9OnWa7 iaTlt75M2FIL8fv9R+YhrjUVyidVcuQAH3aIsusICl6Drvb7EUVDklyQKyiTPmrnXCc8 JSSrCgGco39bY2golZthpAEfm+9idKn+SvNFA6r8QvkndNvoBuMTQlgRIRM7PxTTaQLz K6TQ== X-Forwarded-Encrypted: i=1; AFNElJ9p+Ky8zPxbXF6JjGEJaJjB2jSz/srp96bCDyQ1CXYoEhRFjjvucLCS6Jl0IF1h/I0V/bmt/Sm+QbifJxc=@vger.kernel.org X-Gm-Message-State: AOJu0YxvGMLU/ImD0gx6W/lAUsjV9j9uyvfPhBKGAMJ7iw6RhQB9Rgye l7Z0yhc8gkwyT5XMjNR7pWOr0fCLgDPBeFdMrp8AKQtWpl6aVMQXtZN8OZv9HzAA2sDwZy7aNUE dQMuv0BzLfbdIPEEmnItKCvozYpVj0nvoenZ6iBHNN1JHW8AABJLoGLaNYOCXJhlmF/6OxfW6bf E= X-Gm-Gg: Acq92OFSpj6SKpO2aydhzAQrmSerCS2N9f85IdZvMj6myD7YAaeA1S80YYvWz9LxtZu L3RKzyqnJVyeLtDE82zRJF6Sj/btQ8W+BGWLnwNcoXao7FkKFDX8ep/6fNDj17HoKq8T0DjXjHq cO4Nn7s3ppeMKP/Ig/7aQ+DS9jpKfJSaiy65B0/HZElWm3mGEN8VNUTMBPfT1Y92ydjIPEzorsa jTk6NZ9QAMIcebzTN9yx0Swh3mh9bXTTj6CqIXHCeDUGsCylCV4kqbYF/LRjZxQEqZ0lZNU927I mW9lRzEQ2D3iNCLN9ZSDToE5yHZCzhtzRyKhaEfniuCtPJhVkHuXt/Yum//qYj6pLbTmcgGp55R 8LdJhYp4yUxxkZfRxqAgTP5Q2kCbcrKUPMsySBSHtDJA1DG2EZSvbzQrFluKz X-Received: by 2002:a05:6a00:1496:b0:83a:b344:826a with SMTP id d2e1a72fcca58-842b0f4eda9mr27861689b3a.26.1781115080648; Wed, 10 Jun 2026 11:11:20 -0700 (PDT) X-Received: by 2002:a05:6a00:1496:b0:83a:b344:826a with SMTP id d2e1a72fcca58-842b0f4eda9mr27861654b3a.26.1781115080189; Wed, 10 Jun 2026 11:11:20 -0700 (PDT) Received: from [192.168.1.8] ([122.174.150.90]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8428291ed20sm31077738b3a.61.2026.06.10.11.11.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 11:11:19 -0700 (PDT) Message-ID: <3aa529a2-b4e0-4188-bd8c-a6b3c5e2f1d7@oss.qualcomm.com> Date: Wed, 10 Jun 2026 23:41:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] pinctrl: qcom: lpass-lpi: drop unused runtime-PM write helper To: Krzysztof Kozlowski , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610080809.2588640-1-ajay.nandam@oss.qualcomm.com> <0fc4d9d4-2943-4ed8-a8ea-014e83c74e5c@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDE3MCBTYWx0ZWRfX4iEb6VCrHn0o poQb2eh+DW4KewfRy5IbeptaWN5tf50R59VlyGKFMEoiuoAXGkeZefv/jzxE0rlQMe2aAQu5o+m RXaG5cRUoS0Fc1BnGVW0/Sz2m4XqPpVf26DaoMtZhBju3Zly3USlPc5dIIB2UWcbOGhcSL29f6H UFQWJkr7cnrSbSS6lvJoTcZxjAckYr9TTrHVW4nkOhcWJE0xbWxox0qKa8lHnHkNId1r/kk60Kk tJfc2oWBT3aeEniK5tBMru1cKKjElCdVhSpLwpYEFUtk6F9We7mhU/XkKDACye+WphzKVvRJxvl TWoqe6zrugiZcrwAgIu0YEqwIdVcDbCuNNDHsww0PdV9H/cWO5cGGUeg4GSiGcvEe1Yykk66+tQ RmeoT65TXH+lGlZwHeoz7w7kPWg31B5UVoAyFFbbQ56tsWKQ6gCBEb/07SvF5QY1HxDBILz45rG AK9otuu+GJ3ZZqC3J2w== X-Proofpoint-GUID: WNc8-WdjwMo-2JvUFTvMM64JL-vlrREX X-Authority-Analysis: v=2.4 cv=UdJhjqSN c=1 sm=1 tr=0 ts=6a29a8c9 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ph9GlEvSy1Vz2RjkXBjw8g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=wZmLNYNR7iDTIedOvHwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: WNc8-WdjwMo-2JvUFTvMM64JL-vlrREX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100170 On 6/10/2026 2:30 PM, Krzysztof Kozlowski wrote: > On 10/06/2026 10:57, Ajay Kumar Nandam wrote: >>> So why do we need __lpi_gpio_write()? >> >> Hi Krzysztof, >> >> Thanks, good point. >> >> I will respin with: >> Reported-by: Nathan Chancellor > > > And checkpatch. > >> >> About __lpi_gpio_write(): it is still needed for the in-callers path >> where runtime PM is already held and we only need the raw MMIO helper. >> The unused wrapper is lpi_gpio_write(), so this fix removes only that >> dead function. > > No. Why did you have to add __ prefix? Why do we need function named > with such style? I’ve posted v2 addressing this: https://lore.kernel.org/all/20260610180012.3505877-1-ajay.nandam@oss.qualcomm.com/ In v2 I removed the unused wrapper, renamed the internal helpers from __lpi_gpio_* to lpi_gpio_*_reg (no functional change) Thanks Ajay kumar Nandam > > Best regards, > Krzysztof