From: "J.R. Mauro" <jrm8005@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Lindent and __user, etc.
Date: Tue, 14 Oct 2008 13:27:42 -0400 [thread overview]
Message-ID: <3aaafc130810141027p660efb62p92c586b1c40a5e71@mail.gmail.com> (raw)
Indent doesn't understand macros and typedefs, so when running Lindent
it makes some wrong suggestions about pointers. For example, something
like "void fun(void __iomem *ptr)" comes back as "void fun(void
__iomem * ptr)" from Lindent. I emailed the maintainer, and as indent
doesn't do any parsing, the only solution is by telling it your
typedefs with -T. Obviously, telling Lindent about every typedef and
special macro in the kernel might be prohibitive, but should it at
least know about __kernel, __user, etc. and all the u8, u16, etc.
typedefs?
Letting indent know about some common typenames will also help it find
other style bugs it currently misses. I can submit more examples if
desired, and I'll submit a patch to Lindent if people think it would
be a good idea. Please CC me directly with replies.
Thanks,
J.R.
next reply other threads:[~2008-10-14 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 17:27 J.R. Mauro [this message]
2008-10-18 4:54 ` J.R. Mauro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aaafc130810141027p660efb62p92c586b1c40a5e71@mail.gmail.com \
--to=jrm8005@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®