mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J.R. Mauro" <jrm8005@gmail.com>
To: "Adrian Bunk" <bunk@kernel.org>
Cc: "Greg KH" <greg@kroah.com>, "Huang Weiyi" <weiyi.huang@gmail.com>,
	gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: staging: me4000: remove duplicated #include's
Date: Sun, 26 Oct 2008 17:40:04 -0400	[thread overview]
Message-ID: <3aaafc130810261440q1f801a3bv8b74d5629aa1edfc@mail.gmail.com> (raw)
In-Reply-To: <20081026213335.GB1586@cs181140183.pp.htv.fi>

On Sun, Oct 26, 2008 at 5:33 PM, Adrian Bunk <bunk@kernel.org> wrote:
> On Mon, Oct 20, 2008 at 02:18:22PM -0700, Greg KH wrote:
>> On Sat, Oct 18, 2008 at 11:52:15AM +0800, Huang Weiyi wrote:
>> > Removed duplicated #include's in drivers/staging/me4000/me4000.c
>> >    asm/uaccess.h
>> >    linux/fs.h
>> >
>> > Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
>> >
>> > diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
>> > index 862dd7f..90de6f0 100644
>> > --- a/drivers/staging/me4000/me4000.c
>> > +++ b/drivers/staging/me4000/me4000.c
>> > @@ -30,7 +30,6 @@
>> >  #include <asm/uaccess.h>
>> >  #include <linux/errno.h>
>> >  #include <linux/delay.h>
>> > -#include <linux/fs.h>
>> >  #include <linux/mm.h>
>> >  #include <linux/unistd.h>
>> >  #include <linux/list.h>
>> > @@ -39,7 +38,6 @@
>> >  #include <linux/poll.h>
>> >  #include <linux/vmalloc.h>
>> >  #include <asm/pgtable.h>
>> > -#include <asm/uaccess.h>
>> >  #include <linux/types.h>
>> >
>> >  #include <linux/slab.h>
>>
>> Hm, this doesn't apply anymore as some cleanups went in that should have
>> just made this not needed.
>>
>> But if you have a script I can run somewhere to verify it, I'd
>> appreciate it.
>
> linux-2.6$ make help | grep include
>  includecheck    - Check for duplicate included header files
> linux-2.6$

Is there a way to get this to just check in a user-specified
directory? I didn't see any options for that and adding
M=drivers/staging didn't help.

>
>> thanks,
>>
>> greg k-h
>
> cu
> Adrian
>
> --
>
>       "Is there not promise of rain?" Ling Tan asked suddenly out
>        of the darkness. There had been need of rain for many days.
>       "Only a promise," Lao Er said.
>                                       Pearl S. Buck - Dragon Seed
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

  reply	other threads:[~2008-10-26 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-18  3:52 Huang Weiyi
2008-10-20 21:18 ` Greg KH
2008-10-26 21:33   ` Adrian Bunk
2008-10-26 21:40     ` J.R. Mauro [this message]
2008-10-26 22:05       ` Adrian Bunk
2008-10-27 13:45         ` J.R. Mauro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3aaafc130810261440q1f801a3bv8b74d5629aa1edfc@mail.gmail.com \
    --to=jrm8005@gmail.com \
    --cc=bunk@kernel.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weiyi.huang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®