From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdANTuf (ORCPT ); Sat, 14 Jan 2017 14:50:35 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:32955 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbdANTue (ORCPT ); Sat, 14 Jan 2017 14:50:34 -0500 Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro To: Greg KH , Kartikey singh References: <20170114182336.ekexr4mluquurd63@kartikey-HP-Notebook> <20170114183801.GA27644@kroah.com> <20170114194036.GB30750@kroah.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ivan Safonov Message-ID: <3aae100e-7a1b-fbc7-4711-cc7b46edf02d@gmail.com> Date: Sat, 14 Jan 2017 22:53:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170114194036.GB30750@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2017 10:40 PM, Greg KH wrote: > On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: > Even better yet, remove it and rebuild the driver and see if it > breaks :) Only if the code is not between #ifn?def / #endif...