From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E00430F803 for ; Wed, 12 Aug 2026 05:46:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786513605; cv=none; b=dG2W1/a5w9ceBcMPGPp01TnwrR/ZXAqBBf3ganufQEHJCzAnUO281TYTGFdHOWZmAyBtrarAvH2bs42ML/Q5zoytTICt/b1e8yzDbA4Xzn0WrSRGOfxUzFs59yqiUtOGnRlbl9m5xD/7+WfVEy+jjpS8iWKPzZTq9/VCaENa7Ko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786513605; c=relaxed/simple; bh=NS8vk08ZDdbMm9k/jRmagXJTF//VZNaWWpx1yMIUGLc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pEPoaE6FD7k/v3v6PyRzwhfCw+FtBEd6twApqW2qNWdcYmX6rFwrti/pu4B23FPUcp+ab6z6xk92HeecP5xAvkEs1xNitttOBoWYrlBi4RZu1aMPiEusjyf/H1SUylF3sWN1X+2h8tfWYu76sZWN4JSqqpNPBiHt5ogBzvahqDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PssAq2WZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lj9iqCWA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PssAq2WZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lj9iqCWA" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67C5iUNP2551850 for ; Wed, 12 Aug 2026 05:46:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k79W5VytlE22NwXQ2D0SB5fCnUEmPnGZW3S60sW/g/0=; b=PssAq2WZHZvQbKSB R8LhQy7O4XrTOn0ad7u8AGoD6sRKmfOpiTH6HT+wr60i815CSQCbqRFKZVER/CTe rC2b30QLsDTHedA0rTPzqfiRgR3Kepsk60Ju9t6kVrOcdenTuf+4JC7vh94G3cn9 GVhspJ3Xf8sAMeZSy5ZziOnVsnvhWujTMzf7AsFkj773CzXuqLhVO/S6vOk6FFn5 VUYYHc9aOdOVwsJ1LHVZzkm8Lc/q9fqn2cjo+d2MZftQKDivwcSpYlK+ZzNN9fXJ 09YzU0MH0fkCRTJ0IJao9IUInF1p5PlItXYxmthJKClF6iPG94LIWjIoEmGta5JZ 13xAKA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g08jrj8a3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 05:46:42 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38ce7fabf76so823717a91.2 for ; Tue, 11 Aug 2026 22:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786513602; x=1787118402; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=k79W5VytlE22NwXQ2D0SB5fCnUEmPnGZW3S60sW/g/0=; b=Lj9iqCWAPtyz7tiSBjwnb2L9RxDEgyIzP0XD608XKNAQ/Y2t2l3JV6+ZcnS+bI8nnZ Xu1Fhp/UksSpVkYgDc3BBFCvRJ605KseNefctO6zN+p1A5nh11NZCvKxXCjuU7dyr279 3S7WLGqDHSzHGpk+Y2TmyKEYghPTiGxc2dMOCyH1ozO0eyZSY2Nqe4XrfrY/KDDJx3PT HVWtkT5D7kIPF8GKbetgy4AfpM2i+Dk+yOPqRCyUr7t20F7A7+sGEPX7PPKpRUK7o4pp fqt3g4NmHcGVh2WI+CH07ZajzWALHeK+cwLXVA/gBd+WctldTQcgpsQ3DBP3nviR4zsB MYjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786513602; x=1787118402; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k79W5VytlE22NwXQ2D0SB5fCnUEmPnGZW3S60sW/g/0=; b=cU+mLifwXI9PrIb3XZxBUevLxVeGFdPWb2+/Hidz5oWtOsLNBFAXlMQPVusKRN/pio a5uHMJInBlIv/I8BZhs6XYiA1Ekxosvq2LPc3PvPAg7pxkJNHxGLzoNC1NeXxYeACfjA CF7frgFQkRm2QfGLOkrxCUjsOT9MDN7K43PUj2RN5JXJHZIF+fZpNNaZm4GgxfKmM7q+ 8y+p6ULD/IzfErx7TRtntQoiE0nqyoiVMXEgDDx7szCwgMJjXeufnGfnRWHpldq7nXWX TPGcQ7qWIwYO7ZsJgWrEv1ZriOHE4s8OltFB105UfD8C/njkybd3m76xHdF3fI3t9Ds2 7wqQ== X-Forwarded-Encrypted: i=1; AHgh+RrBE4yFYJMSw/881RMyvjLWoqArakuSHbvF5JrSNm/p/855hh7DFNz3uhmcost8M9tKuEsBGxjCbdWjyLA=@vger.kernel.org X-Gm-Message-State: AOJu0YwACYx/7NonStGuNwIjIlAcXgkD+xHrEzJc9p9EkdyCkhe+Nnf4 bPCyiuw1C4vHOp+4FEojK8kFhP2JeOlDshHjVU5CWnEqukEgNUE0aR9Rd9VvcG35JAAocLhIScj Ulafw33iay90dxOLIMqmb4cZjkQuUb28ZKR2QoIceMbo/Eo+32HgJbO6XUuleKKVa0Xk= X-Gm-Gg: AR+sD13lt55eVvNlm0XCTXG8tduvbThDaOopC60Of4C6Dt6+c8YB2O3+COZ1iwrT1R4 WotIw13qyz4iQEA0HDUgqnMzJzG6Eb1Vev5uZMCOaC8Zbviud5+ecvd+Q3yHybdcHa1TA2utMQ+ lMNlOZnySo7ywcOJD3GNpE8axjx3VZKigPmMmCbXDRZ9t/n9LQtqvkBmw0nQXZdhJAHxps+x8az xanKxh1G3OasoIYhCqk1A9Gx/HSBunjoDCzQrmZUYTgFITaFWowaBcv087JxdetBzhWuqA44wP3 GJit3SGPmoDj2EAi740mydW7eLqx+0P5YthYUBHMAC23X/s6r68iKJNn0xexXv3tZfkN7tuK5JI ACP0q4zpxKgJ7xH9JQJmb73Bf2acB2Vstug== X-Received: by 2002:a17:90b:3943:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-3930164d6f4mr2498724a91.14.1786513602146; Tue, 11 Aug 2026 22:46:42 -0700 (PDT) X-Received: by 2002:a17:90b:3943:b0:37f:ed7e:7e42 with SMTP id 98e67ed59e1d1-3930164d6f4mr2498676a91.14.1786513601574; Tue, 11 Aug 2026 22:46:41 -0700 (PDT) Received: from [10.217.219.92] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f8896c20sm2208498a91.1.2026.08.11.22.46.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2026 22:46:41 -0700 (PDT) Message-ID: <3aaecc8e-6f08-4e69-a24f-f97926fe7079@oss.qualcomm.com> Date: Wed, 12 Aug 2026 11:16:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] spi: qcom-geni: Add panic notifier to suspend controller during panic To: Praveen Talari , konrad.dybcio@oss.qualcomm.com, Mark Brown Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, chandana.chiluveru@oss.qualcomm.com References: <20260805-add-shutdown-and-panic-notifier-for-spi-v1-0-b5db170d491e@oss.qualcomm.com> <20260805-add-shutdown-and-panic-notifier-for-spi-v1-2-b5db170d491e@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260805-add-shutdown-and-panic-notifier-for-spi-v1-2-b5db170d491e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: LMX7VhEB-0G3xBViQ_sFriQoI23MWzMx X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDA0MyBTYWx0ZWRfX2juSw2u/YFQ8 zdVfIKqyQQdMVYB5ZawBApLd9KKIUBnrIWrod4Kfy6PJ6aStFOsF4ey+Ie7g9B71e5qlWlDB6kB rQjMHu6FUxiYAR5yb2aGxWbfXE0nFog= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDA0MyBTYWx0ZWRfX0Peo1Cf5HgTP QFd0SJP+h+sWYF0iVppO/8z5qW/8vudCKEESOtYChFyJEZmhOMPgJpw9tlERYfC2PA/+htrPNkW 3/nVCJMFj6lvKF4h+mlSEtK7TX8vqaogxtQXFqtT7/RN408XOFnLXU6n3AiWCXGmJvSOZ/lwgnm CEASjr62rFviAedwwGOTtyB45o5+rY207ekX0S613iRyy7VAzCG+GKV0J4y786lyrgqCVogCz59 YTL7YVv7OFKLm6PSdCfPEq8/BM/Ym1C7Csc/vn3K+Eltbc6GMYOOVwuK5fjPdSDregfP6mO2XYj 90HPoeF9RM82SdI4WR4+HdIAZsdqg8ZVy28WgU0yUl6rCSS5CiSGAkkBjran2wAXjGUF+RmY+9s djVoeRCgZHvU64vvkgbSBP165V/hxBWY2O0Fg/L40orDNMnhgsd5e+MlsaOioQLBiYHqaZS3tq7 ZfFVI9PdsfN7Y6wTn1g== X-Authority-Analysis: v=2.4 cv=Z7Dc2nRA c=1 sm=1 tr=0 ts=6a7c08c2 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=vaKURzcQWfWGSkE7xxoA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: LMX7VhEB-0G3xBViQ_sFriQoI23MWzMx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_01,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120043 On 8/5/2026 4:12 PM, Praveen Talari wrote: [...] > @@ -1073,6 +1075,23 @@ static void spi_geni_shutdown(struct platform_device *pdev) > spi_controller_suspend(spi); > } > > +static int spi_geni_panic_notifier(struct notifier_block *nb, > + unsigned long action, void *data) > +{ > + struct spi_geni_master *mas = container_of(nb, struct spi_geni_master, panic_nb); > + struct spi_controller *spi = dev_get_drvdata(mas->dev); > + > + spi_controller_suspend(spi); Add a line space before return > + return NOTIFY_OK; > +} > + > +static void spi_geni_unregister_notifiers(void *data) > +{ > + struct spi_geni_master *mas = data; > + > + atomic_notifier_chain_unregister(&panic_notifier_list, &mas->panic_nb); > +} > + > static int spi_geni_probe(struct platform_device *pdev) > { > int ret, irq; > @@ -1161,7 +1180,16 @@ static int spi_geni_probe(struct platform_device *pdev) > if (ret) > return ret; > > - return devm_spi_register_controller(dev, spi); > + ret = devm_spi_register_controller(dev, spi); > + if (ret) Can you add a trace log here and below where ever you get error ? Hope that will help in case of issue. > + return ret; > + > + mas->panic_nb.notifier_call = spi_geni_panic_notifier; > + ret = atomic_notifier_chain_register(&panic_notifier_list, &mas->panic_nb); > + if (ret) same here, add trace log > + return ret; > + > + return devm_add_action_or_reset(dev, spi_geni_unregister_notifiers, mas); > } > > static int __maybe_unused spi_geni_runtime_suspend(struct device *dev) >