From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089423B19D1 for ; Mon, 23 Mar 2026 14:15:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774275318; cv=none; b=B2l1U3bjpnVJkFU70ml9bHKxvHCKpXTh8OuNNb7bWeIhlztuybTCltDX6pD6Hq5mxWIK4XbDE6rahxORMr8Wf/DJ57qPNqC2z9e1sbIUCjEseHmf7FvUJr1L4G9GXHEcWjmgnsb6y0smY2wSb20s9tWm/21Fc0laDq8xKfu0a20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774275318; c=relaxed/simple; bh=3wO02rT+etgyYRSiGz/84U2TOiC/lwn2tjuSm0oKXC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AQzaGBVErhSBiGr1uFOAEXKkDKvokGT2yxfhe+WZCb6aUmfMn/Or22LWSH7dHJeOEnJm5REzyotDNcYq53I7oS0oRaXNIMZv7rFtVoIz1w6PsQktoBT/EGNVYgeGrG06rvnEbEeDQI6EVNMYwx8v9ySK5t6t3Mgtigf/00HLW3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ArHBTTTq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UEJWhl67; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ArHBTTTq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UEJWhl67" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ND7nGN2191933 for ; Mon, 23 Mar 2026 14:15:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nm8u98TStTS6sRtU+UYGkC/1U+l7JqkYetDAPw+MLaI=; b=ArHBTTTqRJvc1mHx FhuWefhP4ICYLOufDB1D2oWMRB49WvtWkBZhnujGPoxKFKUYw0ThuLbtuV+GXAXk KtByuGdosobzpq0+bpNJoVWe3XXFKlt0ttJxky1+8nWewhUX1zkzPIjK2MHqigtv Z8nxoeA80yfcj3MU984Huo5YrU0TJhrn1B4i3XR+J0xYvZvm78HeIVjrITvtyPeV Dffod1wIPTeWDGggtRaDF56PJLnzuMJG4XCKumlefUBxn5dJxwJmqwx171bcmzys 7siIOe5stiG0B3VoLbz4UhkACaBXJW6uG4EO15qQiSuuUMO7HTOCWPcbhMYtI7IM 52cE5Q== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d364jr95q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 14:15:16 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-60274569cf9so511387137.0 for ; Mon, 23 Mar 2026 07:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774275315; x=1774880115; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nm8u98TStTS6sRtU+UYGkC/1U+l7JqkYetDAPw+MLaI=; b=UEJWhl67SHM6pIPvMwG3M+uqj8wyFhB3FZtPJqomqCS4B3930TZ+vmsjjI1FXxe/vI 83nWfxCUl/6ENF5wbmKwE9MyictOfsyUP/L6pGAUXkwWtUMttbuzyANNElEUCYixapoU bKpdFce936TND1ckst4LPxyMuN3DYP+O6tFAkgpdgq3wjhn4Is8g25FywOQWlK76eYbf iQI9tMOGy7znAbs4ydjyuViObzdNY+f/NK9cCro/T2YiJ3xvQtxA5eWybF3Oj48q9NIR 9QxVx5mzGtCZisq/YiJhbOSo8EbJmkWvRB517AQad6VWaaX8bpSi8xdObZISP8E3pgon jsiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774275315; x=1774880115; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nm8u98TStTS6sRtU+UYGkC/1U+l7JqkYetDAPw+MLaI=; b=hYNSAdmhhwszXOJEPlTBW3ZpR0g3kRhc5aY7fzY9UQxLJwr6v0B1oAx8vFxL5cml3v vC75VuWRcqILC4BEq7J4bvpTUdZlxkxqZN2Ps1BJ9lQLLRU4pu8sFmiuULdGk/yZvmFx al+Ie8p2yCpGtH8MwwuwARUxAgKxYuGxCpXlGJtqZSKp1qf2A1xL/6q6nbvIXwg9S115 41a7TuF/O6/Wuha1xfY3dHJnB6ZOriAyk5Fk4kQW+w6Fr75F+X0292CMWvAbsSC+PMjC kMaZBxkWt+sTPv9yMHLJczXxFJYcd6en/wcxwYp5jGbvVKL56fHdMwFubNvzgs/xyIAQ YHfg== X-Forwarded-Encrypted: i=1; AJvYcCW191jqHFVf3rC6teLznLtQ4QWTd0XwZSuofMuaTqsLK+AUB8TqBN6WVdBvoOfp9EX+gQmlaDab3ar/AlI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4+uUc6uL4TyMX2gaQwhx0pquuz9Q/pHVrTlo6xc3RPC2/XQuB t9n6ZUY7Dospnk5G5U3PZ0OJSPa+DSbTJs/SGSaFaig4XVSr0M8Q7yvpN1Z8HP5lCspb2ELdgvl GPu7cDVpF5lVmLpFLXoWUVSoepuQ6tYqcTMUC6DEZdXTPbgCZP4TC9RCBJte05+RvMbo= X-Gm-Gg: ATEYQzzn3jnGn6VkKrUlSihVdMySZfFxLdkFkpTAY5LaJfQl4qQKa7j9/ZuxN14Xxs+ QWhZCmeZtj698R0FypJyaK/pDqdhdATVk1+9hjCMc1t2tpTHkUw69rZd1UXBo1DwaKYiYd3qNcR g64t0DuAjVc9rdJClKAxhiUUSE+Ei/jD/GM+hvU4PwYTIIe9h7UszBWCZfUl67g1VTgyLXa3/4s GfiH/gMcuVOxUjktFecOrzNIFQCSZ9cWwKOlrBFvwHjWCHpWyGJ/bs1XeoDhhO5rCQ1vH8pOtEI joo9oqCg+3pFGPWTbWAD8jLC3eg/QDDuGvctfDSPMcLz81hjqxzJ/Yd3XORh7aBWbHCF9KA5X6A 75SJA8QH/CYEgHmlqdgqL79Co6h4NWDxmaAwjCnNYPtew3Ts+cJB09ywwnZu1ZPfu2XNBYJRPG7 eISS4= X-Received: by 2002:a05:6102:3910:b0:5ff:9d74:9677 with SMTP id ada2fe7eead31-602aec08323mr2913990137.3.1774275313451; Mon, 23 Mar 2026 07:15:13 -0700 (PDT) X-Received: by 2002:a05:6102:3910:b0:5ff:9d74:9677 with SMTP id ada2fe7eead31-602aec08323mr2913972137.3.1774275312891; Mon, 23 Mar 2026 07:15:12 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335de1d6sm506417366b.30.2026.03.23.07.15.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 07:15:12 -0700 (PDT) Message-ID: <3aaf273a-c7da-4740-a68a-49f5d2f5309f@oss.qualcomm.com> Date: Mon, 23 Mar 2026 15:15:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay To: Monish Chunara , Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mani@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sarthak.garg@oss.qualcomm.com, pradeep.pragallapati@oss.qualcomm.com, nitin.rawat@oss.qualcomm.com References: <20260227105055.2364348-1-monish.chunara@oss.qualcomm.com> <20260227105055.2364348-3-monish.chunara@oss.qualcomm.com> <2ra2apfephjl2au6wel25gbxoxyvohf2ysq4yzaufp3xb7mtoi@g5p6asbk2fqe> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: c3Rn0dsHqdjxUqXxloeP5ATnvzptqH_d X-Proofpoint-ORIG-GUID: c3Rn0dsHqdjxUqXxloeP5ATnvzptqH_d X-Authority-Analysis: v=2.4 cv=JcaxbEKV c=1 sm=1 tr=0 ts=69c14af4 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=D5RQfsWzn7_MDrZrBkkA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDExMCBTYWx0ZWRfX/BBRrSVZPm8i /Bu94xejmEtUy0SIXlo/D2vi+O57zxs2WNe5ZG9SqTR0oISldwrUquFAMblGNUROFBGrV3dtJuX QbbMcA6dqQQsm2+bcRl2Z1NErcp1YUS9x0gr3Xw8yg0emLNfdYbM41+Yok7Gy1er0scu7okLrfy xzsNWzZv7eVEO4TK7948YbDq04dlsK+ecsllzf1y5t0meZNwKZZ7QKfP9cMAAtFZUaiT2eKUez6 EHPeG1lqLam27B4EnyjRrUgjt34ZYUENDrDGU9AC85mIRi3eSImfCZ8HDvnG5g1ZPhpf2IPzWG5 vPseQ5ykUR8+mQAfpgymIXcm4E/WMcG7TAyz3ZIcrPtFVLcnoLeuL76uAoSK8Q3zc6r/eaVADe6 UX97jPQ0gL5zQ8tSi+ze26nuFgjZMOmhOMMU+48JbvcLDrhEZTCU9bVXXNmpFGE4bgaCwqCrZPx G0mdXvk+5Tghc9wMcCw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230110 On 3/2/26 3:24 PM, Monish Chunara wrote: > On Fri, Feb 27, 2026 at 10:03:10PM +0200, Dmitry Baryshkov wrote: >> On Fri, Feb 27, 2026 at 04:20:54PM +0530, Monish Chunara wrote: >>> The monaco EVK board supports either eMMC or SD-card, but only one >>> can be active at a time. >>> >>> Enable the SD Host Controller Interface (SDHCI) on the monaco EVK board >>> to support SD Card for storage via a device tree overlay. This allows >>> eMMC support to be enabled through a separate overlay when required. >>> >>> Signed-off-by: Monish Chunara >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 4 ++ >>> .../boot/dts/qcom/monaco-evk-sd-card.dtso | 72 +++++++++++++++++++ >>> 2 files changed, 76 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index 317af937d038..c86242a1631d 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -46,6 +46,10 @@ lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo >>> dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-el2.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += milos-fairphone-fp6.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += monaco-evk.dtb >>> + >>> +monaco-evk-sd-card-dtbs := monaco-evk.dtb monaco-evk-sd-card.dtbo >>> +dtb-$(CONFIG_ARCH_QCOM) += monaco-evk-sd-card.dtb >>> + >>> dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso >>> new file mode 100644 >>> index 000000000000..a0bc5c47d40b >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso >>> @@ -0,0 +1,72 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >>> + */ >>> + >>> +/dts-v1/; >>> +/plugin/; >>> + >>> +#include >>> + >>> +/ { >>> + vmmc_sdc: regulator-dummy { >> >> No dummy regulators, please. > > ACK, these will be renamed as per the schematic. Since these are direct supplies > on hardware, used fixed-regulator configuration. > >> >>> + compatible = "regulator-fixed"; >>> + >>> + regulator-name = "vmmc_sdc"; >>> + regulator-min-microvolt = <2950000>; >>> + regulator-max-microvolt = <2950000>; >>> + }; >>> + >>> + vreg_sdc: regulator-sdc { >>> + compatible = "regulator-gpio"; >>> + >>> + regulator-name = "vreg_sdc"; >>> + regulator-type = "voltage"; >>> + regulator-min-microvolt = <1800000>; >>> + regulator-max-microvolt = <2950000>; >>> + >>> + gpios = <&expander1 7 GPIO_ACTIVE_HIGH>; >>> + states = <1800000 1>, <2950000 0>; >>> + >>> + startup-delay-us = <100>; >>> + }; >>> +}; >>> + >>> +&sdhc_1 { >>> + vmmc-supply = <&vmmc_sdc>; >>> + vqmmc-supply = <&vreg_sdc>; >>> + >>> + pinctrl-0 = <&sdc1_state_on>, <&sd_cd>; >>> + pinctrl-1 = <&sdc1_state_off>, <&sd_cd>; >>> + pinctrl-names = "default", "sleep"; >>> + >>> + cap-sd-highspeed; >>> + no-1-8-v; >>> + >>> + bus-width = <4>; >>> + cd-gpios = <&tlmm 11 GPIO_ACTIVE_LOW>; >>> + no-mmc; >>> + no-sdio; >>> + >>> + status = "okay"; >>> +}; >>> + >>> +&sdhc1_opp_table { >> >> Why? Is it specific to the device or to the chip? In the latter case, >> please define a separate table in the monaco.dtsi and switch to it here. >> > > As per the previous review, it was suggested to use an existing table. But yes, > this is specific to the Host controller and the corresponding voltage corners on > the chip and can be defined as a separate entity for SD card use-case. The SDC programming guide I have access to does not seem to have bene updated for any recent chips. Are you sure these different corners are *actually* valid? The clock-side documentation doesn't mention that Konrad