From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 834A1C43460 for ; Wed, 19 May 2021 08:21:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6079E6109F for ; Wed, 19 May 2021 08:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244958AbhESIXN (ORCPT ); Wed, 19 May 2021 04:23:13 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:3038 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241235AbhESIXL (ORCPT ); Wed, 19 May 2021 04:23:11 -0400 Received: from dggems706-chm.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FlQlB6DTzzmXG3; Wed, 19 May 2021 16:19:34 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 19 May 2021 16:21:50 +0800 Received: from [10.47.24.60] (10.47.24.60) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 19 May 2021 09:21:48 +0100 Subject: Re: [bug report] Memory leak from acpi_ev_install_space_handler() To: "Kaneda, Erik" , "Rafael J. Wysocki" CC: ACPI Devel Maling List , Len Brown , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , chenxiang References: <845f6ef8-d2a7-e491-8405-9526e4ba277a@huawei.com> <752f16ed-29e3-840e-dc53-6fed24d73861@huawei.com> From: John Garry Message-ID: <3ab18796-f8b5-9498-a31a-5dfd21059ebb@huawei.com> Date: Wed, 19 May 2021 09:20:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.24.60] X-ClientProxiedBy: lhreml705-chm.china.huawei.com (10.201.108.54) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/05/2021 22:48, Kaneda, Erik wrote: > Hi John, > >> I don't mind looking further if requested. > Someone else reported this as well. I noticed. By chance, it was my close colleague Xiang Chen. Could you try the patch below? I think it might help fix this issue.. It looks like the same problem, and you provided the same solution, so we can look to test it. Thanks > > Thanks, > Erik > > diff --git a/drivers/acpi/acpica/utdelete.c b/drivers/acpi/acpica/utdelete.c > index 624a26794d55..e5ba9795ec69 100644 > --- a/drivers/acpi/acpica/utdelete.c > +++ b/drivers/acpi/acpica/utdelete.c > @@ -285,6 +285,14 @@ static void acpi_ut_delete_internal_obj(union acpi_operand_object *object) > } > break; > > + case ACPI_TYPE_LOCAL_ADDRESS_HANDLER: > + > + ACPI_DEBUG_PRINT((ACPI_DB_ALLOCATIONS, > + "***** Address handler %p\n", object)); > + > + acpi_os_delete_mutex(object->address_space.context_mutex); > + break; > + > default: > > break; >