From: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, skhan@linuxfoundation.org,
dillon.varone@amd.com,
linux-kernel-mentees@lists.linuxfoundation.org,
dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com,
linux-kernel@vger.kernel.org, samson.tam@amd.com,
SyedSaaem.Rizvi@amd.com, aurabindo.pillai@amd.com,
stable@vger.kernel.org, daniel@ffwll.ch, george.shen@amd.com,
alexander.deucher@amd.com, Jun.Lei@amd.com, airlied@gmail.com,
christian.koenig@amd.com
Subject: Re: [PATCH] drm/amd/display: remove redundant check
Date: Tue, 31 Oct 2023 13:42:17 +0200 [thread overview]
Message-ID: <3ab58c1e48447798d7525e7d2f42f1a2@foxhound.fi> (raw)
In-Reply-To: <2023103115-obstruct-smudgy-6cc6@gregkh>
On 2023-10-31 07:48, Greg KH wrote:
> On Mon, Oct 30, 2023 at 07:17:48PM +0200, José Pekkarinen wrote:
>> This patch addresses the following warning spotted by
>> using coccinelle where the case checked does the same
>> than the else case.
>>
>> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
>> WARNING: possible condition with no effect (if == else)
>>
>> Fixes: 974ce181 ("drm/amd/display: Add check for PState change in
>> DCN32")
>>
>> Cc: stable@vger.kernel.org
>
> Why is this relevant for stable?
Hi,
I was asked to send it for stable because this code
looks different in amd-staging-drm-next, see here.
https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c#L4661
Feel free to let me know if this is wrong, or if I
need to review some other guidelines I may have missed.
Thanks!
José.
next prev parent reply other threads:[~2023-10-31 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 17:17 José Pekkarinen
2023-10-30 17:39 ` Aurabindo Pillai
2023-10-31 5:48 ` Greg KH
2023-10-31 11:42 ` José Pekkarinen [this message]
2023-10-31 12:20 ` Greg KH
2023-10-31 12:32 ` José Pekkarinen
2023-10-31 16:41 ` Aurabindo Pillai
-- strict thread matches above, loose matches on Subject: below --
2023-10-30 17:04 José Pekkarinen
2023-10-29 12:44 José Pekkarinen
2023-10-30 13:52 ` Aurabindo Pillai
2023-10-30 16:26 ` José Pekkarinen
2023-10-30 16:53 ` Aurabindo Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ab58c1e48447798d7525e7d2f42f1a2@foxhound.fi \
--to=jose.pekkarinen@foxhound.fi \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=SyedSaaem.Rizvi@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dillon.varone@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.shen@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samson.tam@amd.com \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®