From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158AbcHAUOJ (ORCPT ); Mon, 1 Aug 2016 16:14:09 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:36360 "EHLO mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754944AbcHAUNw (ORCPT ); Mon, 1 Aug 2016 16:13:52 -0400 Reply-To: ahs3@redhat.com Subject: Re: [PATCH v5] Force cppc_cpufreq to report values in KHz to fix user space reporting References: <1469049004-19069-1-git-send-email-ahs3@redhat.com> To: viresh.kumar@linaro.org, ashwin.chaugule@linaro.org, rjw@rjwysocki.net Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Prashanth Prakash From: Al Stone Organization: Red Hat, Inc. Message-ID: <3ab83afa-1c91-4dcc-9206-a7a6dc3cfe83@redhat.com> Date: Mon, 1 Aug 2016 14:07:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1469049004-19069-1-git-send-email-ahs3@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/20/2016 03:10 PM, Al Stone wrote: > When CPPC is being used by ACPI on arm64, user space tools such as > cpupower report CPU frequency values from sysfs that are incorrect. > > What the driver was doing was reporting the values given by ACPI tables > in whatever scale was used to provide them. However, the ACPI spec > defines the CPPC values as unitless abstract numbers. Internal kernel > structures such as struct perf_cap, in contrast, expect these values > to be in KHz. When these struct values get reported via sysfs, the > user space tools also assume they are in KHz, causing them to report > incorrect values (for example, reporting a CPU frequency of 1MHz when > it should be 1.8GHz). > [snip...] Ping? If anyone has sent comments, I have not received them. Thanks in advance for the time and effort. I know merge window can be a very busy time. -- ciao, al ----------------------------------- Al Stone Software Engineer Red Hat, Inc. ahs3@redhat.com -----------------------------------