mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] dma-buf: fix some kernel-doc warnings
Date: Mon, 31 Aug 2026 11:01:31 +0200	[thread overview]
Message-ID: <3abb966d-6a9a-4c00-9c51-687c8601fa5c@amd.com> (raw)
In-Reply-To: <20260831031956.3410813-1-rdunlap@infradead.org>

On 8/31/26 05:19, Randy Dunlap wrote:
> - drop Excess description of @lock from kernel-doc
> - add missing function/macro short descriptions
> 
> WARNING: include/linux/dma-fence-array.h:47 Excess struct member 'lock' description in 'dma_fence_array'
> WARNING: include/linux/dma-fence-chain.h:48 Excess struct member 'lock' description in 'dma_fence_chain'
> Warning: include/linux/dma-fence-chain.h:82 missing initial short description on line:
>  * dma_fence_chain_alloc
> Warning: include/linux/dma-fence-chain.h:94 missing initial short description on line:
>  * dma_fence_chain_free
> 
> Fixes: 5943243914b9 ("dma-buf: use inline lock for the dma-fence-array")
> Fixes: a408c0ca0c41 ("dma-buf: use inline lock for the dma-fence-chain")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed and pushed to drm-misc-fixes.

Thanks,
Christian.

> ---
> v2: rebase & resend; add Andrew to Cc: list
> 
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: linux-media@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Christian König <christian.koenig@amd.com>
> Cc: stable@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> 
>  include/linux/dma-fence-array.h |    1 -
>  include/linux/dma-fence-chain.h |    9 ++++-----
>  2 files changed, 4 insertions(+), 6 deletions(-)
> 
> --- linux-next-20260828.orig/include/linux/dma-fence-array.h
> +++ linux-next-20260828/include/linux/dma-fence-array.h
> @@ -28,7 +28,6 @@ struct dma_fence_array_cb {
>  /**
>   * struct dma_fence_array - fence to represent an array of fences
>   * @base: fence base class
> - * @lock: spinlock for fence handling
>   * @num_fences: number of fences in the array
>   * @num_pending: fences in the array still pending
>   * @fences: array of the fences
> --- linux-next-20260828.orig/include/linux/dma-fence-chain.h
> +++ linux-next-20260828/include/linux/dma-fence-chain.h
> @@ -20,7 +20,6 @@
>   * @prev: previous fence of the chain
>   * @prev_seqno: original previous seqno before garbage collection
>   * @fence: encapsulated fence
> - * @lock: spinlock for fence handling
>   */
>  struct dma_fence_chain {
>  	struct dma_fence base;
> @@ -81,9 +80,8 @@ dma_fence_chain_contained(struct dma_fen
>  }
>  
>  /**
> - * dma_fence_chain_alloc
> - *
> - * Returns a new struct dma_fence_chain object or NULL on failure.
> + * dma_fence_chain_alloc - Returns a new &struct dma_fence_chain object or
> + * %NULL on failure.
>   *
>   * This specialized allocator has to be a macro for its allocations to be
>   * accounted separately (to have a separate alloc_tag). The typecast is
> @@ -93,7 +91,8 @@ dma_fence_chain_contained(struct dma_fen
>  		kmalloc_obj(struct dma_fence_chain)
>  
>  /**
> - * dma_fence_chain_free
> + * dma_fence_chain_free - Frees an allocated but not used
> + * &struct dma_fence_chain object.
>   * @chain: chain node to free
>   *
>   * Frees up an allocated but not used struct dma_fence_chain object. This


      reply	other threads:[~2026-08-31  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  3:19 Randy Dunlap
2026-08-31  9:01 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3abb966d-6a9a-4c00-9c51-687c8601fa5c@amd.com \
    --to=christian.koenig@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®