From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>, linux-kernel@vger.kernel.org
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, x86@kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] xen/pv: Call get_cpu_address_sizes to set x86_virt/phys_bits
Date: Tue, 24 Jul 2018 10:08:19 -0400 [thread overview]
Message-ID: <3ac07f7d-19f3-923f-57c4-a12c605ff6ad@oracle.com> (raw)
In-Reply-To: <20180724124547.32562-1-m.v.b@runbox.com>
On 07/24/2018 08:45 AM, M. Vefa Bicakci wrote:
> Commit d94a155c59c9 ("x86/cpu: Prevent cpuinfo_x86::x86_phys_bits
> adjustment corruption") has moved the query and calculation of the
> x86_virt_bits and x86_phys_bits fields of the cpuinfo_x86 struct
> from the get_cpu_cap function to a new function named
> get_cpu_address_sizes.
>
> One of the call sites related to Xen PV VMs was unfortunately missed
> in the aforementioned commit. This prevents successful boot-up of
> kernel versions 4.17 and up in Xen PV VMs if CONFIG_DEBUG_VIRTUAL
> is enabled, due to the following code path:
>
> enlighten_pv.c::xen_start_kernel
> mmu_pv.c::xen_reserve_special_pages
> page.h::__pa
> physaddr.c::__phys_addr
> physaddr.h::phys_addr_valid
>
> phys_addr_valid uses boot_cpu_data.x86_phys_bits to validate physical
> addresses. boot_cpu_data.x86_phys_bits is no longer populated before
> the call to xen_reserve_special_pages due to the aforementioned commit
> though, so the validation performed by phys_addr_valid fails, which
> causes __phys_addr to trigger a BUG, preventing boot-up.
>
> Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: xen-devel@lists.xenproject.org
> Cc: x86@kernel.org
> Cc: stable@vger.kernel.org # for v4.17 and up
> Fixes: d94a155c59c9 ("x86/cpu: Prevent cpuinfo_x86::x86_phys_bits adjustment corruption")
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2018-07-24 14:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 19:49 [PATCH 1/2] x86/entry/64: Do not clear %rbx under Xen M. Vefa Bicakci
2018-07-21 19:49 ` [PATCH 2/2] xen/pv: Call get_cpu_address_sizes to set x86_virt/phys_bits M. Vefa Bicakci
2018-07-21 21:25 ` Boris Ostrovsky
2018-07-21 23:17 ` M. Vefa Bicakci
2018-07-22 15:57 ` M. Vefa Bicakci
2018-07-23 15:04 ` Boris Ostrovsky
2018-07-24 12:42 ` M. Vefa Bicakci
2018-07-24 12:45 ` [PATCH v2] " M. Vefa Bicakci
2018-07-24 14:08 ` Boris Ostrovsky [this message]
2018-07-26 3:56 ` [PATCH v3] " M. Vefa Bicakci
2018-08-06 20:15 ` [PATCH v2] " Boris Ostrovsky
2018-08-06 20:16 ` Thomas Gleixner
2018-08-06 21:27 ` Boris Ostrovsky
2018-08-07 9:50 ` Ingo Molnar
2018-07-21 21:19 ` [PATCH 1/2] x86/entry/64: Do not clear %rbx under Xen Boris Ostrovsky
2018-07-21 23:18 ` M. Vefa Bicakci
2018-07-23 14:56 ` Boris Ostrovsky
2018-07-21 21:45 ` Andy Lutomirski
2018-07-21 23:19 ` M. Vefa Bicakci
2018-07-21 23:30 ` Andy Lutomirski
2018-07-21 23:37 ` M. Vefa Bicakci
2018-07-22 1:20 ` M. Vefa Bicakci
2018-07-22 17:56 ` Andy Lutomirski
2018-07-22 18:32 ` [Xen-devel] " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac07f7d-19f3-923f-57c4-a12c605ff6ad@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=m.v.b@runbox.com \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®