From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
<linux-mtd@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: atmel: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 11:51:46 +0200 [thread overview]
Message-ID: <3ac919ad-be84-f050-a7d1-c15c8c06217e@microchip.com> (raw)
In-Reply-To: <20210901074031.8883-1-caihuoqing@baidu.com>
On 01/09/2021 at 09:40, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/mtd/nand/raw/atmel/pmecc.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/atmel/pmecc.c b/drivers/mtd/nand/raw/atmel/pmecc.c
> index cbb023bf00f7..498e41ccabbd 100644
> --- a/drivers/mtd/nand/raw/atmel/pmecc.c
> +++ b/drivers/mtd/nand/raw/atmel/pmecc.c
> @@ -834,7 +834,6 @@ static struct atmel_pmecc *atmel_pmecc_create(struct platform_device *pdev,
> {
> struct device *dev = &pdev->dev;
> struct atmel_pmecc *pmecc;
> - struct resource *res;
>
> pmecc = devm_kzalloc(dev, sizeof(*pmecc), GFP_KERNEL);
> if (!pmecc)
> @@ -844,13 +843,11 @@ static struct atmel_pmecc *atmel_pmecc_create(struct platform_device *pdev,
> pmecc->dev = dev;
> mutex_init(&pmecc->lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, pmecc_res_idx);
> - pmecc->regs.base = devm_ioremap_resource(dev, res);
> + pmecc->regs.base = devm_platform_ioremap_resource(pdev, pmecc_res_idx);
> if (IS_ERR(pmecc->regs.base))
> return ERR_CAST(pmecc->regs.base);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, errloc_res_idx);
> - pmecc->regs.errloc = devm_ioremap_resource(dev, res);
> + pmecc->regs.errloc = devm_platform_ioremap_resource(pdev, errloc_res_idx);
> if (IS_ERR(pmecc->regs.errloc))
> return ERR_CAST(pmecc->regs.errloc);
>
> --
> 2.25.1
>
--
Nicolas Ferre
next prev parent reply other threads:[~2021-09-01 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 7:40 Cai Huoqing
2021-09-01 9:51 ` Nicolas Ferre [this message]
2021-09-14 17:40 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac919ad-be84-f050-a7d1-c15c8c06217e@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=caihuoqing@baidu.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®