Re: [PATCH v2 5/9] dt-bindings: media: Add amlogic,c3-isp.yaml

[Keke Li <keke.li@amlogic.com>]

Hi Krzysztof,

         Thanks for your reply.

On 2024/9/9 18:15, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Mon, Sep 09, 2024 at 03:24:15PM +0800, Keke Li wrote:
>> c3-isp is used to process raw image.
>>
>> Signed-off-by: Keke Li <keke.li@amlogic.com>
>> ---
>>   .../devicetree/bindings/media/amlogic,c3-isp.yaml  | 98 ++++++++++++++++++++++
>>   1 file changed, 98 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
>> new file mode 100644
>> index 000000000000..dfa439cdc380
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
>> @@ -0,0 +1,98 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/amlogic,c3-isp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic C3 Image Signal Processing Unit
>> +
>> +maintainers:
>> +  - Keke Li <keke.li@amlogic.com>
>> +
>> +description:
>> +  Amlogic ISP is the RAW image processing module
>> +  and supports three channels image output.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - amlogic,c3-isp
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  reg-names:
>> +    items:
>> +      - const: isp
>> +
>> +  power-domains:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 2
>> +
>> +  clock-names:
>> +    items:
>> +      - const: vapb
>> +      - const: isp0
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +
> Only one port? Then use "port" instead of "ports".

Yes, it has only one port.

I will use "port" instead of "ports".

Thanks again.

>
> Best regards,
> Krzysztof
>