From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2]: perf util: map data buffer for preserving collected data
Date: Tue, 4 Sep 2018 20:50:28 +0300 [thread overview]
Message-ID: <3ac920f7-d8b1-fb90-ab6b-ba75bc8b5b2a@linux.intel.com> (raw)
In-Reply-To: <20180904173431.GJ27886@tassilo.jf.intel.com>
Hi,
On 04.09.2018 20:34, Andi Kleen wrote:
>> .sample = process_sample_event,
>> @@ -1678,6 +1680,8 @@ static struct option __record_options[] = {
>> "signal"),
>> OPT_BOOLEAN(0, "dry-run", &dry_run,
>> "Parse options then exit"),
>> + OPT_INTEGER(0, "aio", &record.opts.nr_cblocks,
>> + "asynchronous trace write operations (min: 1, max: 32, default: 2)"),
>
> would need to be documented in the manpage. But I would rather make it an
> ~/.perfconfig option
Yep, make sense, it requires to be configurable w/o recompilation and
at the same time its meaning is not obvious to be on the command line for a user.
>
>
> -Andi
>
next prev parent reply other threads:[~2018-09-04 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <01963930-68b3-ff33-6e05-acaff3efc083@linux.intel.com>
2018-09-04 11:56 ` Alexey Budankov
2018-09-04 17:34 ` Andi Kleen
2018-09-04 17:50 ` Alexey Budankov [this message]
2018-09-04 11:58 ` [PATCH v6 2/2]: perf record: enable asynchronous trace writing Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac920f7-d8b1-fb90-ab6b-ba75bc8b5b2a@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome