From: Yunsheng Lin <linyunsheng@huawei.com>
To: Alexander H Duyck <alexander.duyck@gmail.com>,
<davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH net-next v9 02/13] mm: move the page fragment allocator from page_alloc into its own file
Date: Tue, 2 Jul 2024 20:27:51 +0800 [thread overview]
Message-ID: <3ac9d5ef-50a4-286d-eeec-a8d9a846278f@huawei.com> (raw)
In-Reply-To: <86c56c9a88d07efbfe1e85bec678e86704588a15.camel@gmail.com>
On 2024/7/2 7:10, Alexander H Duyck wrote:
> On Tue, 2024-06-25 at 21:52 +0800, Yunsheng Lin wrote:
>> Inspired by [1], move the page fragment allocator from page_alloc
>> into its own c file and header file, as we are about to make more
>> change for it to replace another page_frag implementation in
>> sock.c
>>
>> 1. https://lore.kernel.org/all/20230411160902.4134381-3-dhowells@redhat.com/
>>
>> CC: David Howells <dhowells@redhat.com>
>> CC: Alexander Duyck <alexander.duyck@gmail.com>
>> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
>
> So one thing that I think might have been overlooked in the previous
> reviews is the fact that the headers weren't necessarily self
> sufficient. You were introducing dependencies that had to be fulfilled
> by other headers.
>
> One thing you might try doing as part of your testing would be to add a
> C file that just adds your header and calls your functions to verify
> that there aren't any unincluded dependencies.
Sure, will do.
>
next prev parent reply other threads:[~2024-07-02 12:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 13:52 [PATCH net-next v9 00/13] First try to replace page_frag with page_frag_cache Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 01/13] mm: page_frag: add a test module for page_frag Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 02/13] mm: move the page fragment allocator from page_alloc into its own file Yunsheng Lin
2024-07-01 23:10 ` Alexander H Duyck
2024-07-02 12:27 ` Yunsheng Lin [this message]
2024-06-25 13:52 ` [PATCH net-next v9 03/13] mm: page_frag: use initial zero offset for page_frag_alloc_align() Yunsheng Lin
2024-07-01 23:27 ` Alexander H Duyck
2024-07-02 12:28 ` Yunsheng Lin
2024-07-02 16:00 ` Alexander Duyck
2024-07-03 11:25 ` Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 04/13] mm: page_frag: add '_va' suffix to page_frag API Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 05/13] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 06/13] mm: page_frag: reuse existing space for 'size' and 'pfmemalloc' Yunsheng Lin
2024-07-02 0:08 ` Alexander H Duyck
2024-07-02 12:35 ` Yunsheng Lin
2024-07-02 14:55 ` Alexander H Duyck
2024-07-03 12:33 ` Yunsheng Lin
2024-07-10 15:28 ` Alexander H Duyck
2024-07-11 8:16 ` Yunsheng Lin
2024-07-11 16:49 ` Alexander Duyck
2024-07-12 8:42 ` Yunsheng Lin
2024-07-12 16:55 ` Alexander Duyck
2024-07-13 5:20 ` Yunsheng Lin
2024-07-13 16:55 ` Alexander Duyck
2024-07-14 4:52 ` Yunsheng Lin
2024-07-15 17:55 ` Alexander Duyck
2024-07-16 12:58 ` Yunsheng Lin
2024-07-17 12:31 ` Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 07/13] mm: page_frag: some minor refactoring before adding new API Yunsheng Lin
2024-07-02 15:30 ` Alexander H Duyck
2024-07-03 12:36 ` Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 08/13] mm: page_frag: use __alloc_pages() to replace alloc_pages_node() Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 09/13] net: introduce the skb_copy_to_va_nocache() helper Yunsheng Lin
2024-07-02 15:52 ` Alexander H Duyck
2024-07-03 12:36 ` Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 10/13] mm: page_frag: introduce prepare/probe/commit API Yunsheng Lin
2024-06-28 22:35 ` Alexander H Duyck
2024-06-29 11:15 ` Yunsheng Lin
2024-06-29 17:37 ` Alexander Duyck
2024-06-30 14:05 ` Yunsheng Lin
2024-06-30 14:35 ` Alexander Duyck
2024-06-30 15:05 ` Yunsheng Lin
2024-07-03 12:40 ` Yunsheng Lin
2024-07-07 17:12 ` Alexander Duyck
2024-07-08 10:58 ` Yunsheng Lin
2024-07-08 14:30 ` Alexander Duyck
2024-07-09 6:57 ` Yunsheng Lin
2024-07-09 13:40 ` Alexander Duyck
2024-06-25 13:52 ` [PATCH net-next v9 11/13] net: replace page_frag with page_frag_cache Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 12/13] mm: page_frag: update documentation for page_frag Yunsheng Lin
2024-06-25 13:52 ` [PATCH net-next v9 13/13] mm: page_frag: add a entry in MAINTAINERS " Yunsheng Lin
2024-06-25 23:27 ` [PATCH net-next v9 00/13] First try to replace page_frag with page_frag_cache Jakub Kicinski
2024-06-25 23:41 ` Alexander Duyck
2024-06-26 12:16 ` Yunsheng Lin
2024-06-26 17:12 ` Andrew Lunn
2024-06-27 11:16 ` Yunsheng Lin
2024-06-27 19:58 ` Jakub Kicinski
2024-06-29 11:14 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ac9d5ef-50a4-286d-eeec-a8d9a846278f@huawei.com \
--to=linyunsheng@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®