From: Markus Elfring <Markus.Elfring@web.de>
To: Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Clayton Rayment <clayton.rayment@xilinx.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Paolo Abeni <pabeni@redhat.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write()
Date: Sun, 22 Sep 2024 19:55:13 +0200 [thread overview]
Message-ID: <3aca8eab-f4d2-4474-acc9-c5c94dcb9162@web.de> (raw)
In-Reply-To: <20240922170507.GD3426578@kernel.org>
>> Add a label so that a bit of exception handling can be better reused
>> at the end of this function implementation.
…
> This change seems reasonable to me.
Thanks for this positive feedback.
> However, I am assuming that as a
> non-bug-fix,
Would you like to categorise my update suggestion as a correction for
a coding style issue?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11#n526
> this is targeted at net-next. And net-next is currently
> closed for the v6.12 merge window. Please consider reposting this patch
> once net-next reopens.
Will a patch resend really be needed for the proposed adjustment?
Can both development branches benefit from this refactoring?
Regards,
Markus
prev parent reply other threads:[~2024-09-22 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 11:01 Markus Elfring
2024-09-22 17:05 ` Simon Horman
2024-09-22 17:55 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aca8eab-f4d2-4474-acc9-c5c94dcb9162@web.de \
--to=markus.elfring@web.de \
--cc=clayton.rayment@xilinx.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®