mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: alexandre.ferrieux@orange.com
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Chengen Du <chengen.du@canonical.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] af_packet: Handle outgoing VLAN packets without hardware offloading
Date: Sat, 25 May 2024 22:55:59 +0200	[thread overview]
Message-ID: <3acef339-cdeb-407c-b643-0481bfbe3c80@orange.com> (raw)
In-Reply-To: <66520906120ae_215a8029466@willemb.c.googlers.com.notmuch>

On 25/05/2024 17:51, Willem de Bruijn wrote:
> 
> First, we need to even understand better why anything is using
> SOCK_DGRAM when access to L2.5 headers is important, and whether the
> process can convert to using SOCK_RAW instead.

For libpcap, it seems to be linked to the fact that the "any" device can 
aggregate links with varied L2 header sizes, which in turn complicates filtering 
(see Guy Harris' comment on this [1]).

Given that 99% of useful traffic is Ethernet, such considerations look awkward 
now. I for one would love to see an "any2" based on SOCK_RAW. And while you're 
at it, please let the new variant of SLL contain the full Ethernet header at the 
end, so that a simple offset gives access to the whole linear wire image...

-Alex

[1] https://github.com/the-tcpdump-group/libpcap/issues/1105#issuecomment-1092221785
____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

  reply	other threads:[~2024-05-25 20:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20  7:03 Chengen Du
2024-05-20 18:35 ` Willem de Bruijn
2024-05-21  3:31   ` Chengen Du
2024-05-21  8:35     ` Paolo Abeni
2024-05-21 13:28       ` Willem de Bruijn
2024-05-22 14:27         ` Chengen Du
2024-05-22 18:39           ` Willem de Bruijn
2024-05-22 19:54             ` alexandre.ferrieux
2024-05-23 14:17               ` Chengen Du
2024-05-23 14:52                 ` Willem de Bruijn
2024-05-23 14:56 ` Willem de Bruijn
2024-05-24 14:04   ` Chengen Du
2024-05-25 15:51     ` Willem de Bruijn
2024-05-25 20:55       ` alexandre.ferrieux [this message]
2024-05-26 15:25         ` Willem de Bruijn
2024-05-27  0:18           ` alexandre.ferrieux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3acef339-cdeb-407c-b643-0481bfbe3c80@orange.com \
    --to=alexandre.ferrieux@orange.com \
    --cc=chengen.du@canonical.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®