Re: [PATCH v4 1/3] dt-bindings: iio: adc: Convert xilinx-xadc bindings to YAML schema

["Nagavarapu, Dileep Kumar" <dnagavar@amd.com>]

Hi Pramod,

On 5/18/2026 3:07 PM, Michal Simek wrote:
> 
> 
> On 5/16/26 13:18, Jonathan Cameron wrote:
>> On Fri, 15 May 2026 03:57:34 -0400
>> Pramod Maurya <pramod.nexgen@gmail.com> wrote:
>>
>>> Convert the Xilinx XADC and UltraScale System Monitor device tree 
>>> binding
>>> from the legacy plain-text format to a YAML schema, enabling automated
>>> validation with dt-schema.
>>>
>>> The new binding covers the same hardware and compatible strings:
>>>    - xlnx,zynq-xadc-1.00.a (ZYNQ hardmacro)
>>>    - xlnx,axi-xadc-1.00.a  (AXI softmacro)
>>>    - xlnx,system-management-wiz-1.3 (UltraScale System Management 
>>> Wizard)
>>>
>>> The xlnx,channels subnode retains its legacy name (including the comma)
>>> for backwards compatibility with existing device trees.
>>>
>>> Place xlnx,channels under properties: now that dt-schema PR#195 allows
>>> comma-containing nodenames for long-established bindings. Fix reg
>>> constraints inside channel subnodes to use maxItems and an items block
>>> rather than bare minimum/maximum keywords which are silently ignored on
>>> array types. Remove the redundant type: boolean from xlnx,bipolar since
>>> the $ref to /schemas/types.yaml#/definitions/flag already implies it.
>>>
>>> Signed-off-by: Pramod Maurya <pramod.nexgen@gmail.com>
>>
>> Various folk +CC, questions for them inline!
>>
>> A few comments from me.  Whilst the original was 'example rich' I don't
>> see a need for more than one in the yaml.
>>
>>> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml 
>>> b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
>>> new file mode 100644
>>> index 000000000000..06a0ce498352
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,xadc.yaml
>>> @@ -0,0 +1,210 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/iio/adc/xlnx,xadc.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Xilinx XADC and UltraScale System Monitor
>>> +
>>> +maintainers:
>>> +  - Lars-Peter Clausen <lars@metafoo.de>
>>
>> I'd like a confirmation tag from Lars that he is still happy 
>> maintaining this.
>> If not Pramod, would you be willing to step up?
>>
>> Maybe one of the AMD/Xilinx folk?
>>
>> Please +CC Salih, Michal and Conall on future versions..
>> (done on this reply).
>>
>> AMD folk, given you currently have a series (including bindings) for 
>> the newer
>> similar IP, would someone mind reviewing this?
> 
> Keep me in CC and I will make sure that series is reviewed.
> 

As there is no further activity on this thread, we would like to take 
this forward by addressing the review comments and posting the next 
version of XADC YAML binding as a standalone patch, while retaining the 
original authorship.
Please let us know if you have any reservations. Otherwise, we plan to 
send the updated patch by the end of this week.

Thanks,
Dileep

> Thanks,
> Michal