From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11DE22B8BD for ; Thu, 23 Oct 2025 20:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761252898; cv=none; b=aLsfcybnhJt7cr3ygTZsFLWxUy9KObvbyImcHhpJZgBUv3084r2ejv3jaTFwtVrWKz4YR9HJ94bBqD8kNA4XXIkGQ+Ue8t8Fe5m8QJBCfeNhAGLC9ENfgxpvf26sRWTMFTHRlUBokYhNgyR9XR9wu62H8V1jtm+rAWuFCIYbWec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761252898; c=relaxed/simple; bh=3zcWNMysNlD++tky2PpacIUVZRP34xDTCqHXuVWOnNk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eFFKHLtulaZpIFSgH/JP31Or+XvzInrOdzBGXQNE7Mh13Fwfjgh4lLVsUfR5xLiZiUFYa8AqYfsYQTLRgVXY861HwR1LnOH8jyPjatVzsJA55r8gfG6aDUWkG8E8LVXOmRgEnX09mbhAp6GBcI1f6Ix6oT0Pg4fo2cn42XRzjTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K6M5HgBC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K6M5HgBC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761252894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=msiKVYWHSQdItrL939R34SZBheamSPWIMDRxwGKcY7Y=; b=K6M5HgBC8HxPH6ygqt9bS70FcXHB2r7xyVuC6AuHsnXqpRrmNGk4T7ms+UtRCDpPB5FjM6 b2AHM5EbwVFyBG45rJ+SjU4su/UF8VhRPn5/rZw2/rOpcpSrnD4VGBo189/G3lHHAAGDRs W9pptwZTfvfOK4+xW9YHKPaIyIhZ138= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-Z2vJ3pc9NheEhPQtzFokhQ-1; Thu, 23 Oct 2025 16:54:53 -0400 X-MC-Unique: Z2vJ3pc9NheEhPQtzFokhQ-1 X-Mimecast-MFC-AGG-ID: Z2vJ3pc9NheEhPQtzFokhQ_1761252892 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-40cfb98eddbso1350755f8f.0 for ; Thu, 23 Oct 2025 13:54:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761252892; x=1761857692; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=msiKVYWHSQdItrL939R34SZBheamSPWIMDRxwGKcY7Y=; b=R00lmX5D88arNAKSejz1is0IuOy7UF5yQUCL2DgruxGFMCpxxzi41HdS1ozKf/qsTX sm314VUqvkI5yRa+CRDB5qPJbOoK/bglmHP1X/L7ziX1ulbYk7V99WFqRDDgy3bxLB73 1SqlxvO7RlLnOtVqqlAUQNUaUBobzGsKt8reeLd5mA5Bp9gwmmB/C3uD3QVnMUoZ+JLa lmGJW48dpNGh+jVN7bSvMFPEIQfnHLojoKOG+VruR9Xkc2AYL/alYqGTWeXtOrxwykoD YpkHMiiKhy9zBj0JCMqWDB24YPzIdWToObaJut0NU28zRdT27qMezF3Ssi2mMXzzPzjO c5Aw== X-Forwarded-Encrypted: i=1; AJvYcCX/Dly1dyMmzHScrHDOUbX8/QvetD/ODIPnGbelCILaFvQsvhQk+VgosI5yfoXcOiMDNRG/Dbmy4KdfK44=@vger.kernel.org X-Gm-Message-State: AOJu0YxzN/bTpDVUJpyNP/GlvCpuga306MBUayws+2ZOS2YccIPmToDs gJUtoAkWNbFhwvcOEjCq6/epf3okUOrlgmHC6+bf+bvrdMi34fCnD0Zc0cvURtIKODfWcEZTAOW 7+YrO4Pgj8bn84to0ufxlqR/zFoy5jnbsCVcc7wrya9rU0nw6GSxNJGa1snphqTFMCw== X-Gm-Gg: ASbGncuQY19TQNM6iyEMPHmRGhOPTQH5Wc18Ouln07ipJkajYeqTTMDXJYZ8abrt3w+ 37nfTQNFx3eZM2TLu2Z8MyNbSesO1ibNBOSXwNaLr3dOU4x3wNd22A6VWhdVoQl2CE2/UtBLV+P +VSv+L4SsaI2vMy6t57GL6QkTUyZKAnwo7fTTqvFbcVR9sswlmWRjCHM+pEZU/IL26EmLOxtO+N 0ibJjLkw16Wakob6Dv2NtSTZROZfkvy0jG12I4wYnj8NLHGifDauMiCme6Sw6SDjw1SrjxgeF7K jHacpgC5V8DcM2veGGF8obbgwikHwynufWQzT7pD10RFBQfDs3nfLb+nfZzpTuDw8MEK8enj54U k7j1tz4o2xFMwWKD/CZ0+P+Nba5seG+WReXO0W/08wEBtQzgKnrogBcOcnsdHI1Bxnkb/XUKOxo HzfFxG55j5UjJProUhT9t3GYAhQ54= X-Received: by 2002:a05:6000:1ac9:b0:426:f9d3:2feb with SMTP id ffacd0b85a97d-4298f5768b9mr202872f8f.23.1761252892168; Thu, 23 Oct 2025 13:54:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6P6cDPePEsuTJGDLHUKhovQrQ2mHJ56yA+geqOPGhrDw50Ig/1srvbHRTrnAUVormPLFpaQ== X-Received: by 2002:a05:6000:1ac9:b0:426:f9d3:2feb with SMTP id ffacd0b85a97d-4298f5768b9mr202848f8f.23.1761252891707; Thu, 23 Oct 2025 13:54:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4298b9963ccsm4026621f8f.7.2025.10.23.13.54.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 13:54:51 -0700 (PDT) Message-ID: <3ad31422-81c7-47f2-ae3e-e6bc1df402ee@redhat.com> Date: Thu, 23 Oct 2025 22:54:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 1/2] mm/memory: Do not populate page table entries beyond i_size To: Andrew Morton , Kiryl Shutsemau Cc: Hugh Dickins , Matthew Wilcox , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Johannes Weiner , Shakeel Butt , Baolin Wang , "Darrick J. Wong" , Dave Chinner , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Kiryl Shutsemau References: <20251023093251.54146-1-kirill@shutemov.name> <20251023093251.54146-2-kirill@shutemov.name> <20251023134929.b72ab75a8c132a17ae68a582@linux-foundation.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251023134929.b72ab75a8c132a17ae68a582@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.10.25 22:49, Andrew Morton wrote: > On Thu, 23 Oct 2025 10:32:50 +0100 Kiryl Shutsemau wrote: > >> From: Kiryl Shutsemau >> >> Accesses within VMA, but beyond i_size rounded up to PAGE_SIZE are >> supposed to generate SIGBUS. >> >> Recent changes attempted to fault in full folio where possible. They did >> not respect i_size, which led to populating PTEs beyond i_size and >> breaking SIGBUS semantics. >> >> Darrick reported generic/749 breakage because of this. >> >> However, the problem existed before the recent changes. With huge=always >> tmpfs, any write to a file leads to PMD-size allocation. Following the >> fault-in of the folio will install PMD mapping regardless of i_size. >> >> Fix filemap_map_pages() and finish_fault() to not install: >> - PTEs beyond i_size; >> - PMD mappings across i_size; >> >> Signed-off-by: Kiryl Shutsemau >> Fixes: 19773df031bc ("mm/fault: try to map the entire file folio in finish_fault()") > > Sep 28 2025 > >> Fixes: 357b92761d94 ("mm/filemap: map entire large folio faultaround") > > Sep 28 2025 > >> Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > > Jul 26 2016 > > eek, what's this one doing here? Are we asking -stable maintainers > to backport this patch into nine years worth of kernels? > > I'll remove this Fixes: line for now... Ehm, why? It sure is a fix for that. We can indicate to which stable versions we want to have ti backported. And yes, it might be all stable kernels. -- Cheers David / dhildenb