From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF3BC7618B for ; Tue, 23 Jul 2019 12:45:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24E07223A1 for ; Tue, 23 Jul 2019 12:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389720AbfGWMo7 (ORCPT ); Tue, 23 Jul 2019 08:44:59 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47924 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731264AbfGWMo5 (ORCPT ); Tue, 23 Jul 2019 08:44:57 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: andrzej.p) with ESMTPSA id 0B2192610F4 Subject: Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory To: Sam Ravnborg Cc: Neil Armstrong , Maxime Ripard , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Matthias Brugger , Thierry Reding , Laurent Pinchart , Shawn Guo , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Sean Paul , Krzysztof Kozlowski , Jonathan Hunter , David Airlie , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , Thomas Zimmermann , Jonas Karlman , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jyri Sarha , Alexios Zavras , Mamta Shukla , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, Thomas Gleixner , Vincent Abriou , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Greg Kroah-Hartman , Seung-Woo Kim , Douglas Anderson , Todor Tomov , Kyungmin Park , Huang Rui , Pengutronix Kernel Team , Alex Deucher , freedreno@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , Gerd Hoffmann References: <20190723090532.GA787@ravnborg.org> From: Andrzej Pietrasiewicz Message-ID: <3ad60be5-49cf-4017-4b74-53a2d6272deb@collabora.com> Date: Tue, 23 Jul 2019 14:44:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190723090532.GA787@ravnborg.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, W dniu 23.07.2019 o 11:05, Sam Ravnborg pisze: > Hi Andrzej > > On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote: >> Use the ddc pointer provided by the generic connector. >> >> Signed-off-by: Andrzej Pietrasiewicz >> --- >> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c >> index 62d014c20988..c373edb95666 100644 >> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c >> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c >> @@ -219,6 +219,7 @@ static struct drm_connector *tfp410_connector_create(struct drm_device *dev, >> tfp410_connector->mod = mod; >> >> connector = &tfp410_connector->base; >> + connector->ddc = mod->i2c; >> >> drm_connector_init(dev, connector, &tfp410_connector_funcs, >> DRM_MODE_CONNECTOR_DVID); > > When reading this code, it looks strange that we set connector->ddc > *before* the call to init the connector. > One could risk that drm_connector_init() used memset(..) to clear all > fields or so, and it would break this order. I verified the code of drm_connector_init() and cannot find any memset() invocations there. What is your actual concern? Andrzej