From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DCB4420896 for ; Mon, 6 Jul 2026 13:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342827; cv=none; b=Xzf0u/z3togn8vYkPHzuNJKk0xbXNvUHug3IC3LdMNejNsf2hagUWMABgQzzu800VQVaiJGpnvV/46P07NDfsPDZbEiVsqrWCXdIy1JV4bHSb9szKnWRRhNAibu4//rkm6VjmdwmbRlx06WFiwnOZ4AiMq2syfS7NFFYsAvWW5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783342827; c=relaxed/simple; bh=PFL5j3TOs/5RUWWKBQWglpjHpi8U23pfidgWiscwBvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oyQskVTDm3mGUIJLNNeGzSp6mwqVE0wpDpTOGOxYDydGxL3cfGvSOv4HeV/dzQeLDzeew2AyF8KPMHRAKXaPSJ4kzYtaWlyrYBDupve2ozLnXZS8ec9ucU/RskoWm/R8ulgprL5orpn1LL2HxDZQ4P1btoGY3fNmEBVxzNwi8q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bsr7BpIN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EeKN0u+v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bsr7BpIN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EeKN0u+v" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax7Ze245529 for ; Mon, 6 Jul 2026 13:00:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ADeTWQBt9148buPdrdbo22KWlh4VM7YJwJh0PS9PtUc=; b=bsr7BpINFB7732a5 TZiyT6s6kG1k2MRD81WFcM50J11VxwmbIeqIOaXjyfPvvTMlPq01NRQajK/YXoiB vewBJKo3GT/2HqqwTEfheyqoK4zkDVWtStJxFgaw++ollWqeK+PDTVLROLYUTG2F ZV1A3t68Pek70CZDoQ7mbKXQsaEFWUsPNpmMOrKgxgYAYUzqXvmeU2P5qmJ5BiXA sFkUvBEx8scn6dcq3it8ILlwnMXGi7glvEddnGGz702xv/U4cQ8wYzxTlsHfmFcS 2PE/o1INBqGSlS7otzVPrOeF/fU2q3AgQymJlAv8o3kYM9mHoPuxUbL8QdmrjRjm mIG9gQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8a98gmkk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:00:25 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e9c0c4492so69562685a.2 for ; Mon, 06 Jul 2026 06:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783342824; x=1783947624; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ADeTWQBt9148buPdrdbo22KWlh4VM7YJwJh0PS9PtUc=; b=EeKN0u+viKnHRa6S9l5YmKyNKZhzaj1Uie4CWw5lGc4IBF6lwy2iJ82gMdTUvz9pCm X9Gh00JOcrkWWrpurjarAxmRugSPIcv6IC79puLKMAojJiMLTRSmHJuBAVf74Bx/dBLc qrOBrAm4ElljBOsrIihqccfPxuurXQCpIiTIA9J2bTZ8IkVnv1PrDi7eyATLDctoSRJG J4e7XFLYwMHhEdEyN9AITm07pfR6BBBy5zj8slxK4ddF/Jclx86XQM09mZbr3dR5WMvF Mz0WkC3Hf9sYJAUEnWQZz9CWNDFKNTypeKd4J1U/kK4T3oOpXJLhWUpYEOhtAibVfxei 9yUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783342824; x=1783947624; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ADeTWQBt9148buPdrdbo22KWlh4VM7YJwJh0PS9PtUc=; b=NOpfNqqacfI3xv5F+uf3XXijAXlHkx2XODoOb9q6+z6gdxAkdMdf/9jGn5EmMxbdpt +u8avUWx1ABpnaJdPZs3z76P80wh3EWohKvfBOTd03I+czi1t/BtbpQ3ct4K1PpPTYmN ZWzzLT+iPfVDM3W4cbic9yaKZ2mpqG65zQc+o5Adz8N8rgqv+KZDHFCNgczCHbZl/psL U3guhbC3dI2C2ck+mB//m2+RA/RBjZ4CNIZhgCPWbHNq0hlxqUe30vn3CdKsA79amot8 Ixn6vZqKMG7wL/u1Ud65xhEumKVXkrU1iIEGHjPx0vXFLmU/zAmz8khC8Y9Am4ndbxiY Rjww== X-Forwarded-Encrypted: i=1; AHgh+Rr0aiOq9KLsMrt6mVFFhGWuWvj3e/Flu4vW4gAu9AnV7THE4NgbsBduKgEohLv4Q7kl9MtHUZ60yM3HK9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8sWQxwS0cQKaeng4NR+8uBnRPS2Rv5Mwsc9EYeD02XXfCcejw EAjzzLHqEFLV0r3yf3zakTkB/l14vhi2iuIb8WVyhz+pfowNbnUdE+fBIeUku1oLk8+e18uLH1G 3jtDSj5C0fa4zsI6ag2audSiGq3M0Mz6/JgK+qD3UZd58f8lzh19OgiG4vY9H766pwX0= X-Gm-Gg: AfdE7cl32Eo8TnjHmol+4ZmFiJHM7Y7mQsUXoF1ZTJC5XjmFKgyHyNJ+IxdIDz79l1/ FgmoMQ8PzczufGdWO4EoeoteI6BTQnH1BHqLWzBjrqoA32crTHTzO2U0F19qb4qkB8WH2MtzLZg yy5Q2l3lPmLUCtbw8tSS+bqtBTDzc7lz1tY3MjOO8krDfjFdWdSrd6Z0E8BAlxVFGE4LRCOnF0U 22sNaEwbR2w0VxEXNRJETJv1R3tpQwrCfhKSb5AIMDF8sK+noIJk5ybVKLj7ACZh2cFr41hm59C 86kWV5qzye+1EH1ZNwQEGea4d80c9INPK4IicT6FOmn5V0XBHbxm0PYcRrLFDT7k/Ucers8B8dX +r233vPg8nKph/KXd9wpvDNn5PdfHLQ3w3ss= X-Received: by 2002:a05:622a:8b:b0:51c:1c73:51a6 with SMTP id d75a77b69052e-51c4bdfe4d1mr90901391cf.5.1783342820371; Mon, 06 Jul 2026 06:00:20 -0700 (PDT) X-Received: by 2002:a05:622a:8b:b0:51c:1c73:51a6 with SMTP id d75a77b69052e-51c4bdfe4d1mr90900371cf.5.1783342819707; Mon, 06 Jul 2026 06:00:19 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b6091785sm772908166b.16.2026.07.06.06.00.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 06:00:18 -0700 (PDT) Message-ID: <3ad818c6-39fa-4b8c-ab82-f5cce6743cbf@oss.qualcomm.com> Date: Mon, 6 Jul 2026 15:00:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/19] arm64: dts: qcom: shikra: Add support for DISPCC/GPUCC nodes To: Imran Shaik , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Loic Poulain , Brian Masney , Dmitry Baryshkov Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20260703-shikra-dispcc-gpucc-v5-0-cc13826d4d5a@oss.qualcomm.com> <20260703-shikra-dispcc-gpucc-v5-19-cc13826d4d5a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260703-shikra-dispcc-gpucc-v5-19-cc13826d4d5a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SpigLvO0 c=1 sm=1 tr=0 ts=6a4ba6e9 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=3UrmxHwGBoanhqk-odsA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDEzMiBTYWx0ZWRfXwWNEqOANjCcy XceK7ug0fRUcAAiolmWWFEilhtPS1P87aRUIQAdOtXb3M7Z2u214X1i3nc2msH28qkM/ysJxKNo crdcDUhPsYQRdH34OZmD6fPLPq/60QIETyGzgzGddLNYBg4mG62jLke+VmiC+0ygiEOgW8TsPPq +RJ7amWfjKhJky0UENwKct6QXpDLLpHeo57tfOrRRM7n0BUIErtbiLJrefXtZXZh+Dt4TSHXv1d uKsY5HhvRUJzsdYHt8OyQAm1rrvAceNzHHlvFT10FBNO+lOoCXB5fq2p9DfulLk66ul/4YTXleg eZZA6N5Q4anoOStvJnHcoJoQ/NFmSKxtUvuEeGK7VzHh1scBQF2wLjSb21aQ/mAv3cGE8VLjhvk ogCdFUQtVN5M/EIGE/XFU3+UiarCc2r/3KVGlPwUbtkKBBtrQcB5eBnm4UZR6xaP4G02Y67uLvw Eisx8V53szZQ7GR8YKA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDEzMiBTYWx0ZWRfXyzau07iIz5w/ FEPV4ut1Iq8d9P66MeNyldGJ09iz23pDzxhbSr6Y0OaSMmbTEWAYHHuQ4M/cw/lTjbodjuNx8YT 23K1rzz+6x+u8hAv8I2vuV3UNerXGKE= X-Proofpoint-GUID: Rxkft5XZdq2saDmsJgXKqqoIAvsPrFgm X-Proofpoint-ORIG-GUID: Rxkft5XZdq2saDmsJgXKqqoIAvsPrFgm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060132 On 7/2/26 8:31 PM, Imran Shaik wrote: > Add support for Display clock controller and GPU clock controller nodes > on Qualcomm Shikra SoCs. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Imran Shaik > --- [...] > + dispcc: clock-controller@5f00000 { > + compatible = "qcom,shikra-dispcc", "qcom,qcm2290-dispcc"; > + reg = <0x0 0x05f00000 0x0 0x20000>; > + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>, > + <&rpmcc RPM_SMD_XO_A_CLK_SRC>, > + <&gcc GCC_DISP_GPLL0_CLK_SRC>, > + <&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>, > + <0>, > + <0>, > + <0>, > + <0>, > + <&sleep_clk>; > + clock-names = "bi_tcxo", > + "bi_tcxo_ao", > + "gcc_disp_gpll0_clk_src", > + "gcc_disp_gpll0_div_clk_src", > + "dsi0_phy_pll_out_byteclk", > + "dsi0_phy_pll_out_dsiclk", > + "dsi1_phy_pll_out_byteclk", > + "dsi1_phy_pll_out_dsiclk", FYI neither Shikra nor Agatti has a functional DSI1_PHY, so unless you're worried about some incorrect bootloader version toggling them and want Linux to clean them up, adding them is no less than unnecessary Konrad