From: Jeff Layton <jlayton@kernel.org>
To: Tan Zhongjun <tanzhongjun@coolpad.com>,
xiubli@redhat.com, idryomov@gmail.com
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ceph:use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
Date: Tue, 31 May 2022 07:52:40 -0400 [thread overview]
Message-ID: <3ad915ec2e8d4a924f61479757b2163ec4b987c5.camel@kernel.org> (raw)
In-Reply-To: <20220531113903.51880-1-tanzhongjun@coolpad.com>
On Tue, 2022-05-31 at 19:39 +0800, Tan Zhongjun wrote:
> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define
> debugfs file operation rather than DEFINE_SIMPLE_ATTRIBUTE.
>
> Signed-off-by: Tan Zhongjun
> ---
> fs/ceph/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index bec3c4549c07..05d15a0bbd9b 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -386,7 +386,7 @@ static int congestion_kb_get(void *data, u64 *val)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(congestion_kb_fops, congestion_kb_get,
> +DEFINE_DEBUGFS_ATTRIBUTE(congestion_kb_fops, congestion_kb_get,
> congestion_kb_set, "%llu\n");
>
>
You're now the 5th person to propose this patch.
Here are the first three postings. I'm too lazy to look up the 4th, but
it was just a few months ago.
https://lore.kernel.org/ceph-devel/1577111958-100981-1-git-send-email-chenwandun@huawei.com/
https://lore.kernel.org/ceph-devel/1612165930-110076-1-git-send-email-jiapeng.chong@linux.alibaba.com/
https://lore.kernel.org/ceph-devel/20211221143614.480385-1-deng.changcheng@zte.com.cn/
It's not as simple as doing a 1:1 conversion like this. Please look at
the threads above and offer a revised patch or let us know whether you
want us to drop this one.
--
Jeff Layton <jlayton@kernel.org>
parent reply other threads:[~2022-05-31 11:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220531113903.51880-1-tanzhongjun@coolpad.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ad915ec2e8d4a924f61479757b2163ec4b987c5.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tanzhongjun@coolpad.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®