From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451AbdJXHPU (ORCPT ); Tue, 24 Oct 2017 03:15:20 -0400 Received: from hs01.dk-develop.de ([213.136.71.231]:38986 "EHLO hs01.dk-develop.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbdJXHPR (ORCPT ); Tue, 24 Oct 2017 03:15:17 -0400 X-Greylist: delayed 429 seconds by postgrey-1.27 at vger.kernel.org; Tue, 24 Oct 2017 03:15:17 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 24 Oct 2017 09:08:29 +0200 From: Danilo Krummrich To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs In-Reply-To: <20171023234447.qaohcuyfvnwn5m2n@dtor-ws> References: <20171023234447.qaohcuyfvnwn5m2n@dtor-ws> Message-ID: <3add1a5c711650bde8226e483bc83a1e@dk-develop.de> User-Agent: Roundcube Webmail/1.3.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-10-24 01:44, Dmitry Torokhov wrote: > We've been missing a goto to the unwind path... > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/serio/ps2-gpio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/serio/ps2-gpio.c > b/drivers/input/serio/ps2-gpio.c > index b50e3817f3c4..c62cceb97bb1 100644 > --- a/drivers/input/serio/ps2-gpio.c > +++ b/drivers/input/serio/ps2-gpio.c > @@ -366,6 +366,7 @@ static int ps2_gpio_probe(struct platform_device > *pdev) > gpiod_cansleep(drvdata->gpio_clk)) { > dev_err(dev, "GPIO data or clk are connected via slow bus\n"); > error = -EINVAL; > + goto err_free_serio; Good catch, thanks. > } > > drvdata->irq = platform_get_irq(pdev, 0); > -- > 2.15.0.rc0.271.g36b669edcc-goog