From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D63409102 for ; Tue, 30 Jun 2026 11:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782820678; cv=none; b=gKQdpDCHaA3KYe7jd/Bexlbyi/XNVckQZVBDl4/iVWUQv5raYy1fj77e8fBPgqWSMT7+nkvxgxb+oX4qNygzzdSTllgdRgrmm96JonsS2s1PH+ZnljT5tXY1hyLsUrtp9YqNvbKUBM5tmldePZcL13u+99kYvmNXtrWc8GhXzeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782820678; c=relaxed/simple; bh=yRLwbmZehOFQbJdCz/SPTD5FHiCCv8g1D/InIpDlBlE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mJxLrqb2SCvmVaFWK37rPoKYxmmHwy8L9he8g2bsZea6csW8ts/ohvan3QQ9S4PvIvTa6SnCYKS5lsRfV0XbvsMaM2K3i/Xmk8SZBaZKiORffau8CD5Mkz4Joz+fs0btSJ/CvqWlBI8xUT0a7/W2HzaIb0BKHaOMSLwyTGL2F00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EZDaydgr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KTWPrOTP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EZDaydgr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KTWPrOTP" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9muFl1604543 for ; Tue, 30 Jun 2026 11:57:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YHC2Rgq/cf45xzQp1L/2Fd/3fsuR1ecn+pwz/JQ+FLc=; b=EZDaydgrj/oZl7jO 7pgkx864g3sxB4SbG9D4WWfOKy0H+mxmVtQ2JxnHlv1j5lYg0XOSC0nCyJAyIN1z ThwirOWEYIn7jQ6s0UOmH3mQ96XZSa5xO0+EBNS+p9u45mx1y7QChlekmNXYV8MC rBspFsSwOC7xwwxa3gdgZ00NkL7sZnawPm1NZJcCk+Y3AkETkdUywFOx5tR/h7jl 4jxfOT8A2RfbwJ3lxFia9Pdj/1bnqJT7+xn9huipNIs5YLJ9hZPatZPxTYz9Jcr5 dGyWgNu5sNDrNFVmpfsJ8dY77wkKnYdtMUKFlxGXvSIYG7/3z0MuiLlJYiPiwdGI k8biPg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f462fj2a4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 11:57:55 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51a07295d67so13336521cf.2 for ; Tue, 30 Jun 2026 04:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782820674; x=1783425474; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YHC2Rgq/cf45xzQp1L/2Fd/3fsuR1ecn+pwz/JQ+FLc=; b=KTWPrOTPCjL0RY4eAlfuW3iMDGyCNniShrqTyXiQudzSVDjTtWcsSRyUysts3c3g/G +EIopceymEPhxVbIrkzSstcjPFuOJ9aBCS0YDZn/b66VOk2qheudDRI5qZlyDsqQEDkh Dtd5zp71usiR/dNL+/AARKCc4855d4Qj4jb/NXXnMhHHBy9cVmnErUqX6enHwo8s08tr lGq/qjemJuuIWy7wPsNUJ8FgFQztSfydPQzTRrIEmOpceET4ZegpqC97TSJtlSJMZvGE SJK5nesmEsp6NwEyxlfzAezDhWbHPg+Kq4Mi0aonUvyy9wzJGAvVyhfE/BpflWFPOI0A HU6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782820674; x=1783425474; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YHC2Rgq/cf45xzQp1L/2Fd/3fsuR1ecn+pwz/JQ+FLc=; b=b6818PUaW5MhQuj1Kl5IUT6DQ11IRyVWIHahGT5CK19TsTQS8xwTfY4zz29YBOiJla hkjcYSWVwX2pQIfQRBydsXq8cV85sgKYC6xIDidOv+ajT57ogt5G0o8uOvxWlQjYnEtZ 8kJ1hSNvF/SaPzmgGIy4wM3x3vnd8DR9UMNsoKriQGCEi8fLYDwFVJCi8pysYwi8q13j K0U/nDPCWpa7GcmtWgXEZAm8UZhC/uCGU0V7r6n8jGTGKm42qwlSqoECq8ixlyNluKm0 wcMHp1PkxyZzfFjBN+X054wqblqusptLOuVF0JLdwttIMWM2ycA3aX6sS7o8KL1y3mBa d/bQ== X-Forwarded-Encrypted: i=1; AFNElJ98E0oM85l4/63STPDUuBzB6Sv1HF//WsOV2XUbxbbVJ2LPkRsd3tMxr3Bth4y1fILNGlWiURISVXI2NkY=@vger.kernel.org X-Gm-Message-State: AOJu0YzXsgIqcZ0/rPNx9RZgiV6zpl2DxS/ed+KO8bAcGex1XWHTTp/O kmt4X/gFzA+uHDeMhs/HEmTJ6h8Mu8FzuOBrU/6kPPVMjmwmDDJtbAg+yV1cwlZzZVZFriN02wm K+qRUo6mtpc00WIjJOTCQhbTUDfMBc57UpIg1Ap0tqVse0T+nqGbiBwDxePS/B0Gm3Q1RGczOiM 4= X-Gm-Gg: AfdE7cn3Eh7nGnDWWUvzUQQQj+XSY82MZWugRVXcyp28mufkmbErr6oJh9OQFDJRXTk 1wSBgywrWyh2etyw0fjIIsVLLs3NZbwVA736hVXtJHIplfqdLGn+5wnwKa2c8KBm1eIqra9whxU f/QhMJVW4Ak5RF8v4InPtrVy9bVgcpzvRN75eCnCR8oRf50hegD68J2yerdNJgnlxVHlrbKJN3Q W9UqgMOTDdQ0ZeCN6/7nep3pvg4j7sxkDgWjn4ecmBaBEmP+hQ6QKFUac0BfB50e0H7+hRuyRTT 0UDfIoFaMnS7IarBGOVo4FJmJuo0dxtmW8Tf4mWGq26crpqTpe2pwlqTz5s/S//Q4IZcLFH+Gsb PbcAmEWFowev/A70Y0UyNa2zAd6gXa6iDExg= X-Received: by 2002:a05:622a:112:b0:517:6162:daf5 with SMTP id d75a77b69052e-51c107273f0mr30701221cf.3.1782820674207; Tue, 30 Jun 2026 04:57:54 -0700 (PDT) X-Received: by 2002:a05:622a:112:b0:517:6162:daf5 with SMTP id d75a77b69052e-51c107273f0mr30701081cf.3.1782820673689; Tue, 30 Jun 2026 04:57:53 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12891785f2sm112558966b.61.2026.06.30.04.57.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 04:57:52 -0700 (PDT) Message-ID: <3ae18832-4eea-4f99-91a6-17d250dbf917@oss.qualcomm.com> Date: Tue, 30 Jun 2026 13:57:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au To: Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260430-adc5_gen3_dt-v1-0-ab2bb40fd490@oss.qualcomm.com> <20260430-adc5_gen3_dt-v1-2-ab2bb40fd490@oss.qualcomm.com> <57f3407f-3371-4db7-87cc-218f7360ce3f@oss.qualcomm.com> <5941078e-2376-46a4-b9e2-9686de1ca991@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5941078e-2376-46a4-b9e2-9686de1ca991@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDEwOSBTYWx0ZWRfXyaN1fyztMbKs 9GZuQ59SMASos9BtE60tGSeqNvHCKPpiB0NIfAoGivECjDNkm8JAyhsxKtzZO9gXawFe4UnDLrm WKa+ZqzoqfA0mTZTOynd/ZcR37n0bImkZ9uBmDUQ/ZtjWLNb9uJgZOdmO0+pk0m4HendP4v3ov9 GiRsqua1atBVYLRDTaBkQXBQwanl6XKFBq/w+U95O5qZEHeUcFPDG7D8MSgEGIft0DuPdbyNKBy rPDNEFJU8N6i48ycKaYhnIYja8ZZxlSOrY2neYwEb4h14ybgb4/w7sGcprd9RwxxzrspB2fDl6A hBKA4GIiP+OZLZIZG2FFdpADsJwjTG3/eOvrvfq6cq48FKKYuZPEL+/dnlDfN324sDyvs4DvUeE YaTEBkqsmsVZ2HXmRo6I078wLBO85XuNtw0J2MItT/t8FGYLvvAOFPo/7UVt71ZBgLgo4JYz4xM Rm8fBSm064QWa5Qznew== X-Proofpoint-ORIG-GUID: FznBkB0Hm2BM6lyQTCc-ZWTJItOTlyG9 X-Authority-Analysis: v=2.4 cv=JqbBas4C c=1 sm=1 tr=0 ts=6a43af43 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=YLglQ_YvAg-cOnyBpDUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: FznBkB0Hm2BM6lyQTCc-ZWTJItOTlyG9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDEwOSBTYWx0ZWRfX/f45UkIKymoc HcQYEfKRWJCmXrNSKGQIdN8NybDCOT8tMgpa1DEFEc5cyPBl1FHo3iIWK+I1VbJQ1FwlKOb7DmM pgZ4UCc55Q6+cC3jt5KpoFUjd7QdJLA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300109 On 6/18/26 12:21 PM, Jishnu Prakash wrote: > Hi Konrad, > > On 6/15/2026 9:26 PM, Konrad Dybcio wrote: >> On 4/30/26 10:58 AM, Jishnu Prakash wrote: >>> From: Ayyagari Ushasreevalli >>> >>> Add ADC nodes for the four PMM8654au PMICs (pmm8654au_0 through >>> pmm8654au_3) on the Lemans platform. [...] >>> + pmm8654au_0_adc: adc@8000 { >>> + compatible = "qcom,spmi-adc5-gen3"; >>> + reg = <0x8000>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + interrupts = <0x0 0x80 0x1 IRQ_TYPE_EDGE_RISING>; >>> + #io-channel-cells = <1>; >>> + >>> + channel@3 { >>> + reg = ; >>> + label = "pmm8654au_0_die_temp"; >> >> Are these labels namespaced, i.e. can the label be just "pm8654au_die_temp" >> or "die_temp"? > > From what I see, there's no functional issue with updating the label to either > of the names you suggested. We made it this way at first as we thought it would > be useful to have the exact PMIC instance name in the label of each channel. > > Do you want any changes in the labels? If yes, which convention do you prefer? I poked around sysfs - let's stick with the existing ones, since all we get is this label, without a "nice" way to identify which is which Konrad