From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 608FE38C415 for ; Mon, 10 Aug 2026 20:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786394648; cv=none; b=I1G/LKvZCQwbDoOcTKnVE4m9Pg6+DNkC4dON/z3Utg53yY+OjEubosDFzH2yLlvfkVjCHQhHxtXBXfHvXZJEBagkpC0aFLYJNxJ72lS3fwq4XT//L5r0lI7O7pOdTKnn2Zlq6CF6CmNTysltiIIp3O243y2rmQEgkzjrOV3VWg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786394648; c=relaxed/simple; bh=cXdfNpIDVoel22eqibDoZ5qO7LMHb651FstPcqPzEzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XcTgxmtNTMr9J6RahR1Y0vuEG5Kn3hxYimDPjvUALUrew6Os79fUGNO6dih7z9RanMcmgHcsWl0aOX8aYlvE3lhRNHBojubVrZ7VSjhwOje2I3cy7rpY5HgltROqzwMOFIpSQc3l8fjwVuzDeevhxqRTJp/ibe1O+HC9I887EFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WgZQWiCj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GDm3WImu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WgZQWiCj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GDm3WImu" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67AJlvgJ2913986 for ; Mon, 10 Aug 2026 20:44:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +WuAtyEdrJILuTbmDWLApc2Rm/QOnF7LFzl3PAVY8JA=; b=WgZQWiCj/QijstyB 54hfE0gKGttzXWKLRODQjCHUbByD5YuU6X+jRhndq3Egk4QGr8RG+ujcbLO9mSyx 2zQk0bKQgPflWhN+hNsf+ZWYqh7hn0kGpFhrkHlfAlVHCt3ksMpJvwYCHlrTRALI xcMmJFmlSqMaN5ApzCz30w6e4E1UnZlOJc+oEBUEEVBH+arnuPoH5/Oy+ikurxhu +9Mq2x2Cl0sixUtsujjsRfb7YyvjAFglVdBOlgeJekpaFW/ke9lwZvfb0evPdTqX BHh8rA5zJsOBNXDLvcRCyqJjQ3yFfGye/3DPmbbJAIbkAtM3V4xvlSbGKQmMbZgW fLbVjg== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fyjyfrtv2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 20:44:05 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb5cc1e139bso1731615a12.3 for ; Mon, 10 Aug 2026 13:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786394645; x=1786999445; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+WuAtyEdrJILuTbmDWLApc2Rm/QOnF7LFzl3PAVY8JA=; b=GDm3WImuzX26xN+tJuoM1maDIIjB7asA3doTCb5mskGt3gUmhaYl41nNaHpnoQzVG0 Mt/e0Xk4/tLf0el+wIp5jN6lT+dxobNTxSotuvB6WZpG6l6c2uRCPzQ4AqsSMxmEavwR XsefSvARedlTpLYv6gc6jXVExSGMMGMv/yVvWjiVWMLjiBq4xa1o+r8henfLykHCpow1 H5SW8OAH1tH6sCU+b/oWcfWTCg+NU+ErjdXIyVrz6xLJxjN6J3lp9NGCgMqlEw6KXEGy Fyx56jnB/l0T8AXRaKA9goJJ3wFwpGOvugwADwxuN9Y48M0be7oYGeKIkfjqXS7Coo3G BFWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786394645; x=1786999445; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+WuAtyEdrJILuTbmDWLApc2Rm/QOnF7LFzl3PAVY8JA=; b=ntTcNMhUDPaCYxz74BCRYlVgUJCQxMtsjIahPYA+PQw7b0AEblijBV4uBhj8HwS9Po dzVGExrKXHq7Qx34HeqoK2oN0q0KLH4OXWZ34V3qSfSUrkEc3bPX/9rjHBUVm7msOyGF LBYPLpodPtVFX34LCdv6IVZPEU8tHOIzMc3hIlBErBKSSD2bAJyQm1Bjy8LmZ8JqYJ/t bLRyPDAHFPDFyuAokbs72NC7t4DScbKUphzvSaPQx2J/Z9DjNJqVUvahaCyAvqwig5fG KfJpOTu8sherezxbSaQ+ETXSyIFY5ATld+vNl8dJjnAmU0QTSnyS3ADgN3JOo5FEc7I6 SNCA== X-Forwarded-Encrypted: i=1; AHgh+RojjKmm/OFhKnzoBthLVFhxy7DJzn5LrRBs3XPtQYXJcXvh9mKvJYbJUYJ2jQM/L2kqiCV885Zv3kxGY7g=@vger.kernel.org X-Gm-Message-State: AOJu0YzvPXMRu96QlhaDh5MvxET56MfO97mNAMYuFjL00NlYhzR3lt1Y wjvIc6P1kUkWHuVG5Ogndqa+wclPGtGAhATA8T7+KYXuFSrs7bzLPuMJy9I4ZE4YE2lC/kcZSqe HRAOud49EAE6XRf6ZbtJpXCIZMUXcsC8MCL3px5htG1n2CadxnXFYkgvk8TOuWDQM74Q= X-Gm-Gg: AR+sD13dkHfwgGdoa8hcucCqrWv18O5tlqsg8cuawvkm90KNpCdYKng4BRekRS0tNEB Fhe2xjXM2OCZ596hzy2Ff5FGhgCNC9x3W7uc9xY1Ejz45vtKDbd3gSK9MQszOk75Rg9el+Y27uk xlxNmqqRwwwc+Dw4YEIwkZ5NnHAx04ebClatQ0uRsuJbbOuYRzruGaL2C+sJbnw+t8ROPgLjslV dUWlkj38h5Z111ErnU4yyZKxs3GClWFtlLRWKcblHHG48B2vcbxOZqmPzd4jf101USNdDJjUYnj rM9FWHWCm8iPkqKywahW4q1dqqBKwQJ5tzaOQQ7CcZ4vDnJJg6YCnN2hx2vPcc+nbRQByw5rSV3 qwOWNC97t0aOKz3XnmNrTuU42XgbrKQ== X-Received: by 2002:a05:6300:6cc8:10b0:3c8:e140:63c3 with SMTP id adf61e73a8af0-3cc1c904c60mr2971449637.37.1786394645053; Mon, 10 Aug 2026 13:44:05 -0700 (PDT) X-Received: by 2002:a05:6300:6cc8:10b0:3c8:e140:63c3 with SMTP id adf61e73a8af0-3cc1c904c60mr2971428637.37.1786394644588; Mon, 10 Aug 2026 13:44:04 -0700 (PDT) Received: from [192.168.1.132] ([70.95.199.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be8a754dsm42720054eec.11.2026.08.10.13.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 13:44:04 -0700 (PDT) Message-ID: <3ae42f16-ead2-4811-9b5e-da42bf81d477@oss.qualcomm.com> Date: Mon, 10 Aug 2026 13:44:02 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/1] Add version check for setting ForceRM To: Thinh Nguyen Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260806234035.1078704-1-elson.serrao@oss.qualcomm.com> Content-Language: en-US From: Elson Serrao In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: xyU5Y5_nBCvfCJz1nBV75hMoC8buVfzf X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDE3NSBTYWx0ZWRfX7nSSDaj2jrpn /PRr+YnyliJL+iE7Hrh4hAUz9y9KICw9KNHjK+hamCaSHa6+kcLjz5wfyoX1uPgmCWDkhl7FqWW hUV3GsGfgI/zZQ0SWs8rDnjIu/Yzxik= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDE3NSBTYWx0ZWRfX6KV1m4pYB/9t pnEuyJooJTiVZ0RUmQnHDTCYMMbv4kTZPxpFi0tMIEY/VeslzFG0KvuyqSrrOvCZA043qq+Im7R iyRuWYJhtT+f2G6xDwKKgjMJlBTiHgOIP+oqY/S17ia0Ta4CE5il/3jRWz6yv2SKscJ6v8jhy2f TuyInxeq0lV87nYq1RFQLkgIoNZNnIJ0siOIhGHRPE/yuww7Bay4ESoXttU7nO57orx+8IwOl6y aVrHEmASFSHc/730iCgmHkyp2BXr7TzEb2b6xIJEQF8hUi1Nu7Mqw+4cY3I7ScwFpOthVPg/e3o FlaBpeBfRfqcGiN5totgy8vcQxdFvy2YMMoaizU0su3SKkEAIDlFCKL1qNMf0tbTYK4H/loY16w XOKZ0YsrnvUj3Ai2J/Wcy4Cyc0ud2AE+38QHZcJ4rslv3wJ5nqn1242ePi9pm8PskJdnU6JEsLk 5Lr/NXlRflmciHO1ytQ== X-Proofpoint-GUID: xyU5Y5_nBCvfCJz1nBV75hMoC8buVfzf X-Authority-Analysis: v=2.4 cv=Zd4t8MVA c=1 sm=1 tr=0 ts=6a7a3815 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=uHxescsG3rBdxcXwcPaeSg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=SZbTn5QKAPGrlT8I5W8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-10_05,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100175 On 8/6/2026 5:19 PM, Thinh Nguyen wrote: > On Thu, Aug 06, 2026, Elson Serrao wrote: >> Hi Thinh, >>   >> We are observing an issue on DWC_usb31 v2.00a and v2.10a controllers where >> a transfer aborted through the ep_dequeue() path continues to generate >> writes even after EndTransfer has completed. In our testing, the issue was [...] >> Thanks, >> Elson >> >> Elson Serrao (1): >> usb: dwc3: gadget: add version check for setting ForceRM >> >> drivers/usb/dwc3/gadget.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> -- >> 2.34.1 >> > > Hi Elson, > > Thanks for the patch. > > This new recommendation applies to all 3.2 controllers also. > > I don't recall forceRM=0 causing any issue to previous versions. > > I would suggest applying this change across all IPs and IP versions to > keep consistent behavior when ending transfers since TRBs are updated on > completion. Since older IP databooks recommended setting forceRM=1, can > you also add a note in the code indicating newer programming guideline > revisions now recommend forceRM=0? > Hi Thinh, Thanks for the clarification. Since forceRM should now always be 0, and the reset value of forceRM is already 0, the function parameter force=false effectively becomes a no-op. Would you recommend we drop the 'bool force' argument from stop active transfers API entirely (documenting the forceRM behavior in a comment)? Or would you prefer we keep the parameter and just have all callers pass 'false' , so the API/framework stays in place in case a future IP/version needs it again? Let me know which approach you'd prefer and I'll send an updated patch. Thanks, Elson