From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010054.outbound.protection.outlook.com [52.101.61.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE3943D47B2 for ; Wed, 26 Aug 2026 10:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.54 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787740929; cv=fail; b=e6Db6ck4Waq+Rteup2PcH0aOhC8McNDZz9qcIavFlm3/lOW/oxRpaiihcyNJ9AcVUeHTIeSND7nizSI1ROjMwQHW9rMEzeJCtXyZFdLpaKU2lnJNbokkwFMaWAhwgW2FUCfZw9HM28E8YMphbKpvZ0gsjhHNZcEqZ9M7SUYM0+I= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787740929; c=relaxed/simple; bh=CsD59LPaPiOynMUGRe1vLgCSoTzZzZNF5OS/0aw4pv4=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ehlohWUNQARVFLQQDFEWtPtXOrftvAXQ7BL3JB2DnXYSv+kOdcJCHa6yfq8zTT9kjisvjOgkRk9j3TUIMrE9seWjxKyT0dXQR20gyZ0vRzm55QAlERRBMZ5fhonE04SYr4rcMQ+t5gooVeTS7PSkxilMjpGK+Qs+EwPzBY0zpPY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=JhjJbOLu; arc=fail smtp.client-ip=52.101.61.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="JhjJbOLu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tuZDFx1NckOzQwssEmXQ8iJziFsP5F9kLO7Ypfu6s7T2VeqCPuj4iKubT1od+4Rh67xBRDivJi9JAyVOh/oltoO7+5/6qWXjKcZ6XGT0yo2KHRTnT35F7H/OSQeipEqt5wjjLEaLMkgUeCrzTbQfYr9v2AP5JNRJJDS+8m2Dsg9Frt/cVB3YADx+RR0LiLhtvd8IobzELxzf3lLI0E5Mo3OzC7wmLduNcCAO4xn3Qn/mNhWRs3sn8ip0/h/FL/10lc74Ikb/yt227zxPaQBz2A46e9uQL9EsD9+1snwQIUvqiMQr2cqfRvjW17/NsAcBivG6RfJtpjbqM+ijK+wufQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFtptr5o/VYN0VM2dJHmBk/P/vlbLLBp3dMaCXoN+3c=; b=x53xmE8V/NCM7np42vjKHxT5+Y1AH5msP2yzDh6qrUbEBW66/Wo76+LVayXrCzQEd3+x584KQ2WuS/IM8Oq8xM/Vb5ep0OvqljChPaiuWMPvhfK8oYwjZ1qNf/PRc/q/p9kTPQHCLokDZFjY7yJP8eApiIoLgjxPyN3m+WKJ2yQvq3vNu6cbFIF2U/LYJh99rDpaeT+aVwtxcdPOh3OFvubSdPO/owJqeC0BlMUqJgpai5Ibu9wp1WXTbJsD5v/EN9tROss3F0jH6MwpzctzQupntgWQ/0JvQPqcqaBHskQGXoshQMUbkNEDfc46Tdm5ki8uNerS5A/hve2MoLUdvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.90.133) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jFtptr5o/VYN0VM2dJHmBk/P/vlbLLBp3dMaCXoN+3c=; b=JhjJbOLuqSpk9V8Eg5V/ekIWPs8vPtIIRAR1YWIQVjy6jQhRhXZXmpwzN5HWJ8zQMWtxpxae+eRnjyEW1WwdO6iEgch6a/uM0wxYfcZczUKW95hoxr3d4UnUr5Y2l3h55/uddtj641EFNDx39u99SX+3RMK7kpX1VClyFYMd2PU= Received: from SJ0PR13CA0135.namprd13.prod.outlook.com (2603:10b6:a03:2c6::20) by PH8PR12MB6867.namprd12.prod.outlook.com (2603:10b6:510:1ca::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.315.13; Wed, 26 Aug 2026 10:42:00 +0000 Received: from SJ5PEPF000001EA.namprd05.prod.outlook.com (2603:10b6:a03:2c6:cafe::57) by SJ0PR13CA0135.outlook.office365.com (2603:10b6:a03:2c6::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.360.7 via Frontend Transport; Wed, 26 Aug 2026 10:41:59 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.90.133) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.90.133 as permitted sender) Received: from satlexmb08.amd.com (149.199.90.133) by SJ5PEPF000001EA.mail.protection.outlook.com (10.167.242.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.360.3 via Frontend Transport; Wed, 26 Aug 2026 10:41:59 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Wed, 26 Aug 2026 05:41:59 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Wed, 26 Aug 2026 05:41:59 -0500 Received: from [10.136.43.157] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.45 via Frontend Transport; Wed, 26 Aug 2026 05:41:56 -0500 Message-ID: <3ae49b35-2188-4b29-af4a-6fff500098d3@amd.com> Date: Wed, 26 Aug 2026 16:11:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] sched/fair: reuse the ENQUEUE_DELAYED calculation in enqueue_task_fair() To: Kayra Cizmeci , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider CC: References: <20260824125223.508178-1-kayracizmeci@gmail.com> <0b1ef9d0122ae3037dac38d2549f13c9b063369a.1787737648.git.kayracizmeci@gmail.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <0b1ef9d0122ae3037dac38d2549f13c9b063369a.1787737648.git.kayracizmeci@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EA:EE_|PH8PR12MB6867:EE_ X-MS-Office365-Filtering-Correlation-Id: 02f363ed-2cc3-4e49-faf2-08df035ea87c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|7416014|376014|36860700016|23010399003|921020|18002099003|22082099003|11063799006|4143699003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: rhkEF96pZnvwJ0UI9o2lQ8daT7OL1HVHM4BPyonAYHMc6BkVgNAbDZb3t37R4nAWQ1rbqGY6kUIrBlYxuZgKkd+nlw9g1TAbqBVd+q1qZJx2yDiTOYGanPzTYQ/e5RpPfbDt8yI34QQA7e6gErsC77AtERc5Y4don3Zr35XhW2i6/QrBRNrlDkMxq+vaZd01JeGmnP+5MelVIyw4/NPkQwwf2CUif8OqkJ4BS7hR+1wD8tI4gHSUCS4G1WtGbSEGU2JJHY/NO0/J+rMX5646Q19EEW2WZPJtcUR5PIywhI5XC0yq4KtEGMF2gIKbXqT3icdBWwo6b2umWzb6XQzb3cYI4BDAM/AG63QBVT0rIZG4I3Fi1cb9HQOj8b9lnv7xr6ASyoZhlWdagNbQ3DTWvjohpfPHyZbq2t33ap45zPQ1Zf7UT2wYSHwTpWguLr0/F25h4JeBP1VgtXb/hcrxl+eDKqxZzvy1N2JAQsMtuIi7EnzfzRDS76OQfmh7ASYUDPv+OXwu7zralc4kuArzXU/Wk49n5EDOtvB6DUgtHvqgPVYiNSY62KXQ5l4a79D1DOIpMzXTYt2ZkOzauTYyIXkdgfFRuxethVErCcgzrDAD/u6tW1Howm3hrBCkR04NrKYxU+257YC6WLaa+HPnEv9KviJGsTS3o7lcbnauW7oMmRiscRXleEi50CFzMunFtVWk/tyAy8yvOwd64QpEnC58xQlcF6XGPuccfgEFkyCFHiczoPSKMMoBHwq4LfYa X-Forefront-Antispam-Report: CIP:149.199.90.133;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:unknown-90-133.xilinx.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(7416014)(376014)(36860700016)(23010399003)(921020)(18002099003)(22082099003)(11063799006)(4143699003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9W1ZWKpUwW0BRESOg7aNrJHiunbq4xCwPiP4eHJvCJYTYbOMBw/8awYylc2vTE3iz3mezBQB5rzQxlx+xnEFMznFYiSBXeDg7dT8ePcmy79WJ15WFIoBZZDTVL81sz5RI7nBX2Z2cLk84tO5YRnF1011f8W5jbF4ZrHgkQK7ZAygYv9tlpX2casHF8jybAonSNEWu99O8S0IANiSGmNOOmpZInAI6EtFHHrkY90FVofSipkm/vcf97PZkX15r3KSFPluPv8rqlQUa/+4Cz8eXbRMkOM1wy0/qStZbbsQE4OlXbve/qd3nHo4eKk8Tp8q6O8Kbj5hDAkgv9n2BX1xWTd/qpdi3UR2yfE8Qku5eRkMY6PNCy6LtB3x8wdniYbJHr8PZ4I2FCoz98pOLCbI0aEfItTyQA7Ralq/hcl/Ihz78xl4NwjOrDYxzbGcWYXc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2026 10:41:59.7393 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02f363ed-2cc3-4e49-faf2-08df035ea87c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[149.199.90.133];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EA.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6867 On 8/26/2026 3:45 PM, Kayra Cizmeci wrote: > @@ -7996,12 +7996,12 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags) > * Let's add the task's estimated utilization to the cfs_rq's > * estimated utilization, before we update schedutil. > */ > - if (!p->se.sched_delayed || (flags & ENQUEUE_DELAYED)) > + if (!p->se.sched_delayed || delayed) nit. This reads funny now - not delayed or delayed? Maybe wakeup_delayed but all of this should be optimized by compiler at the end and a big ENQUEUE_DELAYED is better for humans who are reading the code no? > util_est_enqueue(cfs_rq, p); > > update_curr_eevdf(cfs_rq); > > - if (flags & ENQUEUE_DELAYED) { > + if (delayed) { > requeue_delayed_entity(cfs_rq, se); > return; > } -- Thanks and Regards, Prateek